Commit Graph

334 Commits

Author SHA1 Message Date
James Hegedus
c9e5df443b
Merge pull request #323 from nihalgonsalves/patch-1 2022-10-27 09:58:23 +11:00
Nihal Gonsalves
ec46bdf07b
feat: add the hydrogen LTS codename (node v18)
`asdf install` does work for alias `lts-hydrogen`, but it does not display it when running `asdf list-all nodejs`. This makes it clear that it is indeed a supported LTS alias.
2022-10-26 16:51:49 +02:00
Augusto Moura
65441d3752
Merge pull request #314 from augustobmoura/feat/add-gitattributes 2022-09-02 00:22:44 -03:00
Augusto Moura
d12779b429
chore: add gitattributes for cr/lf conversion 2022-09-02 00:19:49 -03:00
Augusto Moura
adda4621b7
Merge pull request #228 from augustobmoura/fix/dont-override-prefix 2022-09-02 00:15:49 -03:00
Augusto Moura
b085d576c6
fix prefix being override unecessarily
node already resolves the correct prefix based on the binary location,
the problem with overriding it is that the prefix can be customized to a
different location in the .npmrc config file global. We already permit
prefix customization by setting the variable itself
2022-08-11 11:26:03 -03:00
Augusto Moura
05f99c37d0
Merge pull request #307 from augustobmoura/fix/printf-broken-pipe
fix: add cat to circumvent printf's broken pipe on bash3
2022-06-15 22:47:56 -03:00
Augusto Moura
d62b66ae18
fix: add cat to circumvent printf's broken pipe on bash3 2022-06-08 13:56:36 -03:00
Augusto Moura
b2d06a768d
Merge pull request #298 from augustobmoura/feature/lts-aliases-changes
Filter versions that don't have nodebuild definitions from lts aliases
2022-04-27 09:54:33 -03:00
Augusto Moura
9c00a9e878
feat: remove unnecessary quotes 2022-04-27 09:48:25 -03:00
Augusto Moura
5d34772d02
fix: run alias filtering everytime because of nodebuild
nodebuild can be updated and make new definitions available, we need to
filter for lts aliases everytime, and only cache the request to
index.tab
2022-03-16 16:50:16 -03:00
Augusto Moura
aded55ba04
fix: skip versions when filtering aliases if not available on nodebuild 2022-03-16 15:08:18 -03:00
Augusto Moura
f9957f3f25
Merge pull request #292 from burnettk/filter-list-all-to-ensure-we-can-install-them
if a version is not installable via node-build, make sure it is not in list-all
2022-03-14 15:03:28 -03:00
Kevin Burnett
1365f37112
ensure nodebuild is installed before calling it
Co-authored-by: Augusto Moura <augusto.moura@toptal.com>
2022-03-14 09:47:55 -04:00
burnettk
a20484c57f promote nodebuild_wrapped from install to utils so we can use it in list-all 2022-03-12 17:58:31 -05:00
Kevin Burnett
e893a30a24
Apply suggestions from code review
Co-authored-by: Augusto Moura <augusto.moura@toptal.com>
2022-03-12 17:48:33 -05:00
burnettk
073424cda0 only touch list-all and stop hitting http endpoint, per code review suggestion 2022-03-11 12:48:17 -05:00
burnettk
eb110f87bd if a version is not available in node-build, make sure it is not in list-all 2022-03-11 09:26:31 -05:00
Augusto Moura
364c078340
Merge pull request #291 from augustobmoura/feat/comments-on-default-packages
feat: add comments to default npm packages
2022-02-21 10:17:09 -03:00
Augusto Moura
95b22c98d0
Merge pull request #290 from jfly/issue-289-fix
Don't set `NODE_BUILD_BUILD_PATH`
2022-02-21 10:06:54 -03:00
Jeremy Fleischman
dbc07b70a9
Don't set NODE_BUILD_BUILD_PATH
If not set, [node-build defaults to a timestamped subdirectory of
`TMPDIR`](https://github.com/nodenv/node-build#custom-build-configuration),
which is exactly what we need.

This fixes https://github.com/asdf-vm/asdf-nodejs/issues/289

With this change, I see repeated builds fail in the exact same way (see
https://github.com/asdf-vm/asdf-nodejs/issues/289 for a detailed
explanation of what used to happen):

    $ PATH="$PWD:$PATH" ASDF_NODEJS_FORCE_COMPILE=1 asdf install nodejs 14.18.1
    Trying to update node-build... ok

    WARNING: node-v14.18.1 is in LTS Maintenance mode and nearing its end of life.
    It only receives *critical* security updates, *critical* bug fixes and documentation updates.

    Installing node-v14.18.1...

    BUILD FAILED (Arch rolling using node-build 4.9.69)

    Inspect or clean up the working tree at /tmp/node-build.20220216023317.178521.tZF5cV
    Results logged to /tmp/node-build.20220216023317.178521.log

    Last 10 log lines:
    /tmp/node-build.20220216023317.178521.tZF5cV ~/tmp/demoing
    /tmp/node-build.20220216023317.178521.tZF5cV/node-v14.18.1 /tmp/node-build.20220216023317.178521.tZF5cV ~/tmp/demoing
    Node.js configure: Found Python 3.9.6...
    WARNING: C compiler (CC=gcc, 0.0.0) too old, need gcc 4.2 or clang 3.2
    WARNING: Could not recognize `gas`:
    ERROR: Did not find a new enough assembler, install one or build with
           --openssl-no-asm.
           Please refer to BUILDING.md

    $ PATH="$PWD:$PATH" ASDF_NODEJS_FORCE_COMPILE=1 asdf install nodejs 14.18.1
    Trying to update node-build... ok

    WARNING: node-v14.18.1 is in LTS Maintenance mode and nearing its end of life.
    It only receives *critical* security updates, *critical* bug fixes and documentation updates.

    Installing node-v14.18.1...

    BUILD FAILED (Arch rolling using node-build 4.9.69)

    Inspect or clean up the working tree at /tmp/node-build.20220216023335.178790.u0kcPV
    Results logged to /tmp/node-build.20220216023335.178790.log

    Last 10 log lines:
    /tmp/node-build.20220216023335.178790.u0kcPV ~/tmp/demoing
    /tmp/node-build.20220216023335.178790.u0kcPV/node-v14.18.1 /tmp/node-build.20220216023335.178790.u0kcPV ~/tmp/demoing
    Node.js configure: Found Python 3.9.6...
    WARNING: C compiler (CC=gcc, 0.0.0) too old, need gcc 4.2 or clang 3.2
    WARNING: Could not recognize `gas`:
    ERROR: Did not find a new enough assembler, install one or build with
           --openssl-no-asm.
           Please refer to BUILDING.md
2022-02-16 02:36:31 -08:00
Augusto Moura
ad4c3a7b54
Merge pull request #288 from augustobmoura/feat/manual-gh-actions
Add workflow_dispatch trigger to manually running the test GH action
2022-02-13 23:25:01 -03:00
Augusto Moura
0645ab4182
chore: add workflow_dispatch trigger to testing action 2022-02-13 23:23:48 -03:00
Augusto Moura
7f5a86ce00
feat: add comments to default npm packages 2022-02-09 22:29:34 -03:00
Augusto Moura
50656e514c
Merge pull request #286 from augustobmoura/feat/add-gh-actions-badge
Add GH Actions badge instead of Travis CI
2022-02-09 21:36:34 -03:00
Augusto Moura
7c96d62ef8
feat: add GH Actions badge instead of Travis CI 2022-02-09 21:35:41 -03:00
Augusto Moura
a86d274479
Merge pull request #285 from augustobmoura/fix/fix-gh-actions
Fix GH action for basic testing
2022-02-09 21:21:05 -03:00
Augusto Moura
4b329e7d36
fix: fix gh action for basic testing 2022-02-09 21:20:19 -03:00
Augusto Moura
223cb30f9a
Merge pull request #196 from smorimoto/github-actions
Switch from TravisCI to GitHub Actions
2022-02-09 21:15:39 -03:00
Augusto Moura
d7170680f7
Merge pull request #284 from augustobmoura/feature/force-rebuild-option
Add option for forcing compilation when installing
2022-02-09 20:56:12 -03:00
Augusto Moura
2f7ed7520c
feat: add force rebuild variable 2022-02-09 20:12:37 -03:00
Augusto Moura
ed34355316
Merge pull request #278 from augustobmoura/fix/add-link-cmds-npm-shim
Add auto reshim for npm link
2021-12-24 00:55:29 -03:00
Augusto Moura
b842e07571
Merge pull request #279 from augustobmoura/fix/data-dir-resolve
Change fallbacks to ASDF_DATA_DIR to not include ASDF_DIR
2021-12-24 00:45:06 -03:00
Augusto Moura
11532b61d9
fix: change fallbacks to ASDF_DATA_DIR to not include ASDF_DIR 2021-12-24 00:40:45 -03:00
Augusto Moura
05a7fc6269
feat: add auto reshim for npm link 2021-12-24 00:31:16 -03:00
Augusto Moura
0237452eb2
Merge pull request #274 from augustobmoura/fix/remove-bc-dependency
Remove dependency on bc in favor of a pure bash implementation
2021-12-20 17:13:20 -03:00
Augusto Moura
f08937dfa3
fix: remove dependency on bc in favor of a pure bash alternative 2021-12-20 17:09:07 -03:00
Augusto Moura
6430bd8e82
Merge pull request #272 from augustobmoura/feature/nodenv-build-system
Use node-build as main installation/building drive
2021-12-20 12:58:26 -03:00
Augusto Moura
b58ae2359f
fix: add fallback for unbound variables in bash3 2021-12-16 21:10:58 -03:00
Augusto Moura
e0d3804a55
docs: better explanation of manually updating node-build 2021-12-15 14:17:39 -03:00
Augusto Moura
363c0d1d9f
fix: add fallback for empty arrays in bash3 2021-12-15 14:07:51 -03:00
Augusto Moura
dcc73aea0e
fix: fix typos & revert import of utils.sh 2021-12-13 22:50:58 -03:00
Augusto Moura
3e44540e9a
docs: better wording for the README 2021-12-07 00:15:06 -03:00
Augusto Moura
58859abcd5
chore: better messages 2021-12-07 00:03:28 -03:00
Augusto Moura
e2e0db2aad
chore: add better error messages 2021-11-29 15:00:39 -03:00
Augusto Moura
07fe573c33
docs: add section for running the wrapped node-build command
also some minor text adjustments
2021-11-29 12:53:18 -03:00
Augusto Moura
1dd98c407c
typo: change defitions to definitions 2021-11-29 12:49:58 -03:00
Augusto Moura
1a70296fdc
fix: add correct default for concurrency 2021-11-29 12:48:30 -03:00
Augusto Moura
94bd796e02
docs: add information on nodebuild commands 2021-11-29 12:48:06 -03:00
Augusto Moura
67c382b8a2
docs: update README com new information about installation 2021-11-24 00:20:25 -03:00