From e480d296feda5e9c07b3ac3699eb76d2056867ea Mon Sep 17 00:00:00 2001 From: Ibby Hadeed Date: Mon, 11 Dec 2017 19:34:54 -0500 Subject: [PATCH 1/3] 4.5.2 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index ebea6004b..c7cf02487 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "ionic-native", - "version": "4.5.1", + "version": "4.5.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 17c920439..dfead97ca 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "ionic-native", - "version": "4.5.1", + "version": "4.5.2", "description": "Native plugin wrappers for Cordova and Ionic with TypeScript, ES6+, Promise and Observable support", "homepage": "https://ionicframework.com/", "author": "Ionic Team (https://ionic.io)", From e4dd8dcb89885ddb819f8d5f79b9263592e32670 Mon Sep 17 00:00:00 2001 From: Rory Standley Date: Thu, 25 Jan 2018 11:18:18 +0000 Subject: [PATCH 2/3] docs(): type of yes is boolean not string (#2290) --- src/@ionic-native/plugins/app-availability/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/@ionic-native/plugins/app-availability/index.ts b/src/@ionic-native/plugins/app-availability/index.ts index 3011921b0..3ff0b1996 100644 --- a/src/@ionic-native/plugins/app-availability/index.ts +++ b/src/@ionic-native/plugins/app-availability/index.ts @@ -27,8 +27,8 @@ import { Cordova, Plugin, IonicNativePlugin } from '@ionic-native/core'; * * this.appAvailability.check(app) * .then( - * (yes: string) => console.log(app + ' is available'), - * (no: string) => console.log(app + ' is NOT available') + * (yes: boolean) => console.log(app + ' is available'), + * (no: boolean) => console.log(app + ' is NOT available') * ); * ``` */ From 61293c33ccac05eba5230c0afb9ab3fa70f68513 Mon Sep 17 00:00:00 2001 From: Max Lynch Date: Thu, 25 Jan 2018 11:11:06 -0600 Subject: [PATCH 3/3] fix(pro): proper callback type and guard for plugin instantiate. #2136 #2127 --- src/@ionic-native/plugins/pro/index.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/@ionic-native/plugins/pro/index.ts b/src/@ionic-native/plugins/pro/index.ts index 1475c86b6..bbdb6258e 100644 --- a/src/@ionic-native/plugins/pro/index.ts +++ b/src/@ionic-native/plugins/pro/index.ts @@ -49,9 +49,7 @@ export class ProDeploy { * Check a channel for an available update * @return {Promise} Resolves with 'true' or 'false', or rejects with an error. */ - @CordovaInstance({ - observable: true - }) + @CordovaInstance() check(): Promise { return; } /** @@ -67,7 +65,9 @@ export class ProDeploy { * Unzip the latest downloaded version * @return {Observable} Updates with percent completion, or errors with a message. */ - @CordovaInstance() + @CordovaInstance({ + observable: true + }) extract(): Observable { return; } /** @@ -133,7 +133,7 @@ export class Pro extends IonicNativePlugin { /** * Ionic Pro Deploy .js API. */ - deploy: ProDeploy = new ProDeploy(Pro.getPlugin().deploy); + deploy: ProDeploy = new ProDeploy((Pro.getPlugin() || {}).deploy); /** * Not yet implemented