From b934c1be6a90ac88c077d5bd922c66fa1cf32363 Mon Sep 17 00:00:00 2001
From: Andrew Grieve <agrieve@chromium.org>
Date: Mon, 14 Jul 2014 14:10:19 -0400
Subject: [PATCH] @Deprecate methods of PluginManager that were never meant to
 be public

---
 framework/src/org/apache/cordova/PluginManager.java | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/framework/src/org/apache/cordova/PluginManager.java b/framework/src/org/apache/cordova/PluginManager.java
index eb3e6f9c..689c3c86 100755
--- a/framework/src/org/apache/cordova/PluginManager.java
+++ b/framework/src/org/apache/cordova/PluginManager.java
@@ -84,6 +84,7 @@ public class PluginManager {
     /**
      * Init when loading a new HTML page into webview.
      */
+    @Deprecated // Should not be exposed as public.
     public void init() {
         LOG.d(TAG, "init()");
         this.onPause(false);
@@ -99,6 +100,7 @@ public class PluginManager {
     /**
      * Delete all plugin objects.
      */
+    @Deprecated // Should not be exposed as public.
     public void clearPluginObjects() {
         pluginMap.clear();
     }
@@ -106,6 +108,7 @@ public class PluginManager {
     /**
      * Create plugins objects that have onload set.
      */
+    @Deprecated // Should not be exposed as public.
     public void startupPlugins() {
         for (PluginEntry entry : entryMap.values()) {
             if (entry.onload) {
@@ -228,6 +231,7 @@ public class PluginManager {
      *
      * @param multitasking      Flag indicating if multitasking is turned on for app
      */
+    @Deprecated // Should not be public
     public void onPause(boolean multitasking) {
         for (CordovaPlugin plugin : this.pluginMap.values()) {
             plugin.onPause(multitasking);
@@ -239,6 +243,7 @@ public class PluginManager {
      *
      * @param multitasking      Flag indicating if multitasking is turned on for app
      */
+    @Deprecated // Should not be public
     public void onResume(boolean multitasking) {
         for (CordovaPlugin plugin : this.pluginMap.values()) {
             plugin.onResume(multitasking);
@@ -248,6 +253,7 @@ public class PluginManager {
     /**
      * The final call you receive before your activity is destroyed.
      */
+    @Deprecated // Should not be public
     public void onDestroy() {
         for (CordovaPlugin plugin : this.pluginMap.values()) {
             plugin.onDestroy();
@@ -278,6 +284,7 @@ public class PluginManager {
     /**
      * Called when the activity receives a new intent.
      */
+    @Deprecated // Should not be public
     public void onNewIntent(Intent intent) {
         for (CordovaPlugin plugin : this.pluginMap.values()) {
             plugin.onNewIntent(intent);
@@ -290,6 +297,7 @@ public class PluginManager {
      * @param url               The URL that is being changed to.
      * @return                  Return false to allow the URL to load, return true to prevent the URL from loading.
      */
+    @Deprecated // Should not be public
     public boolean onOverrideUrlLoading(String url) {
         // Deprecated way to intercept URLs. (process <url-filter> tags).
         // Instead, plugins should not include <url-filter> and instead ensure
@@ -316,6 +324,7 @@ public class PluginManager {
     /**
      * Called when the app navigates or refreshes.
      */
+    @Deprecated // Should not be public
     public void onReset() {
         for (CordovaPlugin plugin : this.pluginMap.values()) {
             plugin.onReset();