github/cordova-android
github/cordova-android
3
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2024-10-07 02:02:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove @Override from interface methods

Browse Source 
In Java 6 you will get an error in Eclipse if your put the @Override annotation on a method of an interface. You are not really over riding the methods you are implementing it. This is an undocumented change in Java 6. Just cleaning up our usage of this so some project problems got away.

Note: Things will build fine using 'ant jar' even with the @Override's.
This commit is contained in:
Simon MacDonald 2012-10-02 11:42:12 -04:00
parent 05bc1865a6
commit d1ab1b59be
5 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
framework/src/org/apache/cordova/DroidGap.java
View File

@ -1056,7 +1056,6 @@ public class DroidGap extends Activity implements CordovaInterface {
return null;
}
@Override
public ExecutorService getThreadPool() {
return threadPool;
}

2
framework/src/org/apache/cordova/Echo.java
View File

@ -33,7 +33,7 @@ public class Echo extends CordovaPlugin {
return true;
} else if ("echoAsync".equals(action)) {
cordova.getThreadPool().execute(new Runnable() {
@Override public void run() {
public void run() {
callbackContext.success(result);
}
});

3
framework/src/org/apache/cordova/FileTransfer.java
View File

@ -205,7 +205,6 @@ public class FileTransfer extends CordovaPlugin {
}
cordova.getThreadPool().execute(new Runnable() {
@Override
public void run() {
if (context.aborted) {
return;
@ -615,7 +614,6 @@ public class FileTransfer extends CordovaPlugin {
}
cordova.getThreadPool().execute(new Runnable() {
@Override
public void run() {
if (context.aborted) {
return;
@ -810,7 +808,6 @@ public class FileTransfer extends CordovaPlugin {
}
// Closing the streams can block, so execute on a background thread.
cordova.getThreadPool().execute(new Runnable() {
@Override
public void run() {
synchronized (context) {
safeClose(context.currentInputStream);

1
framework/src/org/apache/cordova/NativeToJsMessageQueue.java
View File

@ -293,7 +293,6 @@ public class NativeToJsMessageQueue {
private class OnlineEventsBridgeMode implements BridgeMode {
boolean online = true;
final Runnable runnable = new Runnable() {
@Override
public void run() {
if (!queue.isEmpty()) {
online = !online;

1
framework/src/org/apache/cordova/api/LegacyContext.java
View File

@ -148,7 +148,6 @@ public class LegacyContext implements CordovaInterface {
this.cordova.getActivity().unbindService(conn);
}
@Override
public ExecutorService getThreadPool() {
Log.i(LOG_TAG, "Replace ctx.getThreadPool() with cordova.getThreadPool()");
return this.cordova.getThreadPool();