github/cordova-plugin-statusbar
github/cordova-plugin-statusbar
3
0
Fork 0
mirror of https://github.com/apache/cordova-plugin-statusbar.git synced 2024-10-06 00:22:08 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(iOS): Inline code to find the webview's scrollView (#272)

Browse Source 
Currently this works because of a category extension that adds a
`scrollView` method to every UIView instance, but that causes issues for
SwiftUI so we want to remove that extension from cordova-ios.

Since we do need to be able to look up the scrollView in this plugin, we
can just define a private local method that does the same thing in a way
that doesn't pollute global UIKit classes.

Ref: https://github.com/apache/cordova-ios/pull/1400
This commit is contained in:
Darryl Pogue 2024-08-20 00:25:39 -07:00 committed by GitHub
parent 6132b4474c
commit 5492147ab7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ios/CDVStatusBar.m
View File

@ -25,6 +25,7 @@
#import "CDVStatusBar.h" #import "CDVStatusBar.h"
#import <objc/runtime.h> #import <objc/runtime.h>
#import <objc/message.h>
#import <Cordova/CDVViewController.h> #import <Cordova/CDVViewController.h>
static const void *kHideStatusBar = &kHideStatusBar; static const void *kHideStatusBar = &kHideStatusBar;
@ -143,9 +144,9 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
setting = @"StatusBarDefaultScrollToTop"; setting = @"StatusBarDefaultScrollToTop";
if ([self settingForKey:setting]) { if ([self settingForKey:setting]) {
self.webView.scrollView.scrollsToTop = [(NSNumber*)[self settingForKey:setting] boolValue]; [self webViewScrollView].scrollsToTop = [(NSNumber*)[self settingForKey:setting] boolValue];
} else { } else {
self.webView.scrollView.scrollsToTop = NO; [self webViewScrollView].scrollsToTop = NO;
} }
// blank scroll view to intercept status bar taps // blank scroll view to intercept status bar taps
@ -462,6 +463,17 @@ static const void *kStatusBarStyle = &kStatusBarStyle;
[[NSNotificationCenter defaultCenter]removeObserver:self name:UIApplicationDidChangeStatusBarOrientationNotification object:nil]; [[NSNotificationCenter defaultCenter]removeObserver:self name:UIApplicationDidChangeStatusBarOrientationNotification object:nil];
} }
- (UIScrollView *)webViewScrollView
{
SEL scrollViewSelector = NSSelectorFromString(@"scrollView");
if ([self.webView respondsToSelector:scrollViewSelector]) {
return ((id (*)(id, SEL))objc_msgSend)(self.webView, scrollViewSelector);
}
return nil;
}
#pragma mark - UIScrollViewDelegate #pragma mark - UIScrollViewDelegate