public/awesome-cordova-plugins
public/awesome-cordova-plugins
9
0
Fork 0
forked from github/awesome-cordova-plugins
Code Pull Requests Activity

refactor(plugin): improvement pull #654 (#661)

Browse Source
This commit is contained in:
Ramon Henrique Ornelas 2016-10-08 16:07:01 -03:00 committed by Ibrahim Hadeed
parent 2c6cc37a5f
commit d3e6f3ba41
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/plugin.ts
View File

@ -41,6 +41,11 @@ export const cordovaWarn = function(pluginName: string, method: string) {
} }
}; };
function setIndex(args: any[], opts: any = {}, resolve?: Function, reject?: Function): any { function setIndex(args: any[], opts: any = {}, resolve?: Function, reject?: Function): any {
// ignore resolve and reject in case sync
if (opts.sync) {
return args;
}
// If the plugin method expects myMethod(success, err, options) // If the plugin method expects myMethod(success, err, options)
if (opts.callbackOrder === 'reverse') { if (opts.callbackOrder === 'reverse') {
// Get those arguments in the order [resolve, reject, ...restOfArgs] // Get those arguments in the order [resolve, reject, ...restOfArgs]
@ -77,10 +82,8 @@ function setIndex(args: any[], opts: any = {}, resolve?: Function, reject?: Func
} else { } else {
// Otherwise, let's tack them on to the end of the argument list // Otherwise, let's tack them on to the end of the argument list
// which is 90% of cases // which is 90% of cases
if (!opts.sync) { args.push(resolve);
args.push(resolve); args.push(reject);
args.push(reject);
}
} }
return args; return args;
} }