From 090890b22a45b28c145ccc93123c724408738dba Mon Sep 17 00:00:00 2001 From: Dave Johnson Date: Thu, 7 Jul 2011 00:08:11 -0700 Subject: [PATCH] Update PluginManager to accept plugins that implement IPlugin rather than extend Plugin --- .../src/com/phonegap/api/PluginManager.java | 44 +++++++++---------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/framework/src/com/phonegap/api/PluginManager.java b/framework/src/com/phonegap/api/PluginManager.java index e94d0ee5..4af3ffb3 100755 --- a/framework/src/com/phonegap/api/PluginManager.java +++ b/framework/src/com/phonegap/api/PluginManager.java @@ -27,7 +27,7 @@ import android.webkit.WebView; */ public final class PluginManager { - private HashMap plugins = new HashMap(); + private HashMap plugins = new HashMap(); private HashMap services = new HashMap(); private final PhonegapActivity ctx; @@ -105,7 +105,7 @@ public final class PluginManager { c = getClassByName(clazz); } if (isPhoneGapPlugin(c)) { - final Plugin plugin = this.addPlugin(clazz, c); + final IPlugin plugin = this.addPlugin(clazz, c); final PhonegapActivity ctx = this.ctx; runAsync = async && !plugin.isSynch(action); if (runAsync) { @@ -201,12 +201,12 @@ public final class PluginManager { * @return The plugin */ @SuppressWarnings("unchecked") - private Plugin addPlugin(String className, Class clazz) { + private IPlugin addPlugin(String className, Class clazz) { if (this.plugins.containsKey(className)) { return this.getPlugin(className); } try { - Plugin plugin = (Plugin)clazz.newInstance(); + IPlugin plugin = (IPlugin)clazz.newInstance(); this.plugins.put(className, plugin); plugin.setContext(this.ctx); plugin.setView(this.app); @@ -225,8 +225,8 @@ public final class PluginManager { * @param className The class of the loaded plugin. * @return */ - private Plugin getPlugin(String className) { - Plugin plugin = this.plugins.get(className); + private IPlugin getPlugin(String className) { + IPlugin plugin = this.plugins.get(className); return plugin; } @@ -247,11 +247,11 @@ public final class PluginManager { * @param multitasking Flag indicating if multitasking is turned on for app */ public void onPause(boolean multitasking) { - java.util.Set> s = this.plugins.entrySet(); - java.util.Iterator> it = s.iterator(); + java.util.Set> s = this.plugins.entrySet(); + java.util.Iterator> it = s.iterator(); while(it.hasNext()) { - Entry entry = it.next(); - Plugin plugin = entry.getValue(); + Entry entry = it.next(); + IPlugin plugin = entry.getValue(); plugin.onPause(multitasking); } } @@ -262,11 +262,11 @@ public final class PluginManager { * @param multitasking Flag indicating if multitasking is turned on for app */ public void onResume(boolean multitasking) { - java.util.Set> s = this.plugins.entrySet(); - java.util.Iterator> it = s.iterator(); + java.util.Set> s = this.plugins.entrySet(); + java.util.Iterator> it = s.iterator(); while(it.hasNext()) { - Entry entry = it.next(); - Plugin plugin = entry.getValue(); + Entry entry = it.next(); + IPlugin plugin = entry.getValue(); plugin.onResume(multitasking); } } @@ -275,11 +275,11 @@ public final class PluginManager { * The final call you receive before your activity is destroyed. */ public void onDestroy() { - java.util.Set> s = this.plugins.entrySet(); - java.util.Iterator> it = s.iterator(); + java.util.Set> s = this.plugins.entrySet(); + java.util.Iterator> it = s.iterator(); while(it.hasNext()) { - Entry entry = it.next(); - Plugin plugin = entry.getValue(); + Entry entry = it.next(); + IPlugin plugin = entry.getValue(); plugin.onDestroy(); } } @@ -288,11 +288,11 @@ public final class PluginManager { * Called when the activity receives a new intent. */ public void onNewIntent(Intent intent) { - java.util.Set> s = this.plugins.entrySet(); - java.util.Iterator> it = s.iterator(); + java.util.Set> s = this.plugins.entrySet(); + java.util.Iterator> it = s.iterator(); while(it.hasNext()) { - Entry entry = it.next(); - Plugin plugin = entry.getValue(); + Entry entry = it.next(); + IPlugin plugin = entry.getValue(); plugin.onNewIntent(intent); } }