Use jquery data() instead of element attributes

This commit is contained in:
Pierre-Olivier Latour
2014-04-14 18:28:22 -03:00
parent dafcb0d895
commit b949187770
2 changed files with 11 additions and 11 deletions
@@ -138,7 +138,7 @@
</div> </div>
<script type="text/x-tmpl" id="template-listing"> <script type="text/x-tmpl" id="template-listing">
<tr class="row-file" data-path="{%=o.path%}" data-name="{%=o.name%}"> <tr class="row-file">
<td class="column-icon"> <td class="column-icon">
{% if (o.size != null) { %} {% if (o.size != null) { %}
<button type="button" class="btn btn-default btn-xs button-download"> <button type="button" class="btn btn-default btn-xs button-download">
@@ -79,7 +79,7 @@ function _reload(path) {
$("#path").append('<li data-path="' + subpath + '"><a>' + components[i] + '</a></li>'); $("#path").append('<li data-path="' + subpath + '"><a>' + components[i] + '</a></li>');
} }
$("#path > li").click(function(event) { $("#path > li").click(function(event) {
_reload($(this).attr("data-path")); _reload($(this).data("path"));
event.preventDefault(); event.preventDefault();
}); });
$("#path").append('<li class="active">' + components[components.length - 1] + '</li>'); $("#path").append('<li class="active">' + components[components.length - 1] + '</li>');
@@ -89,13 +89,13 @@ function _reload(path) {
$("#listing").empty(); $("#listing").empty();
for (var i = 0, file; file = data[i]; ++i) { for (var i = 0, file; file = data[i]; ++i) {
$("#listing").append(tmpl("template-listing", file)); $(tmpl("template-listing", file)).data(file).appendTo("#listing");
} }
$(".edit").editable(function(value, settings) { $(".edit").editable(function(value, settings) {
var name = $(this).parent().parent().attr("data-name"); var name = $(this).parent().parent().data("name");
if (value != name) { if (value != name) {
var path = $(this).parent().parent().attr("data-path"); var path = $(this).parent().parent().data("path");
$.ajax({ $.ajax({
url: 'move', url: 'move',
type: 'POST', type: 'POST',
@@ -113,29 +113,29 @@ function _reload(path) {
}); });
$(".button-download").click(function(event) { $(".button-download").click(function(event) {
var path = $(this).parent().parent().attr("data-path"); var path = $(this).parent().parent().data("path");
setTimeout(function() { setTimeout(function() {
window.location = "download?path=" + encodeURIComponent(path); window.location = "download?path=" + encodeURIComponent(path);
}, 0); }, 0);
}); });
$(".button-open").click(function(event) { $(".button-open").click(function(event) {
var path = $(this).parent().parent().attr("data-path"); var path = $(this).parent().parent().data("path");
_reload(path); _reload(path);
}); });
$(".button-move").click(function(event) { $(".button-move").click(function(event) {
var path = $(this).parent().parent().attr("data-path"); var path = $(this).parent().parent().data("path");
if (path[path.length - 1] == "/") { if (path[path.length - 1] == "/") {
path = path.slice(0, path.length - 1); path = path.slice(0, path.length - 1);
} }
$("#move-input").attr("data-path", path); $("#move-input").data("path", path);
$("#move-input").val(path); $("#move-input").val(path);
$("#move-modal").modal("show"); $("#move-modal").modal("show");
}); });
$(".button-delete").click(function(event) { $(".button-delete").click(function(event) {
var path = $(this).parent().parent().attr("data-path"); var path = $(this).parent().parent().data("path");
$.ajax({ $.ajax({
url: 'delete', url: 'delete',
type: 'POST', type: 'POST',
@@ -260,7 +260,7 @@ $(document).ready(function() {
$("#move-confirm").click(function(event) { $("#move-confirm").click(function(event) {
$("#move-modal").modal("hide"); $("#move-modal").modal("hide");
var oldPath = $("#move-input").attr("data-path"); var oldPath = $("#move-input").data("path");
var newPath = $("#move-input").val(); var newPath = $("#move-input").val();
if ((newPath != "") && (newPath[0] == "/") && (newPath != oldPath)) { if ((newPath != "") && (newPath[0] == "/") && (newPath != oldPath)) {
$.ajax({ $.ajax({