From 46502cb8649940e76d73161b3cf02bbee9d1c6d4 Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Sun, 14 May 2017 11:30:34 +0200 Subject: [PATCH 1/5] docs(ionic-site): CLI V3 command (#1556) --- scripts/docs/templates/readme.template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/docs/templates/readme.template.md b/scripts/docs/templates/readme.template.md index 69fd10d5e..be66fad9c 100644 --- a/scripts/docs/templates/readme.template.md +++ b/scripts/docs/templates/readme.template.md @@ -16,7 +16,7 @@ <@ for prop in doc.decorators[0].argumentInfo @> ``` -$ <@ if prop.install @><$ prop.install $><@ else @>ionic plugin add <$ prop.plugin $><@ endif @> +$ <@ if prop.install @><$ prop.install $><@ else @>ionic cordova plugin add <$ prop.plugin $><@ endif @> $ npm install --save @ionic-native/<$ doc.npmId $> ``` From bd1794d7f5a8bce8e7a803068d24d8efa8fc4e5e Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Mon, 15 May 2017 09:23:54 +0200 Subject: [PATCH 2/5] github(template): issue template (#1559) * github(tempalte): issue template * Update ISSUE_TEMPLATE.md --- .github/ISSUE_TEMPLATE.md | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 000000000..674b8feb8 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,28 @@ +**I'm submitting a ...** (check one with "x") +[ ] bug report +[ ] feature request +[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or https://ionicworldwide.herokuapp.com/ + +**Current behavior:** + + +**Expected behavior:** + + +**Steps to reproduce:** + + +**Related code:** + +``` +insert any relevant code here +``` + +**Other information:** + + +**package.json info:** + +```json +insert the content here +``` From 7c797123f56dff4f583180af50419fcf1c2b7460 Mon Sep 17 00:00:00 2001 From: Raman Rasliuk Date: Mon, 15 May 2017 10:55:06 +0200 Subject: [PATCH 3/5] fix(file): add toInternalURL (#1561) * Put back toInternalURL What was the reason to remove `toInternalURL` from `Entry`? Fixes #1560 * Remove trailing whitespace --- src/@ionic-native/plugins/file/index.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/@ionic-native/plugins/file/index.ts b/src/@ionic-native/plugins/file/index.ts index 63d1021b9..c330d0752 100644 --- a/src/@ionic-native/plugins/file/index.ts +++ b/src/@ionic-native/plugins/file/index.ts @@ -159,6 +159,12 @@ export interface Entry { */ toURL(): string; + /** + * Return a URL that can be passed across the bridge to identify this entry. + * @return string URL that can be passed across the bridge to identify this entry + */ + toInternalURL(): string; + /** * Deletes a file or directory. It is an error to attempt to delete a directory that is not empty. It is an error to attempt to delete the root directory of a filesystem. * @param successCallback A callback that is called on success. From adf9c5a323126450d36a0c941baa65d83aafb4e8 Mon Sep 17 00:00:00 2001 From: David Routhieau Date: Mon, 15 May 2017 21:38:39 -0700 Subject: [PATCH 4/5] fix(file): fix repo link (#1566) --- src/@ionic-native/plugins/file/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/file/index.ts b/src/@ionic-native/plugins/file/index.ts index c330d0752..506b6365b 100644 --- a/src/@ionic-native/plugins/file/index.ts +++ b/src/@ionic-native/plugins/file/index.ts @@ -562,7 +562,7 @@ declare const window: Window; pluginName: 'File', plugin: 'cordova-plugin-file', pluginRef: 'cordova.file', - repo: 'https: //github.com/apache/cordova-plugin-file', + repo: 'https://github.com/apache/cordova-plugin-file', platforms: ['Android', 'BlackBerry 10', 'Browser', 'Firefox OS', 'iOS', 'OS X', 'Ubuntu', 'Windows', 'Windows Phone'] }) @Injectable() From b35417a017f2eca422c03a235c5cc03724bbd9a1 Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Tue, 16 May 2017 10:32:31 +0200 Subject: [PATCH 5/5] fix(document-viewer): fix params and docs for canViewDocument (#1568) * refactor(document-viewer): fix example * Update index.ts * Update index.ts --- src/@ionic-native/plugins/document-viewer/index.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/@ionic-native/plugins/document-viewer/index.ts b/src/@ionic-native/plugins/document-viewer/index.ts index dddb963f0..aec4abb64 100644 --- a/src/@ionic-native/plugins/document-viewer/index.ts +++ b/src/@ionic-native/plugins/document-viewer/index.ts @@ -42,10 +42,11 @@ export interface DocumentViewerOptions { * constructor(private document: DocumentViewer) { } * * ... - * const options = { + * const options: DocumentViewerOptions = { * title: 'My PDF' * } - * this.document.view('assets/myFile.pdf', 'application/pdf', options) + * + * this.document.viewDocument('assets/myFile.pdf', 'application/pdf', options) * * ``` * @@ -82,7 +83,7 @@ export class DocumentViewer extends IonicNativePlugin { * @param [onError] {Function} */ @Cordova({ sync: true }) - canViewDocument(url: string, contentType: string, options: Array, onPossible?: Function, onMissingApp?: Function, onImpossible?: Function, onError?: Function): void { } + canViewDocument(url: string, contentType: string, options: DocumentViewerOptions, onPossible?: Function, onMissingApp?: Function, onImpossible?: Function, onError?: Function): void { } /** * Opens the file