chore(npm): bump @cordova/eslint-config@^4.0.0 (#1421)

* chore(npm): bump @cordova/eslint-config@^4.0.0
* style(lint): apply auto corrections
* style(lint): convert hasAndroidHome var to let and hoisted

lib/check_reqs.js

@@ -18,12 +18,12 @@
 */
 
 const execa = require('execa');
-var path = require('path');
-var fs = require('fs-extra');
+const path = require('path');
+const fs = require('fs-extra');
 const { forgivingWhichSync, isWindows, isDarwin } = require('./utils');
 const java = require('./env/java');
 const { CordovaError, ConfigParser, events } = require('cordova-common');
-var android_sdk = require('./android_sdk');
+const android_sdk = require('./android_sdk');
 const { SDK_VERSION } = require('./gradle-config-defaults');
 
 // Re-exporting these for backwards compatibility and for unit testing.
@@ -62,18 +62,18 @@ function getUserTargetSdkVersion (projectRoot) {
 }
 
 module.exports.get_gradle_wrapper = function () {
-    var androidStudioPath;
-    var i = 0;
-    var foundStudio = false;
-    var program_dir;
+    let androidStudioPath;
+    let i = 0;
+    let foundStudio = false;
+    let program_dir;
     // OK, This hack only works on Windows, not on Mac OS or Linux.  We will be deleting this eventually!
     if (module.exports.isWindows()) {
-        var result = execa.sync(path.join(__dirname, 'getASPath.bat'));
+        const result = execa.sync(path.join(__dirname, 'getASPath.bat'));
         // console.log('result.stdout =' + result.stdout.toString());
         // console.log('result.stderr =' + result.stderr.toString());
 
         if (result.stderr.toString().length > 0) {
-            var androidPath = path.join(process.env.ProgramFiles, 'Android') + '/';
+            const androidPath = path.join(process.env.ProgramFiles, 'Android') + '/';
             if (fs.existsSync(androidPath)) {
                 program_dir = fs.readdirSync(androidPath);
                 while (i < program_dir.length && !foundStudio) {
@@ -92,7 +92,7 @@ module.exports.get_gradle_wrapper = function () {
     }
 
     if (androidStudioPath !== null && fs.existsSync(androidStudioPath)) {
-        var dirs = fs.readdirSync(androidStudioPath);
+        const dirs = fs.readdirSync(androidStudioPath);
         if (dirs[0].split('-')[0] === 'gradle') {
             return path.join(androidStudioPath, dirs[0], 'bin', 'gradle');
         }
@@ -104,13 +104,13 @@ module.exports.get_gradle_wrapper = function () {
 
 // Returns a promise. Called only by build and clean commands.
 module.exports.check_gradle = function () {
-    var sdkDir = process.env.ANDROID_SDK_ROOT || process.env.ANDROID_HOME;
+    const sdkDir = process.env.ANDROID_SDK_ROOT || process.env.ANDROID_HOME;
     if (!sdkDir) {
         return Promise.reject(new CordovaError('Could not find gradle wrapper within Android SDK. Could not find Android SDK directory.\n' +
             'Might need to install Android SDK or set up \'ANDROID_SDK_ROOT\' env variable.'));
     }
 
-    var gradlePath = module.exports.get_gradle_wrapper();
+    const gradlePath = module.exports.get_gradle_wrapper();
 
     if (gradlePath.length !== 0) return Promise.resolve(gradlePath);
 
@@ -132,6 +132,8 @@ module.exports.check_java = async function () {
 // Returns a promise.
 module.exports.check_android = function () {
     return Promise.resolve().then(function () {
+        let hasAndroidHome = false;
+
         function maybeSetAndroidHome (value) {
             if (!hasAndroidHome && fs.existsSync(value)) {
                 hasAndroidHome = true;
@@ -139,9 +141,8 @@ module.exports.check_android = function () {
             }
         }
 
-        var adbInPath = forgivingWhichSync('adb');
-        var avdmanagerInPath = forgivingWhichSync('avdmanager');
-        var hasAndroidHome = false;
+        const adbInPath = forgivingWhichSync('adb');
+        const avdmanagerInPath = forgivingWhichSync('avdmanager');
 
         if (process.env.ANDROID_SDK_ROOT) {
             maybeSetAndroidHome(path.resolve(process.env.ANDROID_SDK_ROOT));
@@ -198,7 +199,7 @@ module.exports.check_android = function () {
 
         if (!hasAndroidHome) {
             // If we dont have ANDROID_SDK_ROOT, but we do have some tools on the PATH, try to infer from the tooling PATH.
-            var parentDir, grandParentDir;
+            let parentDir, grandParentDir;
             if (adbInPath) {
                 parentDir = path.dirname(adbInPath);
                 grandParentDir = path.dirname(parentDir);
@@ -247,7 +248,7 @@ module.exports.check_android_target = function (projectRoot) {
     //   android-L
     //   Google Inc.:Google APIs:20
     //   Google Inc.:Glass Development Kit Preview:20
-    var desired_api_level = module.exports.get_target(projectRoot);
+    const desired_api_level = module.exports.get_target(projectRoot);
     return android_sdk.list_targets().then(function (targets) {
         if (targets.indexOf(desired_api_level) >= 0) {
             return targets;
@@ -279,7 +280,7 @@ module.exports.run = function () {
  *                            (for example, check_android_target returns an array of android targets installed)
  * @param {Boolean} installed Indicates whether the requirement is installed or not
  */
-var Requirement = function (id, name, version, installed) {
+const Requirement = function (id, name, version, installed) {
     this.id = id;
     this.name = name;
     this.installed = installed || false;
@@ -296,14 +297,14 @@ var Requirement = function (id, name, version, installed) {
  * @return Promise<Requirement[]> Array of requirements. Due to implementation, promise is always fulfilled.
  */
 module.exports.check_all = function (projectRoot) {
-    var requirements = [
+    const requirements = [
         new Requirement('java', 'Java JDK'),
         new Requirement('androidSdk', 'Android SDK'),
         new Requirement('androidTarget', 'Android target'),
         new Requirement('gradle', 'Gradle')
     ];
 
-    var checkFns = [
+    const checkFns = [
         this.check_java,
         this.check_android,
         this.check_android_target.bind(this, projectRoot),
@@ -313,7 +314,7 @@ module.exports.check_all = function (projectRoot) {
     // Then execute requirement checks one-by-one
     return checkFns.reduce(function (promise, checkFn, idx) {
         // Update each requirement with results
-        var requirement = requirements[idx];
+        const requirement = requirements[idx];
         return promise.then(checkFn).then(function (version) {
             requirement.installed = true;
             requirement.metadata.version = version;