From e4457f7fdb7eb854d166bb87b144bf4e1873cf61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=82=A8=E3=83=AA=E3=82=B9?= Date: Tue, 19 Aug 2025 13:55:18 +0900 Subject: [PATCH] chore!: update template defaults (#1837) * chore: update default package id * chore: sync cordova-app-hello-world defaults & modified for Android differences --- framework/cdv-gradle-config-defaults.json | 2 +- lib/create.js | 2 +- spec/unit/create.spec.js | 4 +- templates/cordova/defaults.xml | 35 ++++----- templates/project/res/xml/config.xml | 71 +++++++++---------- test/androidx/app/src/main/res/xml/config.xml | 2 +- 6 files changed, 57 insertions(+), 59 deletions(-) diff --git a/framework/cdv-gradle-config-defaults.json b/framework/cdv-gradle-config-defaults.json index f90f9a5f..36877074 100644 --- a/framework/cdv-gradle-config-defaults.json +++ b/framework/cdv-gradle-config-defaults.json @@ -12,7 +12,7 @@ "GRADLE_PLUGIN_GOOGLE_SERVICES_VERSION": "4.4.2", "IS_GRADLE_PLUGIN_GOOGLE_SERVICES_ENABLED": false, "IS_GRADLE_PLUGIN_KOTLIN_ENABLED": false, - "PACKAGE_NAMESPACE": "io.cordova.helloCordova", + "PACKAGE_NAMESPACE": "org.apache.cordova.hellocordova", "JAVA_SOURCE_COMPATIBILITY": 11, "JAVA_TARGET_COMPATIBILITY": 11, "KOTLIN_JVM_TARGET": null diff --git a/lib/create.js b/lib/create.js index 6ac56522..3c4c3d75 100755 --- a/lib/create.js +++ b/lib/create.js @@ -205,7 +205,7 @@ exports.create = function (project_path, config, options, events) { return Promise.reject(new CordovaError('Project already exists! Delete and recreate')); } - const package_name = config.android_packageName() || config.packageName() || 'io.cordova.helloCordova'; + const package_name = config.android_packageName() || config.packageName() || 'org.apache.cordova.hellocordova'; const project_name = config.name() || 'Hello Cordova'; const safe_activity_name = config.android_activityName() || options.activityName || 'MainActivity'; diff --git a/spec/unit/create.spec.js b/spec/unit/create.spec.js index 27652971..00bbf8a3 100644 --- a/spec/unit/create.spec.js +++ b/spec/unit/create.spec.js @@ -155,10 +155,10 @@ describe('create', function () { }); describe('parameter values and defaults', function () { - it('should have a default package name of io.cordova.helloCordova', () => { + it('should have a default package name of org.apache.cordova.hellocordova', () => { config_mock.packageName.and.returnValue(undefined); return create.create(project_path, config_mock, {}, events_mock).then(() => { - expect(create.validatePackageName).toHaveBeenCalledWith('io.cordova.helloCordova'); + expect(create.validatePackageName).toHaveBeenCalledWith('org.apache.cordova.hellocordova'); }); }); diff --git a/templates/cordova/defaults.xml b/templates/cordova/defaults.xml index 5286ab9c..2034102b 100644 --- a/templates/cordova/defaults.xml +++ b/templates/cordova/defaults.xml @@ -1,25 +1,26 @@ - + diff --git a/templates/project/res/xml/config.xml b/templates/project/res/xml/config.xml index 638709d3..da9a77fd 100644 --- a/templates/project/res/xml/config.xml +++ b/templates/project/res/xml/config.xml @@ -1,56 +1,53 @@ - + Hello Cordova - A sample Apache Cordova application that responds to the deviceready event. - - + Apache Cordova Team - + - - - + + + + + + + + + + - - - - - - diff --git a/test/androidx/app/src/main/res/xml/config.xml b/test/androidx/app/src/main/res/xml/config.xml index a824011e..15e8d0f3 100644 --- a/test/androidx/app/src/main/res/xml/config.xml +++ b/test/androidx/app/src/main/res/xml/config.xml @@ -17,7 +17,7 @@ specific language governing permissions and limitations under the License. --> - + Hello Cordova A sample Apache Cordova application that responds to the deviceready event.