From 57562a0dcfbb86275f084ee6871abcb4704467b5 Mon Sep 17 00:00:00 2001 From: Sefa Ilkimen Date: Mon, 17 Aug 2020 03:02:05 +0200 Subject: [PATCH] fix: #359 [Bug] [Android] memory leakage leads to app crashes --- CHANGELOG.md | 1 + src/android/com/silkimen/cordovahttp/CordovaHttpBase.java | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 834aa0e..302c464 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Feature #158: support removing headers which were previously set via "setHeader" - Fixed #345: empty file names are not handled correctly (thanks ikosta) +- Fixed #359: memory leakage leads to app crashes on Android - :warning: **Breaking Change**: Dropped support for Android < 5.1 - :warning: **Breaking Change**: Removed "disableRedirect", use "setFollowRedirect" instead diff --git a/src/android/com/silkimen/cordovahttp/CordovaHttpBase.java b/src/android/com/silkimen/cordovahttp/CordovaHttpBase.java index 03c7bc3..e56be1c 100644 --- a/src/android/com/silkimen/cordovahttp/CordovaHttpBase.java +++ b/src/android/com/silkimen/cordovahttp/CordovaHttpBase.java @@ -79,6 +79,7 @@ abstract class CordovaHttpBase implements Runnable { this.prepareRequest(request); this.sendBody(request); this.processResponse(request, response); + request.disconnect(); } catch (HttpRequestException e) { if (e.getCause() instanceof SSLException) { response.setStatus(-2);