From da7e85ec92a200ffb60cdb25827d58dce3bef8f2 Mon Sep 17 00:00:00 2001 From: Rob Close Date: Mon, 6 Jun 2016 15:13:13 -0400 Subject: [PATCH] CB-11384 android: Does not pass sonarqube scan The problem is "Empty Catch Block", which sonarqube considers a blocker. Added a log message to the empty block. --- src/android/NetworkManager.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/android/NetworkManager.java b/src/android/NetworkManager.java index 59965bd..29066fa 100755 --- a/src/android/NetworkManager.java +++ b/src/android/NetworkManager.java @@ -127,7 +127,9 @@ public class NetworkManager extends CordovaPlugin { String connectionType = ""; try { connectionType = this.getConnectionInfo(info).get("type").toString(); - } catch (JSONException e) { } + } catch (JSONException e) { + Log.d(LOG_TAG, e.getLocalizedMessage()); + } PluginResult pluginResult = new PluginResult(PluginResult.Status.OK, connectionType); pluginResult.setKeepCallback(true); @@ -171,7 +173,9 @@ public class NetworkManager extends CordovaPlugin { String connectionType = ""; try { connectionType = thisInfo.get("type").toString(); - } catch (JSONException e) { } + } catch (JSONException e) { + Log.d(LOG_TAG, e.getLocalizedMessage()); + } sendUpdate(connectionType); lastInfo = thisInfo; @@ -206,7 +210,9 @@ public class NetworkManager extends CordovaPlugin { try { connectionInfo.put("type", type); connectionInfo.put("extraInfo", extraInfo); - } catch (JSONException e) { } + } catch (JSONException e) { + Log.d(LOG_TAG, e.getLocalizedMessage()); + } return connectionInfo; }