Commit Graph

492 Commits

Author SHA1 Message Date
Kubernetes Publisher 8d405dd3e1 Merge pull request #62273 from atlassian/dont-log-when-error-returned
Automatic merge from submit-queue (batch tested with PRs 62273, 62461). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Don't log when error returned

**What this PR does / why we need it**:
Both logging and returning an error is an antipattern. If the caller wants it logged they will log it. And in this case it will be logged twice which is very confusing for debugging.

**Release note**:
```release-note
NONE
```
/kind cleanup
/sig api-machinery

Kubernetes-commit: 0b5fa0b94a2e147ddae2278623c89648c211d229
2018-04-12 15:18:59 +00:00
Kubernetes Publisher b05f3be049 sync: update required packages 2018-04-09 03:54:08 +00:00
Kubernetes Publisher b099eae8cd sync: update godeps 2018-04-09 03:54:08 +00:00
Kubernetes Publisher 8c90968420 sync: update required packages 2018-04-08 23:54:30 +00:00
Kubernetes Publisher 60c19c2a53 sync: update godeps 2018-04-08 23:54:30 +00:00
Kubernetes Publisher dcdc54df98 sync: update required packages 2018-04-08 19:54:39 +00:00
Kubernetes Publisher 8e0f7d4874 sync: update godeps 2018-04-08 19:54:38 +00:00
Kubernetes Publisher a679ea1828 sync: update required packages 2018-04-08 15:53:28 +00:00
Kubernetes Publisher 0e1a760a91 sync: update godeps 2018-04-08 15:53:28 +00:00
Kubernetes Publisher 7431c5f474 sync: update required packages 2018-04-08 11:55:38 +00:00
Kubernetes Publisher f3a6811dd3 sync: update godeps 2018-04-08 11:55:38 +00:00
Kubernetes Publisher 709fd539aa sync: update required packages 2018-04-08 07:54:54 +00:00
Kubernetes Publisher ea01e096fa sync: update godeps 2018-04-08 07:54:54 +00:00
Kubernetes Publisher fef47a8a8e sync: update required packages 2018-04-08 03:53:23 +00:00
Kubernetes Publisher 19f6cf7aa7 sync: update godeps 2018-04-08 03:53:22 +00:00
Kubernetes Publisher 8865a08dc7 sync: update required packages 2018-04-07 23:53:27 +00:00
Kubernetes Publisher 739cecdc1b sync: update godeps 2018-04-07 23:53:27 +00:00
Kubernetes Publisher 95cbedd0a1 sync: update required packages 2018-04-07 19:53:50 +00:00
Kubernetes Publisher db1ea8ef50 sync: update godeps 2018-04-07 19:53:50 +00:00
Kubernetes Publisher 435b20016f sync: update required packages 2018-04-07 15:53:49 +00:00
Kubernetes Publisher c693b1e50e sync: update godeps 2018-04-07 15:53:49 +00:00
Kubernetes Publisher de4ea5262a sync: update required packages 2018-04-07 11:53:49 +00:00
Kubernetes Publisher 5cf44091e8 sync: update godeps 2018-04-07 11:53:49 +00:00
Kubernetes Publisher 7d983be3ec sync: update required packages 2018-04-07 07:55:05 +00:00
Kubernetes Publisher 9a9f0c5cb9 sync: update godeps 2018-04-07 07:55:05 +00:00
Kubernetes Publisher c8fa32cd19 sync: update required packages 2018-04-07 03:54:30 +00:00
Kubernetes Publisher ec0e6ae009 sync: update godeps 2018-04-07 03:54:30 +00:00
Kubernetes Publisher e0a1db6d08 sync: update required packages 2018-04-06 23:53:40 +00:00
Kubernetes Publisher 2699b2b3b2 sync: update godeps 2018-04-06 23:53:40 +00:00
Kubernetes Publisher 4a57a6f070 sync: update required packages 2018-04-06 19:52:32 +00:00
Kubernetes Publisher 28bc2cefcd sync: update godeps 2018-04-06 19:52:32 +00:00
Kubernetes Publisher 0edc443454 sync: update required packages 2018-04-06 15:55:16 +00:00
Kubernetes Publisher 86e7dab20d sync: update godeps 2018-04-06 15:55:16 +00:00
Kubernetes Publisher 3709cee765 sync: update required packages 2018-04-06 12:05:26 +00:00
Kubernetes Publisher d74f225f28 sync: update godeps 2018-04-06 12:05:26 +00:00
Kubernetes Publisher 96b07c14ac Merge pull request #61800 from rithujohn191/remove-gopass
Automatic merge from submit-queue (batch tested with PRs 61818, 61800). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Replace gopass.GetPasswdMasked() by terminal.ReadPassword()

**What this PR does / why we need it**:
Replace `gopass.GetPasswdMasked()` used for reading passwords from the terminal with [`terminal.ReadPassword()`](https://godoc.org/golang.org/x/crypto/ssh/terminal#ReadPassword). This removes the `gopass` import.

**Special notes for your reviewer**:
Ran the following commands to update `godep` files:
```
./hack/godep-restore.sh -v
./hack/godep-save.sh
./hack/update-staging-godeps.sh
./hack/update-bazel.sh
```

/sig auth
/kind enhancement
/assign @ericchiang

```release-note
NONE
```

Kubernetes-commit: a5133305a9f347c79c20c5785d41cc9400be895e
2018-04-06 12:04:33 +00:00
Kubernetes Publisher fac24b192a sync: update required packages 2018-03-30 19:46:44 +00:00
Kubernetes Publisher 316b82400f sync: update godeps 2018-03-30 19:46:43 +00:00
Kubernetes Publisher 7220d7f7a8 sync: update required packages 2018-03-30 16:00:27 +00:00
Kubernetes Publisher 4d73244bb2 sync: update godeps 2018-03-30 16:00:27 +00:00
Kubernetes Publisher 9e4d8510b3 sync: update required packages 2018-03-30 11:59:27 +00:00
Kubernetes Publisher d9fcada825 sync: update godeps 2018-03-30 11:59:27 +00:00
Kubernetes Publisher b569e8beb9 sync: update required packages 2018-03-30 07:58:33 +00:00
Kubernetes Publisher 78509bf814 sync: update godeps 2018-03-30 07:58:33 +00:00
Kubernetes Publisher 1dd644af46 sync: update required packages 2018-03-30 03:58:14 +00:00
Kubernetes Publisher 45f171cd1c sync: update godeps 2018-03-30 03:58:13 +00:00
Kubernetes Publisher 5ab6bc937a sync: update required packages 2018-03-30 00:00:05 +00:00
Kubernetes Publisher 7691be75b7 sync: update godeps 2018-03-30 00:00:04 +00:00
Kubernetes Publisher 75fe64a25a sync: update required packages 2018-03-29 19:48:56 +00:00
Kubernetes Publisher 48a8b2db1f sync: update godeps 2018-03-29 19:48:55 +00:00