github/simple-keyboard
4
0
Fork 0
mirror of https://github.com/hodgef/simple-keyboard.git synced 2026-04-30 00:00:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove caret reset on inputName change

Browse Source
This commit is contained in:
Francisco Hodge
2021-04-12 22:29:20 -04:00
parent 9fe80c0897
commit f9a0d00367
2 changed files with 0 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/lib/components/Keyboard.ts
-13
View File
@@ -762,19 +762,6 @@ class SimpleKeyboard {
* @param {object} options The options to set
*/
onSetOptions(changedOptions: string[] = []): void {
/**
* Changed: inputName
*/
if (changedOptions.includes("inputName")) {
/**
* inputName changed. This requires a caretPosition reset
*/
if (this.options.debug) {
console.log("inputName changed. caretPosition reset.");
}
this.setCaretPosition(null);
}
/**
* Changed: layoutName
*/
src/lib/components/tests/Keyboard.test.js
-21
View File
@@ -1138,27 +1138,6 @@ it('Keyboard disableRowButtonContainers will bypass parseRowDOMContainers', () =
expect(containers.length).toBe(0);
});
it('Keyboard inputName change will trigget caretPosition reset', () => {
const keyboard = new Keyboard();
keyboard.setCaretPosition(0);
keyboard.getButtonElement("q").onpointerdown();
keyboard.getButtonElement("1").onpointerdown();
expect(keyboard.getCaretPosition()).toBe(2);
keyboard.setOptions({
inputName: "myInput"
});
keyboard.getButtonElement("q").onpointerdown();
keyboard.getButtonElement("1").onpointerdown();
keyboard.getButtonElement("b").onpointerdown();
expect(keyboard.getCaretPosition()).toBe(null);
});
it('Keyboard destroy will work', () => {
const keyboard = new Keyboard();
keyboard.destroy();