From 72f428e87b5395c03d2f94ef6185fc247ddbc8dc Mon Sep 17 00:00:00 2001 From: fit2cloud-chenyw Date: Mon, 29 May 2023 10:01:43 +0800 Subject: [PATCH] =?UTF-8?q?feat(=E4=BB=AA=E8=A1=A8=E6=9D=BF):=20=E5=88=A0?= =?UTF-8?q?=E9=99=A4=E5=88=86=E4=BA=ABIDOR=E6=BC=8F=E6=B4=9E?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../java/io/dataease/service/panel/ShareService.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/backend/src/main/java/io/dataease/service/panel/ShareService.java b/backend/src/main/java/io/dataease/service/panel/ShareService.java index 143959f23d..f11ba695a0 100644 --- a/backend/src/main/java/io/dataease/service/panel/ShareService.java +++ b/backend/src/main/java/io/dataease/service/panel/ShareService.java @@ -4,12 +4,11 @@ import com.google.gson.Gson; import io.dataease.auth.api.dto.CurrentRoleDto; import io.dataease.auth.api.dto.CurrentUserDto; import io.dataease.commons.constants.SysLogConstants; -import io.dataease.commons.utils.DeLogUtils; -import io.dataease.ext.ExtPanelShareMapper; import io.dataease.commons.model.AuthURD; import io.dataease.commons.utils.AuthUtils; import io.dataease.commons.utils.BeanUtils; import io.dataease.commons.utils.CommonBeanFactory; +import io.dataease.commons.utils.DeLogUtils; import io.dataease.controller.request.panel.PanelShareFineDto; import io.dataease.controller.request.panel.PanelShareRemoveRequest; import io.dataease.controller.request.panel.PanelShareRequest; @@ -18,6 +17,7 @@ import io.dataease.controller.sys.base.BaseGridRequest; import io.dataease.dto.panel.PanelShareDto; import io.dataease.dto.panel.PanelShareOutDTO; import io.dataease.dto.panel.PanelSharePo; +import io.dataease.ext.ExtPanelShareMapper; import io.dataease.plugins.common.base.domain.PanelGroup; import io.dataease.plugins.common.base.domain.PanelShare; import io.dataease.plugins.common.base.domain.PanelShareExample; @@ -390,8 +390,11 @@ public class ShareService { PanelShareRemoveRequest request = new PanelShareRemoveRequest(); request.setPanelId(panelId); List panelShareOutDTOS = queryTargets(panelId); + if (CollectionUtils.isEmpty(panelShareOutDTOS) || ObjectUtils.isEmpty(panelGroup)) { + return; + } extPanelShareMapper.removeShares(request); - if (CollectionUtils.isEmpty(panelShareOutDTOS) || ObjectUtils.isEmpty(panelGroup) || StringUtils.isBlank(panelGroup.getName())) { + if (StringUtils.isBlank(panelGroup.getName())) { return; } panelShareOutDTOS.forEach(shareOut -> {