From 4b25c4ed31ace78a91034775765608a7ea1d3192 Mon Sep 17 00:00:00 2001
From: wangjiahao <1522128093@qq.com>
Date: Fri, 11 Oct 2024 16:22:16 +0800
Subject: [PATCH] =?UTF-8?q?refactor(=E6=95=B0=E6=8D=AE=E5=A4=A7=E5=B1=8F?=
 =?UTF-8?q?=E3=80=81=E4=BB=AA=E8=A1=A8=E6=9D=BF):=20=E5=9B=BE=E7=89=87?=
 =?UTF-8?q?=E7=BB=84=E6=98=BE=E7=A4=BA=E4=BC=98=E5=8C=96?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../picture-group/Component.vue               | 10 +++---
 .../PictureGroupDatasetSelect.vue             | 34 ++++++++++---------
 .../views/chart/components/views/index.vue    | 21 ++++--------
 3 files changed, 29 insertions(+), 36 deletions(-)

diff --git a/core/core-frontend/src/custom-component/picture-group/Component.vue b/core/core-frontend/src/custom-component/picture-group/Component.vue
index 9668c91c9c..81ad517b91 100644
--- a/core/core-frontend/src/custom-component/picture-group/Component.vue
+++ b/core/core-frontend/src/custom-component/picture-group/Component.vue
@@ -185,16 +185,16 @@ const withInit = () => {
   initCarousel()
 }
 
-const calcData = (view: Chart, callback) => {
+const calcData = (viewCalc: Chart, callback) => {
   isError.value = false
-  const { threshold } = parseJson(view.senior)
+  const { threshold } = parseJson(viewCalc.senior)
   if (!threshold.enable) {
     withInit()
     callback?.()
     return
   }
-  if (view.tableId || view['dataFrom'] === 'template') {
-    const v = JSON.parse(JSON.stringify(view))
+  if (viewCalc.tableId || viewCalc['dataFrom'] === 'template') {
+    const v = JSON.parse(JSON.stringify(viewCalc))
     getData(v)
       .then(res => {
         if (res.code && res.code !== 0) {
@@ -223,7 +223,7 @@ const calcData = (view: Chart, callback) => {
         })
         callback?.()
       })
-  } else if (!view.tableId) {
+  } else if (!viewCalc.tableId) {
     initReady.value = true
     withInit()
     callback?.()
diff --git a/core/core-frontend/src/custom-component/picture-group/PictureGroupDatasetSelect.vue b/core/core-frontend/src/custom-component/picture-group/PictureGroupDatasetSelect.vue
index 3c3e5fb7a7..415041b4a4 100644
--- a/core/core-frontend/src/custom-component/picture-group/PictureGroupDatasetSelect.vue
+++ b/core/core-frontend/src/custom-component/picture-group/PictureGroupDatasetSelect.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { PropType, reactive, toRefs } from 'vue'
+import { nextTick, PropType, reactive, toRefs } from 'vue'
 import { BASE_VIEW_CONFIG } from '@/views/chart/components/editor/util/chart'
 import DatasetSelect from '@/views/chart/components/editor/dataset-select/DatasetSelect.vue'
 import { snapshotStoreWithOut } from '@/store/modules/data-visualization/snapshot'
@@ -24,21 +24,23 @@ const { view } = toRefs(props)
 const state = reactive({})
 
 const onDatasetUpdate = () => {
-  if (view.value.tableId && view.value.id) {
-    getFieldByDQ(view.value.tableId, view.value.id, { type: 'table-info' })
-      .then(res => {
-        view.value.xAxis = []
-        view.value.xAxis.push(...res.dimensionList, ...res.quotaList)
-        const viewTarget = view.value
-        useEmitt().emitter.emit('calcData-' + viewTarget.id, viewTarget)
-        snapshotStore.recordSnapshotCache('calc', view.value.id)
-      })
-      .catch(() => {
-        // something do error
-      })
-  } else {
-    view.value.xAxis = []
-  }
+  nextTick(() => {
+    if (view.value.tableId && view.value.id) {
+      getFieldByDQ(view.value.tableId, view.value.id, { type: 'table-info' })
+        .then(res => {
+          view.value.xAxis = []
+          view.value.xAxis.push(...res.dimensionList, ...res.quotaList.pop())
+          const viewTarget = view.value
+          useEmitt().emitter.emit('calcData-' + viewTarget.id, viewTarget)
+          snapshotStore.recordSnapshotCache('calc', view.value.id)
+        })
+        .catch(() => {
+          // something do error
+        })
+    } else {
+      view.value.xAxis = []
+    }
+  })
 }
 </script>
 
diff --git a/core/core-frontend/src/views/chart/components/views/index.vue b/core/core-frontend/src/views/chart/components/views/index.vue
index bd4eaa7404..2c1e193be0 100644
--- a/core/core-frontend/src/views/chart/components/views/index.vue
+++ b/core/core-frontend/src/views/chart/components/views/index.vue
@@ -678,19 +678,6 @@ onMounted(() => {
       })
     }
   })
-  useEmitt({
-    name: 'calcData-' + view.value.id,
-    callback: function (val) {
-      if (!state.initReady) {
-        return
-      }
-      initTitle()
-      nextTick(() => {
-        view.value.chartExtRequest = filter(false)
-        calcData(val)
-      })
-    }
-  })
 
   useEmitt({
     name: 'calcData-' + view.value.id,
@@ -913,6 +900,10 @@ const loadPluginCategory = data => {
     }
   })
 }
+
+const allEmptyCheck = computed(() => {
+  return ['rich-text', 'picture-group'].includes(element.value.innerType)
+})
 </script>
 
 <template>
@@ -983,7 +974,7 @@ const loadPluginCategory = data => {
       </transition>
     </div>
     <!--这里去渲染不同图库的图表-->
-    <div v-if="chartAreaShow && !showEmpty" style="flex: 1; overflow: hidden">
+    <div v-if="allEmptyCheck || (chartAreaShow && !showEmpty)" style="flex: 1; overflow: hidden">
       <plugin-component
         v-if="view.plugin?.isPlugin"
         :jsname="view.plugin.staticMap['index']"
@@ -1061,7 +1052,7 @@ const loadPluginCategory = data => {
       />
     </div>
     <chart-empty-info
-      v-if="!chartAreaShow || showEmpty"
+      v-if="(!chartAreaShow || showEmpty) && !allEmptyCheck"
       :themes="canvasStyleData.dashboard.themeColor"
       :view-icon="view.type"
     ></chart-empty-info>