From 25a1badbd0dbbdaeb6929264b86a49ad64e15b63 Mon Sep 17 00:00:00 2001
From: fit2cloud-chenyw <yawen.chen@fit2cloud.com>
Date: Tue, 1 Mar 2022 15:09:47 +0800
Subject: [PATCH 1/2] =?UTF-8?q?refactor:=20=E7=94=A8=E6=88=B7=E5=88=97?=
 =?UTF-8?q?=E8=A1=A8=E4=B8=8E=E4=BB=AA=E8=A1=A8=E6=9D=BF=E5=88=86=E4=BA=AB?=
 =?UTF-8?q?=E7=94=A8=E6=88=B7=E6=8E=A5=E5=8F=A3=E5=88=86=E7=A6=BB?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../controller/sys/SysUserController.java     | 52 +++++++++----------
 frontend/src/api/system/user.js               | 10 ++++
 .../src/views/panel/GrantAuth/user/index.vue  |  8 +--
 3 files changed, 40 insertions(+), 30 deletions(-)

diff --git a/backend/src/main/java/io/dataease/controller/sys/SysUserController.java b/backend/src/main/java/io/dataease/controller/sys/SysUserController.java
index 933f720550..4c268c538b 100644
--- a/backend/src/main/java/io/dataease/controller/sys/SysUserController.java
+++ b/backend/src/main/java/io/dataease/controller/sys/SysUserController.java
@@ -1,6 +1,5 @@
 package io.dataease.controller.sys;
 
-
 import com.github.pagehelper.Page;
 import com.github.pagehelper.PageHelper;
 import com.github.xiaoymin.knife4j.annotations.ApiSupport;
@@ -49,27 +48,33 @@ public class SysUserController {
     @RequiresPermissions("user:read")
     @PostMapping("/userGrid/{goPage}/{pageSize}")
     @ApiImplicitParams({
-        @ApiImplicitParam(paramType="path", name = "goPage", value = "页码", required = true, dataType = "Integer"),
-        @ApiImplicitParam(paramType="path", name = "pageSize", value = "页容量", required = true, dataType = "Integer"),
-        @ApiImplicitParam(name = "request", value = "查询条件", required = true)
+            @ApiImplicitParam(paramType = "path", name = "goPage", value = "页码", required = true, dataType = "Integer"),
+            @ApiImplicitParam(paramType = "path", name = "pageSize", value = "页容量", required = true, dataType = "Integer"),
+            @ApiImplicitParam(name = "request", value = "查询条件", required = true)
     })
-    public Pager<List<SysUserGridResponse>> userGrid(@PathVariable int goPage, @PathVariable int pageSize, @RequestBody BaseGridRequest request) {
+    public Pager<List<SysUserGridResponse>> userGrid(@PathVariable int goPage, @PathVariable int pageSize,
+            @RequestBody BaseGridRequest request) {
         Page<Object> page = PageHelper.startPage(goPage, pageSize, true);
         return PageUtils.setPageInfo(page, sysUserService.query(request));
     }
 
+    @ApiIgnore
+    @PostMapping("/userLists")
+    public List<SysUserGridResponse> userLists(@RequestBody BaseGridRequest request) {
+        return sysUserService.query(request);
+    }
 
     @ApiOperation("创建用户")
     @RequiresPermissions("user:add")
     @PostMapping("/create")
-    public void create(@RequestBody SysUserCreateRequest request){
+    public void create(@RequestBody SysUserCreateRequest request) {
         sysUserService.save(request);
     }
 
     @ApiOperation("更新用户")
     @RequiresPermissions("user:edit")
     @PostMapping("/update")
-    public void update(@RequestBody SysUserCreateRequest request){
+    public void update(@RequestBody SysUserCreateRequest request) {
         sysUserService.update(request);
     }
 
@@ -77,33 +82,32 @@ public class SysUserController {
     @RequiresPermissions("user:del")
     @PostMapping("/delete/{userId}")
     @ApiImplicitParam(paramType = "path", value = "用户ID", name = "userId", required = true, dataType = "Integer")
-    public void delete(@PathVariable("userId") Long userId){
+    public void delete(@PathVariable("userId") Long userId) {
         sysUserService.delete(userId);
     }
 
-
     @ApiOperation("更新用户状态")
     @RequiresPermissions("user:edit")
     @RequiresRoles("1")
     @PostMapping("/updateStatus")
-    public void updateStatus(@RequestBody SysUserStateRequest request){
+    public void updateStatus(@RequestBody SysUserStateRequest request) {
         sysUserService.updateStatus(request);
     }
 
     @ApiOperation("更新当前用户密码")
     @PostMapping("/updatePwd")
-    public void updatePwd(@RequestBody SysUserPwdRequest request){
+    public void updatePwd(@RequestBody SysUserPwdRequest request) {
 
         sysUserService.updatePwd(request);
     }
+
     @ApiOperation("更新指定用户密码")
     @RequiresPermissions("user:editPwd")
     @PostMapping("/adminUpdatePwd")
-    public void adminUpdatePwd(@RequestBody SysUserPwdRequest request){
+    public void adminUpdatePwd(@RequestBody SysUserPwdRequest request) {
         sysUserService.adminUpdatePwd(request);
     }
 
-
     @ApiOperation("当前用户信息")
     @PostMapping("/personInfo")
     public CurrentUserDto personInfo() {
@@ -114,13 +118,13 @@ public class SysUserController {
     @ApiIgnore
     @ApiOperation("更新个人信息")
     @PostMapping("/updatePersonInfo")
-    public void updatePersonInfo(@RequestBody SysUserCreateRequest request){
+    public void updatePersonInfo(@RequestBody SysUserCreateRequest request) {
         sysUserService.updatePersonInfo(request);
     }
 
     @ApiOperation("设置语言")
     @PostMapping("/setLanguage/{language}")
-    @ApiImplicitParam(paramType="path", name = "language", value = "语言(zh_CN, zh_TW, en_US)", required = true, dataType = "String")
+    @ApiImplicitParam(paramType = "path", name = "language", value = "语言(zh_CN, zh_TW, en_US)", required = true, dataType = "String")
     public void setLanguage(@PathVariable String language) {
         CurrentUserDto user = AuthUtils.getUser();
         Optional.ofNullable(language).ifPresent(currentLanguage -> {
@@ -132,28 +136,24 @@ public class SysUserController {
 
     @ApiOperation("查询所有角色")
     @PostMapping("/all")
-    public List<RoleUserItem> all(){
+    public List<RoleUserItem> all() {
         return sysRoleService.allRoles();
     }
 
-
-
-    @ApiOperation("查询角色")
+    @ApiIgnore("查询角色")
     @PostMapping("/roleGrid/{goPage}/{pageSize}")
     @ApiImplicitParams({
-        @ApiImplicitParam(paramType="path", name = "goPage", value = "页码", required = true, dataType = "Integer"),
-        @ApiImplicitParam(paramType="path", name = "pageSize", value = "页容量", required = true, dataType = "Integer"),
-        @ApiImplicitParam(name = "request", value = "查询条件", required = true)
+            @ApiImplicitParam(paramType = "path", name = "goPage", value = "页码", required = true, dataType = "Integer"),
+            @ApiImplicitParam(paramType = "path", name = "pageSize", value = "页容量", required = true, dataType = "Integer"),
+            @ApiImplicitParam(name = "request", value = "查询条件", required = true)
     })
-    public Pager<List<SysRole>> roleGrid(@PathVariable int goPage, @PathVariable int pageSize, @RequestBody BaseGridRequest request) {
+    public Pager<List<SysRole>> roleGrid(@PathVariable int goPage, @PathVariable int pageSize,
+            @RequestBody BaseGridRequest request) {
         Page<Object> page = PageHelper.startPage(goPage, pageSize, true);
         Pager<List<SysRole>> listPager = PageUtils.setPageInfo(page, sysRoleService.query(request));
         return listPager;
     }
 
-
-
-
     @ApiOperation("已同步用户")
     @PostMapping("/existLdapUsers")
     public List<ExistLdapUser> getExistLdapUsers() {
diff --git a/frontend/src/api/system/user.js b/frontend/src/api/system/user.js
index 64d7d65f05..63cacd59ad 100644
--- a/frontend/src/api/system/user.js
+++ b/frontend/src/api/system/user.js
@@ -4,6 +4,7 @@ const pathMap = {
   personInfoPath: '/api/user/personInfo/',
   piupdatePath: '/api/user/updatePersonInfo/',
   queryPath: '/api/user/userGrid/',
+  queryWithOutPagePath: '/api/user/userLists',
   deletePath: '/api/user/delete/',
   createPath: '/api/user/create',
   updatePath: '/api/user/update',
@@ -19,6 +20,15 @@ export function userLists(page, size, data) {
   })
 }
 
+export function userListsWithOutPage(data) {
+  return request({
+    url: pathMap.queryWithOutPagePath,
+    method: 'post',
+    data,
+    loading: true
+  })
+}
+
 export const addUser = (data) => {
   return request({
     url: pathMap.createPath,
diff --git a/frontend/src/views/panel/GrantAuth/user/index.vue b/frontend/src/views/panel/GrantAuth/user/index.vue
index 452ea0437d..6dc1d2c6a0 100644
--- a/frontend/src/views/panel/GrantAuth/user/index.vue
+++ b/frontend/src/views/panel/GrantAuth/user/index.vue
@@ -24,7 +24,7 @@
 </template>
 
 <script>
-import { userLists } from '@/api/system/user'
+import { userListsWithOutPage } from '@/api/system/user'
 import { formatCondition } from '@/utils/index'
 import { loadShares } from '@/api/panel/share'
 /* import { saveShare, loadShares } from '@/api/panel/share' */
@@ -69,10 +69,10 @@ export default {
     search(condition) {
       const temp = formatCondition(condition)
       const param = temp || {}
-      userLists(1, 0, param).then(response => {
+      userListsWithOutPage(param).then(response => {
         const data = response.data
-        this.data = data.listObject.filter(ele => ele.id !== this.$store.getters.user.userId)
-        this.tableData = data.listObject.filter(ele => ele.id !== this.$store.getters.user.userId)
+        this.data = data.filter(ele => ele.id !== this.$store.getters.user.userId)
+        this.tableData = data.filter(ele => ele.id !== this.$store.getters.user.userId)
         this.queryShareNodeIds()
       })
     },

From 3777c1c6a33e401a203af5918d8b50921730397e Mon Sep 17 00:00:00 2001
From: taojinlong <jinlong@fit2cloud.com>
Date: Tue, 1 Mar 2022 16:05:31 +0800
Subject: [PATCH 2/2] =?UTF-8?q?feat:=20=E4=BB=AA=E8=A1=A8=E6=9D=BF?=
 =?UTF-8?q?=E5=88=86=E4=BA=AB=E4=BB=A5=E5=88=86=E4=BA=AB=E4=BA=BA=E6=9F=A5?=
 =?UTF-8?q?=E7=9C=8B=E6=95=B0=E6=8D=AE?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../service/chart/ChartViewService.java       |  2 +-
 .../service/dataset/DataSetTableService.java  |  3 +-
 .../service/dataset/PermissionService.java    | 59 ++++---------------
 3 files changed, 14 insertions(+), 50 deletions(-)

diff --git a/backend/src/main/java/io/dataease/service/chart/ChartViewService.java b/backend/src/main/java/io/dataease/service/chart/ChartViewService.java
index 354758577e..628b1fe9e9 100644
--- a/backend/src/main/java/io/dataease/service/chart/ChartViewService.java
+++ b/backend/src/main/java/io/dataease/service/chart/ChartViewService.java
@@ -1705,7 +1705,7 @@ public class ChartViewService {
             throw new RuntimeException(Translator.get("i18n_dataset_delete"));
         }
         SysUserEntity user = AuthUtils.getUser();
-        user = user != null ? user : authUserService.getUserById(userId);
+        user = userId != null ? authUserService.getUserById(userId) : user;
         if (!user.getIsAdmin()) {
             if (ObjectUtils.isEmpty(table.getPrivileges()) || !table.getPrivileges().contains(needPermission)) {
                 throw new RuntimeException(Translator.get("i18n_dataset_no_permission"));
diff --git a/backend/src/main/java/io/dataease/service/dataset/DataSetTableService.java b/backend/src/main/java/io/dataease/service/dataset/DataSetTableService.java
index 2bb39fd550..c8b81bb235 100644
--- a/backend/src/main/java/io/dataease/service/dataset/DataSetTableService.java
+++ b/backend/src/main/java/io/dataease/service/dataset/DataSetTableService.java
@@ -405,8 +405,7 @@ public class DataSetTableService {
 
     public DataSetTableDTO getWithPermission(String id, Long user) {
         CurrentUserDto currentUserDto = AuthUtils.getUser();
-        Long userId = currentUserDto != null ? currentUserDto.getUserId() : user;
-
+        Long userId = user != null ? user : currentUserDto.getUserId();
         DataSetTableRequest dataSetTableRequest = new DataSetTableRequest();
         dataSetTableRequest.setId(id);
         dataSetTableRequest.setUserId(String.valueOf(userId));
diff --git a/backend/src/main/java/io/dataease/service/dataset/PermissionService.java b/backend/src/main/java/io/dataease/service/dataset/PermissionService.java
index 64ebb1ae6e..288df72ee5 100644
--- a/backend/src/main/java/io/dataease/service/dataset/PermissionService.java
+++ b/backend/src/main/java/io/dataease/service/dataset/PermissionService.java
@@ -94,37 +94,19 @@ public class PermissionService {
             return new ArrayList<>();
         }
         RowPermissionService rowPermissionService = SpringContextUtil.getBean(RowPermissionService.class);
-        CurrentUserDto user = AuthUtils.getUser();
+        SysUserEntity userEntity = userId != null ? authUserService.getUserById(userId) : AuthUtils.getUser();
         List<Long> roleIds = new ArrayList<>();
         Long deptId = null;
 
-        if (user == null && userId == null) {
+        if (userEntity == null ) {
             return datasetRowPermissions;
         }
-
-        if (user != null && userId != null) {
+        if (userEntity.getIsAdmin()) {
             return datasetRowPermissions;
         }
-
-        if (user != null) {
-            if (user.getIsAdmin()) {
-                return datasetRowPermissions;
-            }
-            userId = user.getUserId();
-            deptId = user.getDeptId();
-            roleIds = user.getRoles().stream().map(CurrentRoleDto::getId).collect(Collectors.toList());
-        }
-
-        if (userId != null) {
-            SysUserEntity userEntity = authUserService.getUserById(userId);
-            if (userEntity.getIsAdmin()) {
-                return datasetRowPermissions;
-            }
-            deptId = userEntity.getDeptId();
-            roleIds = authUserService.roles(userId).stream().map(r -> Long.valueOf(r)).collect(Collectors.toList());
-        }
-
-
+        userId = userEntity.getUserId();
+        deptId = userEntity.getDeptId();
+        roleIds = authUserService.roles(userId).stream().map(r -> Long.valueOf(r)).collect(Collectors.toList());
         DataSetRowPermissionsDTO dataSetRowPermissionsDTO = new DataSetRowPermissionsDTO();
         dataSetRowPermissionsDTO.setDatasetId(datasetId);
         dataSetRowPermissionsDTO.setAuthTargetIds(Collections.singletonList(userId));
@@ -146,36 +128,19 @@ public class PermissionService {
             return new ArrayList<>();
         }
         ColumnPermissionService columnPermissionService = SpringContextUtil.getBean(ColumnPermissionService.class);
-        CurrentUserDto user = AuthUtils.getUser();
+        SysUserEntity userEntity = userId != null ? authUserService.getUserById(userId) : AuthUtils.getUser();
         List<Long> roleIds = new ArrayList<>();
         Long deptId = null;
 
-        if (user == null && userId == null) {
+        if (userEntity == null ) {
             return datasetColumnPermissions;
         }
-
-        if (user != null && userId != null) {
+        if (userEntity.getIsAdmin()) {
             return datasetColumnPermissions;
         }
-
-        if (user != null) {
-            if (user.getIsAdmin()) {
-                return datasetColumnPermissions;
-            }
-            userId = user.getUserId();
-            deptId = user.getDeptId();
-            roleIds = user.getRoles().stream().map(CurrentRoleDto::getId).collect(Collectors.toList());
-        }
-
-        if (userId != null) {
-            SysUserEntity userEntity = authUserService.getUserById(userId);
-            if (userEntity.getIsAdmin()) {
-                return datasetColumnPermissions;
-            }
-            deptId = userEntity.getDeptId();
-            roleIds = authUserService.roles(userId).stream().map(r -> Long.valueOf(r)).collect(Collectors.toList());
-        }
-
+        userId = userEntity.getUserId();
+        deptId = userEntity.getDeptId();
+        roleIds = authUserService.roles(userId).stream().map(r -> Long.valueOf(r)).collect(Collectors.toList());
         DataSetColumnPermissionsDTO dataSetColumnPermissionsDTO = new DataSetColumnPermissionsDTO();
         dataSetColumnPermissionsDTO.setDatasetId(datasetId);
         dataSetColumnPermissionsDTO.setAuthTargetIds(Collections.singletonList(userId));