github/apache-cordova-plugin-inappbrowser
github/apache-cordova-plugin-inappbrowser
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

doc: do not use with in JS samples

Browse Source 
The usage of `with` JS statement is highly discouraged for a number of reasons, see

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with
http://www.2ality.com/2011/06/with-statement.html
This commit is contained in:
jakub-g 2016-05-18 15:55:27 +02:00
parent 066ba4c286
commit f42226dddb
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
README.md
View File

@ -235,14 +235,11 @@ function showHelp(url) {
inAppBrowserRef = cordova.InAppBrowser.open(url, target, options);
with (inAppBrowserRef) {
inAppBrowserRef.addEventListener('loadstart', loadStartCallBack);
addEventListener('loadstart', loadStartCallBack);
inAppBrowserRef.addEventListener('loadstop', loadStopCallBack);
addEventListener('loadstop', loadStopCallBack);
addEventListener('loaderror', loadErrorCallBack);
}
inAppBrowserRef.addEventListener('loaderror', loadErrorCallBack);
}
@ -544,14 +541,11 @@ function showHelp(url) {
inAppBrowserRef = cordova.InAppBrowser.open(url, target, options);
with (inAppBrowserRef) {
inAppBrowserRef.addEventListener('loadstart', loadStartCallBack);
addEventListener('loadstart', loadStartCallBack);
inAppBrowserRef.addEventListener('loadstop', loadStopCallBack);
addEventListener('loadstop', loadStopCallBack);
addEventListener('loaderror', loadErrorCallBack);
}
inAppBrowserRef.addEventListener('loaderror', loadErrorCallBack);
}