github/asdf-nodejs
github/asdf-nodejs
3
0
Fork 0
mirror of https://github.com/asdf-vm/asdf-nodejs.git synced 2024-10-05 15:25:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't set NODE_BUILD_BUILD_PATH

Browse Source 
If not set, [node-build defaults to a timestamped subdirectory of
`TMPDIR`](https://github.com/nodenv/node-build#custom-build-configuration),
which is exactly what we need.

This fixes https://github.com/asdf-vm/asdf-nodejs/issues/289

With this change, I see repeated builds fail in the exact same way (see
https://github.com/asdf-vm/asdf-nodejs/issues/289 for a detailed
explanation of what used to happen):

    $ PATH="$PWD:$PATH" ASDF_NODEJS_FORCE_COMPILE=1 asdf install nodejs 14.18.1
    Trying to update node-build... ok

    WARNING: node-v14.18.1 is in LTS Maintenance mode and nearing its end of life.
    It only receives *critical* security updates, *critical* bug fixes and documentation updates.

    Installing node-v14.18.1...

    BUILD FAILED (Arch rolling using node-build 4.9.69)

    Inspect or clean up the working tree at /tmp/node-build.20220216023317.178521.tZF5cV
    Results logged to /tmp/node-build.20220216023317.178521.log

    Last 10 log lines:
    /tmp/node-build.20220216023317.178521.tZF5cV ~/tmp/demoing
    /tmp/node-build.20220216023317.178521.tZF5cV/node-v14.18.1 /tmp/node-build.20220216023317.178521.tZF5cV ~/tmp/demoing
    Node.js configure: Found Python 3.9.6...
    WARNING: C compiler (CC=gcc, 0.0.0) too old, need gcc 4.2 or clang 3.2
    WARNING: Could not recognize `gas`:
    ERROR: Did not find a new enough assembler, install one or build with
           --openssl-no-asm.
           Please refer to BUILDING.md

    $ PATH="$PWD:$PATH" ASDF_NODEJS_FORCE_COMPILE=1 asdf install nodejs 14.18.1
    Trying to update node-build... ok

    WARNING: node-v14.18.1 is in LTS Maintenance mode and nearing its end of life.
    It only receives *critical* security updates, *critical* bug fixes and documentation updates.

    Installing node-v14.18.1...

    BUILD FAILED (Arch rolling using node-build 4.9.69)

    Inspect or clean up the working tree at /tmp/node-build.20220216023335.178790.u0kcPV
    Results logged to /tmp/node-build.20220216023335.178790.log

    Last 10 log lines:
    /tmp/node-build.20220216023335.178790.u0kcPV ~/tmp/demoing
    /tmp/node-build.20220216023335.178790.u0kcPV/node-v14.18.1 /tmp/node-build.20220216023335.178790.u0kcPV ~/tmp/demoing
    Node.js configure: Found Python 3.9.6...
    WARNING: C compiler (CC=gcc, 0.0.0) too old, need gcc 4.2 or clang 3.2
    WARNING: Could not recognize `gas`:
    ERROR: Did not find a new enough assembler, install one or build with
           --openssl-no-asm.
           Please refer to BUILDING.md
This commit is contained in:
Jeremy Fleischman 2022-02-16 02:34:24 -08:00
parent ad4c3a7b54
commit dbc07b70a9
No known key found for this signature in database
GPG Key ID: 19319CD8416A642B
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bin/install
View File

@ -49,8 +49,7 @@ install_canon_version() {
try_to_update_nodebuild
NODE_BUILD_BUILD_PATH="${NODE_BUILD_BUILD_PATH:-$ASDF_DOWNLOAD_PATH}" \
NODE_BUILD_CACHE_PATH="${NODE_BUILD_CACHE_PATH:-$ASDF_DOWNLOAD_PATH}" \
NODE_BUILD_CACHE_PATH="${NODE_BUILD_CACHE_PATH:-$ASDF_DOWNLOAD_PATH}" \
nodebuild_wrapped ${args+"${args[@]}"} "$version" "$install_path"
}