From 03fc978db225e9c0a734a54a51e5589226c7ce34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dominik=20Garc=C3=ADa?= <dominikgbertapelle@gmail.com>
Date: Fri, 29 Dec 2017 03:27:53 +0100
Subject: [PATCH 1/2] fix channels

fix channels

add sound to channels

fix channels
---
 src/@ionic-native/plugins/push/index.ts | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/@ionic-native/plugins/push/index.ts b/src/@ionic-native/plugins/push/index.ts
index 0d5d866da..604be908d 100644
--- a/src/@ionic-native/plugins/push/index.ts
+++ b/src/@ionic-native/plugins/push/index.ts
@@ -219,6 +219,7 @@ export interface Channel {
   id: string;
   description: string;
   importance: Priority;
+  sound?: string;
 }
 
 export type PushEvent = string;
@@ -332,17 +333,21 @@ export class Push extends IonicNativePlugin {
 
   /**
    * Create a new notification channel for Android O and above.
-   * @param channel {Channel}
+   * @param [channel] {Channel}
    */
-  @Cordova()
-  createChannel(channel: Channel): Promise<any> { return; }
+  @Cordova({
+    callbackOrder: 'reverse'
+  })
+  createChannel(channel?: Channel): Promise<any> { return; }
 
   /**
    * Delete a notification channel for Android O and above.
-   * @param id
+   * @param [id]
    */
-  @Cordova()
-  deleteChannel(id: string): Promise<any> { return; }
+  @Cordova({
+    callbackOrder: 'reverse'
+  })
+  deleteChannel(id?: string): Promise<any> { return; }
 
   /**
    * Returns a list of currently configured channels.

From c8361841f4eb4fe9526d48544d90be34c354f0e8 Mon Sep 17 00:00:00 2001
From: Daniel Sogl <daniel@sogls.de>
Date: Sat, 17 Mar 2018 00:35:41 +0100
Subject: [PATCH 2/2] ref jsdocs

---
 src/@ionic-native/plugins/push/index.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/@ionic-native/plugins/push/index.ts b/src/@ionic-native/plugins/push/index.ts
index 604be908d..21058efc3 100644
--- a/src/@ionic-native/plugins/push/index.ts
+++ b/src/@ionic-native/plugins/push/index.ts
@@ -333,7 +333,7 @@ export class Push extends IonicNativePlugin {
 
   /**
    * Create a new notification channel for Android O and above.
-   * @param [channel] {Channel}
+   * @param channel {Channel}
    */
   @Cordova({
     callbackOrder: 'reverse'
@@ -342,7 +342,7 @@ export class Push extends IonicNativePlugin {
 
   /**
    * Delete a notification channel for Android O and above.
-   * @param [id]
+   * @param id {string}
    */
   @Cordova({
     callbackOrder: 'reverse'