From 2c5aed961918f45954c4309087873ba181f2ad6a Mon Sep 17 00:00:00 2001
From: Vlado Velichkovski <stormwin@users.noreply.github.com>
Date: Mon, 9 Oct 2017 19:25:50 +0200
Subject: [PATCH] fix,docs(firebase): make 'namespace' param optional in
 setDefault; remove callback indexes; docs fix

Add optional label for optional parameters in docs
remove wrong callback indexes
make 'namespace' param optional in setDefault
---
 src/@ionic-native/plugins/firebase/index.ts | 28 +++++++--------------
 1 file changed, 9 insertions(+), 19 deletions(-)

diff --git a/src/@ionic-native/plugins/firebase/index.ts b/src/@ionic-native/plugins/firebase/index.ts
index 11906fc1c..29a78ae81 100644
--- a/src/@ionic-native/plugins/firebase/index.ts
+++ b/src/@ionic-native/plugins/firebase/index.ts
@@ -158,13 +158,10 @@ export class Firebase extends IonicNativePlugin {
 
   /**
    * Fetch Remote Config parameter values for your app
-   * @param cacheExpirationSeconds
+   * @param cacheExpirationSeconds {number}
    * @return {Promise<any>}
    */
-  @Cordova({
-    successIndex: 1,
-    errorIndex: 2
-  })
+  @Cordova()
   fetch(cacheExpirationSeconds?: number): Promise<any> { return; }
 
   /**
@@ -177,25 +174,20 @@ export class Firebase extends IonicNativePlugin {
   /**
    * Retrieve a Remote Config value
    * @param key {string}
-   * @param namespace {string}
+   * @param [namespace] {string}
    * @return {Promise<any>}
    */
-  @Cordova({
-    successIndex: 2,
-    errorIndex: 3
-  })
+  @Cordova()
   getValue(key: string, namespace?: string): Promise<any> { return; }
 
   /**
    * Retrieve a Remote Config byte array
    * @param key {string}
-   * @param namespace {string}
+   * @param [namespace] {string}
    * @return {Promise<any>}
    */
   @Cordova({
-    platforms: ['Android'],
-    successIndex: 2,
-    errorIndex: 3
+    platforms: ['Android']
   })
   getByteArray(key: string, namespace?: string): Promise<any> { return; }
 
@@ -221,14 +213,12 @@ export class Firebase extends IonicNativePlugin {
   /**
    * Set defaults in the Remote Config
    * @param defaults {Object}
-   * @param namespace {string}
+   * @param [namespace] {string}
    * @return {Promise<any>}
    */
   @Cordova({
-    platforms: ['Android'],
-    successIndex: 2,
-    errorIndex: 3
+    platforms: ['Android']
   })
-  setDefaults(defaults: any, namespace: string): Promise<any> { return; }
+  setDefaults(defaults: any, namespace?: string): Promise<any> { return; }
 
 }