From 3830de5d695474264fc53518c617e086fc3ed73a Mon Sep 17 00:00:00 2001 From: Jamy Timmermans Date: Wed, 22 Mar 2017 23:49:10 +0100 Subject: [PATCH 1/3] docs(deeplinks): change DeepLinks to Deeplinks (#1223) --- src/@ionic-native/plugins/deeplinks/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/@ionic-native/plugins/deeplinks/index.ts b/src/@ionic-native/plugins/deeplinks/index.ts index 8d0e7c5af..40dcd9574 100644 --- a/src/@ionic-native/plugins/deeplinks/index.ts +++ b/src/@ionic-native/plugins/deeplinks/index.ts @@ -32,9 +32,9 @@ export interface DeeplinkMatch { * ```typescript * import { Deeplinks } from '@ionic-native/deeplinks'; * - * constructor(private deepLinks: DeepLinks) { } + * constructor(private deeplinks: Deeplinks) { } * - * this.deepLinks.route({ + * this.deeplinks.route({ * '/about-us': AboutPage, * '/universal-links-test': AboutPage, * '/products/:productId': ProductPage @@ -53,7 +53,7 @@ export interface DeeplinkMatch { * the actual navigation for you: * * ```typescript - * this.deepLinks.routeWithNavController(this.navController, { + * this.deeplinks.routeWithNavController(this.navController, { * '/about-us': AboutPage, * '/products/:productId': ProductPage * }).subscribe((match) => { From 0c9eb8e1dd622a2e3f1cbcf5144cbc945752209f Mon Sep 17 00:00:00 2001 From: Nick Holder Date: Wed, 22 Mar 2017 17:52:13 -0500 Subject: [PATCH 2/3] docs(toast): fix typo Changed thisoast to this.toast --- src/@ionic-native/plugins/toast/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/toast/index.ts b/src/@ionic-native/plugins/toast/index.ts index 359016976..f9ef0a793 100644 --- a/src/@ionic-native/plugins/toast/index.ts +++ b/src/@ionic-native/plugins/toast/index.ts @@ -51,7 +51,7 @@ export interface ToastOptions { * * ... * - * thisoast.show("I'm a toast", '5000', 'center').subscribe( + * this.toast.show("I'm a toast", '5000', 'center').subscribe( * toast => { * console.log(toast); * } From 82d2ae8c4d1009db3e15af677ae6ebaf95d55767 Mon Sep 17 00:00:00 2001 From: Vasilis Koutsopoulos Date: Thu, 23 Mar 2017 00:53:55 +0200 Subject: [PATCH 3/3] fix(media-plugin): MediaPlugin.create promise never fires (#1220) --- src/@ionic-native/plugins/media/index.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/@ionic-native/plugins/media/index.ts b/src/@ionic-native/plugins/media/index.ts index 525fd77ad..b8a0c8afa 100644 --- a/src/@ionic-native/plugins/media/index.ts +++ b/src/@ionic-native/plugins/media/index.ts @@ -14,7 +14,7 @@ export class MediaObject { * @param src {string} A URI containing the audio content. * @param onStatusUpdate {Function} A callback function to be invoked when the status of the file changes */ - constructor(private _objectInstnace: any) {} + constructor(private _objectInstance: any) {} /** * Get the current amplitude of the current recording. @@ -256,7 +256,8 @@ export class MediaPlugin { // Creates a new media object // Resolves with the media object // or rejects with the error - const instance = new Media(src, () => resolve(new Media(instance)), reject, onStatusUpdate); + const instance = new Media(src, resolve, reject, onStatusUpdate); + return resolve(new MediaObject(instance)); }); }