github/awesome-cordova-plugins
github/awesome-cordova-plugins
2
0
Fork 1
mirror of https://github.com/danielsogl/awesome-cordova-plugins.git synced 2025-01-31 18:49:43 +08:00
Code Issues Projects Releases Wiki Activity

fix(firebase-x): indicate callback methods to verifyPhoneNumber (#3457)

Browse Source 
- and remove callbacks methods on verifyNumber and signInWithCredential functions
This commit is contained in:
Victor Dias 2020-06-23 17:59:45 +01:00 committed by GitHub
parent fe21b5b97c
commit 66896b2632
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/@ionic-native/plugins/firebase-x/index.ts
View File

@ -490,8 +490,6 @@ export class FirebaseX extends IonicNativePlugin {
* the verification code along with the verification ID. In this case, the user doesn't need to do anything in order for you * the verification code along with the verification ID. In this case, the user doesn't need to do anything in order for you
* to sign them in. * to sign them in.
* *
* @param {function} success - callback function to pass {object} credentials to as an argument
* @param {function} error - callback function which will be passed a {string} error message as an argument
* @param {string} phoneNumber - phone number to verify * @param {string} phoneNumber - phone number to verify
* @param {integer} timeOutDuration - time to wait in seconds before timing out * @param {integer} timeOutDuration - time to wait in seconds before timing out
* @param {string} fakeVerificationCode - (optional) to test instant verification on Android ,specify a fake verification code to return for whitelisted phone numbers. * @param {string} fakeVerificationCode - (optional) to test instant verification on Android ,specify a fake verification code to return for whitelisted phone numbers.
@ -501,10 +499,10 @@ export class FirebaseX extends IonicNativePlugin {
* verificationId {string} - the verification ID you'll need to pass along with the verification code to sign the user in. Always returned on both Android & iOS. * verificationId {string} - the verification ID you'll need to pass along with the verification code to sign the user in. Always returned on both Android & iOS.
* code {string} - verification code. Will only be present if instantVerification is true. Always undefined on iOS. * code {string} - verification code. Will only be present if instantVerification is true. Always undefined on iOS.
*/ */
@Cordova() @Cordova({
callbackOrder: 'reverse'
})
verifyPhoneNumber( verifyPhoneNumber(
success: (value: string | object) => void,
error: (err: string) => void,
phoneNumber: string, phoneNumber: string,
timeOutDuration: number, timeOutDuration: number,
fakeVerificationCode?: string fakeVerificationCode?: string
@ -516,11 +514,9 @@ export class FirebaseX extends IonicNativePlugin {
* Signs the user into Firebase with credentials obtained using verifyPhoneNumber(). * Signs the user into Firebase with credentials obtained using verifyPhoneNumber().
* See the Android- and iOS-specific Firebase documentation for more info. * See the Android- and iOS-specific Firebase documentation for more info.
* @param {object} credential - a credential object returned by the success callback of an authentication method * @param {object} credential - a credential object returned by the success callback of an authentication method
* @param {function} success - callback function to call on successful sign-in using credentials
* @param {function} error - callback function which will be passed a {string} error message as an argument
*/ */
@Cordova() @Cordova()
signInWithCredential(credential: object, success: () => void, error: (err: string) => void): Promise<any> { signInWithCredential(credential: object): Promise<any> {
return; return;
} }