github/awesome-cordova-plugins
github/awesome-cordova-plugins
2
0
Fork 1
mirror of https://github.com/danielsogl/awesome-cordova-plugins.git synced 2025-01-19 16:52:53 +08:00
Code Issues Projects Releases Wiki Activity

refactor(core): wrapInstance should return promise as-is

Browse Source 
instance based method never throw errors like regular ones do
This commit is contained in:
Ibby Hadeed 2017-05-17 10:46:47 -04:00
parent 1ec4bdef8f
commit 8aca6718e1
1 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/@ionic-native/core/plugin.ts
View File

@ -297,16 +297,7 @@ export function wrapInstance(pluginObj: any, methodName: string, opts: any = {})
} else {
let pluginResult: any, rej: Function;
const p = getPromise((resolve: Function, reject: Function) => {
pluginResult = callInstance(pluginObj, methodName, args, opts, resolve, reject);
rej = reject;
});
if (pluginResult && pluginResult.error) {
p.catch(() => { });
typeof rej === 'function' && rej(pluginResult.error);
}
return p;
return getPromise((resolve: Function, reject: Function) => callInstance(pluginObj, methodName, args, opts, resolve, reject));
}
};