From 6ddd2aa1841bb04d2e9441b1b761c72609f4b0dd Mon Sep 17 00:00:00 2001 From: Thomas Kemmer Date: Mon, 9 Jan 2017 11:06:33 +0100 Subject: [PATCH 1/3] fix(ble): stopScan takes no args when used as clear function (#944) --- src/plugins/ble.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/ble.ts b/src/plugins/ble.ts index 6f668a870..770287b7a 100644 --- a/src/plugins/ble.ts +++ b/src/plugins/ble.ts @@ -205,7 +205,7 @@ export class BLE { @Cordova({ observable: true, clearFunction: 'stopScan', - clearWithArgs: true + clearWithArgs: false }) static startScan(services: string[]): Observable { return; } @@ -218,7 +218,7 @@ export class BLE { @Cordova({ observable: true, clearFunction: 'stopScan', - clearWithArgs: true + clearWithArgs: false }) static startScanWithOptions(services: string[], options: {reportDuplicates?: boolean} | any): Observable { return; } From ebf07161b6cc64c62dabdec46d3e9c32d053553e Mon Sep 17 00:00:00 2001 From: Josh Gibbs Date: Mon, 9 Jan 2017 02:07:57 -0800 Subject: [PATCH 2/3] fix(onesignal): OSNotification.app_id is optional (#946) OSNotification::app_id is not required when sending a selfNotification. --- src/plugins/onesignal.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/onesignal.ts b/src/plugins/onesignal.ts index 619024de8..f19b8867c 100644 --- a/src/plugins/onesignal.ts +++ b/src/plugins/onesignal.ts @@ -26,7 +26,7 @@ export interface OSNotification { * **ANDROID** - Notification is a summary notification for a group this will contain all notification payloads it was created from. */ groupedNotifications?: OSNotificationPayload[]; - app_id: string; + app_id?: string; contents: any; headings?: any; isIos?: boolean; From 2ddb8be775efb6c88ca11d2652ea6bb158ead5de Mon Sep 17 00:00:00 2001 From: MSadiqR Date: Mon, 9 Jan 2017 15:40:08 +0430 Subject: [PATCH 3/3] Typescript error solved (#947) Added a placeholder parameter to resolve typescript error --- src/plugins/sqlite.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/sqlite.ts b/src/plugins/sqlite.ts index 377687386..806f47abc 100644 --- a/src/plugins/sqlite.ts +++ b/src/plugins/sqlite.ts @@ -21,7 +21,7 @@ declare var sqlitePlugin; * }) * .then((db: SQLite) => { * - * db.executeSql('create table danceMoves(name VARCHAR(32))').then(() => {}).catch(() => {}); + * db.executeSql('create table danceMoves(name VARCHAR(32))', {}).then(() => {}).catch(() => {}); * * }) * .catch(error => console.error('Error opening database', error);