github/awesome-cordova-plugins
github/awesome-cordova-plugins
2
0
Fork 1
mirror of https://github.com/danielsogl/awesome-cordova-plugins.git synced 2025-02-22 01:19:36 +08:00
Code Issues Projects Releases Wiki Activity

fix(in-app-browser): fix on method

Browse Source 
closes #1446
This commit is contained in:
Ibby Hadeed 2017-05-17 07:27:51 -04:00
parent d68618f878
commit 975a65d619
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/@ionic-native/plugins/in-app-browser/index.ts
View File

@ -1,7 +1,7 @@
import { Injectable } from '@angular/core'; import { Injectable } from '@angular/core';
import { Plugin, CordovaInstance, IonicNativePlugin } from '@ionic-native/core'; import { Plugin, CordovaInstance, InstanceCheck, IonicNativePlugin } from '@ionic-native/core';
import { Observable } from 'rxjs/Observable'; import { Observable } from 'rxjs/Observable';
import 'rxjs/add/observable/fromEvent'; import { Observer } from 'rxjs/Observer';
declare const cordova: Cordova & { InAppBrowser: any; }; declare const cordova: Cordova & { InAppBrowser: any; };
@ -141,8 +141,12 @@ export class InAppBrowserObject {
* @param event {string} Name of the event * @param event {string} Name of the event
* @returns {Observable<InAppBrowserEvent>} Returns back an observable that will listen to the event on subscribe, and will stop listening to the event on unsubscribe. * @returns {Observable<InAppBrowserEvent>} Returns back an observable that will listen to the event on subscribe, and will stop listening to the event on unsubscribe.
*/ */
@InstanceCheck()
on(event: string): Observable<InAppBrowserEvent> { on(event: string): Observable<InAppBrowserEvent> {
return Observable.fromEvent(this._objectInstance, event); return new Observable<InAppBrowserEvent>((observer: Observer<InAppBrowserEvent>) => {
this._objectInstance.addEventListener(event, observer.next.bind(observer));
return () => this._objectInstance.removeEventListener(event, observer.next.bind(observer));
});
} }
} }