github/awesome-cordova-plugins
github/awesome-cordova-plugins
2
0
Fork 1
mirror of https://github.com/danielsogl/awesome-cordova-plugins.git synced 2025-03-04 00:13:06 +08:00
Code Issues Projects Releases Wiki Activity

fix(firebase-x): setConfigSettings function input parameters aligned with firebase-x plugin (#4757)

Browse Source 
* Implement fix

* revert changes to firebase

* correct success callback

* fix jsdoc

* fix return type
This commit is contained in:
Art Turanoff 2024-04-17 19:26:08 +10:00 committed by GitHub
parent d607550573
commit adb330aa63
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/@awesome-cordova-plugins/plugins/firebase-x/index.ts
View File

@ -116,7 +116,7 @@ export interface MessagePayloadAps {
alert?: { alert?: {
title: string; title: string;
body: string; body: string;
} };
} }
export interface MessagePayload { export interface MessagePayload {
title?: string; title?: string;
@ -830,13 +830,20 @@ export class FirebaseX extends AwesomeCordovaNativePlugin {
} }
/** /**
* Android only. Change the settings for the FirebaseRemoteConfig object's operations. * Change the settings for the FirebaseRemoteConfig object's operations.
* *
* @param {Object} settings * @param {number} fetchTimeout - fetch timeout in seconds. Default is 60 seconds.
* @returns {Promise<any>} * @param {number} minimumFetchInterval - minimum fetch inteval in seconds. Default is 12 hours.
* @param {Function} success - callback function to be call on successfully setting the remote config settings
* @param {Function} error - callback function which will be passed a {string} error message as an argument
*/ */
@Cordova() @Cordova()
setConfigSettings(settings: any): Promise<any> { setConfigSettings(
fetchTimeout: number,
minimumFetchInterval: number,
success: () => void,
error: (err: string) => void
): void {
return; return;
} }