github/awesome-cordova-plugins
github/awesome-cordova-plugins
3
0
Fork 1
mirror of https://github.com/danielsogl/awesome-cordova-plugins.git synced 2025-03-17 09:01:07 +08:00
Code Issues Projects Releases Wiki Activity

refractor(): use Observable.fromEvent in wrapEventObservable

Browse Source
This commit is contained in:
Ibby 2017-02-04 04:16:57 -05:00
parent 4ab87d8abb
commit add49e8b4d
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/plugins/plugin.ts
View File

@ -1,5 +1,6 @@
import { get } from '../util'; import { get } from '../util';
import { Observable } from 'rxjs/Observable'; import { Observable } from 'rxjs/Observable';
import 'rxjs/add/observable/fromEvent';
declare var window; declare var window;
declare var Promise; declare var Promise;
@ -86,6 +87,10 @@ export interface CordovaOptions {
* Event name, this must be set if eventObservable is set to true * Event name, this must be set if eventObservable is set to true
*/ */
event?: string; event?: string;
/**
* Element to attach the event listener to, this is optional, defaults to `window`
*/
element?: any;
/** /**
* Set to true if the wrapped method returns a promise * Set to true if the wrapped method returns a promise
*/ */
@ -337,14 +342,12 @@ function wrapInstance(pluginObj: any, methodName: string, opts: any = {}) {
/** /**
* Wrap the event with an observable * Wrap the event with an observable
* @param event * @param event even name
* @param element The element to attach the event listener to
* @returns {Observable} * @returns {Observable}
*/ */
function wrapEventObservable(event: string): Observable<any> { function wrapEventObservable(event: string, element: any = window): Observable<any> {
return new Observable(observer => { return Observable.fromEvent(element, event);
window.addEventListener(event, observer.next.bind(observer), false);
return () => window.removeEventListener(event, observer.next.bind(observer), false);
});
} }
/** /**
@ -403,7 +406,7 @@ export const wrap = function(pluginObj: any, methodName: string, opts: CordovaOp
} else if (opts.observable) { } else if (opts.observable) {
return wrapObservable(pluginObj, methodName, args, opts); return wrapObservable(pluginObj, methodName, args, opts);
} else if (opts.eventObservable && opts.event) { } else if (opts.eventObservable && opts.event) {
return wrapEventObservable(opts.event); return wrapEventObservable(opts.event, opts.element);
} else if (opts.otherPromise) { } else if (opts.otherPromise) {
return wrapOtherPromise(pluginObj, methodName, args, opts); return wrapOtherPromise(pluginObj, methodName, args, opts);
} else { } else {