From ee3a0c7c6ac5a153554046f32c96913974ab539c Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Thu, 15 Mar 2018 17:00:54 +0100 Subject: [PATCH 1/2] refactor(WheelSelector): add union type for theme --- src/@ionic-native/plugins/wheel-selector/index.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/@ionic-native/plugins/wheel-selector/index.ts b/src/@ionic-native/plugins/wheel-selector/index.ts index b97a9d326..ad687c50e 100644 --- a/src/@ionic-native/plugins/wheel-selector/index.ts +++ b/src/@ionic-native/plugins/wheel-selector/index.ts @@ -42,7 +42,7 @@ export interface WheelSelectorOptions { * Android only - theme color, 'light' or 'dark'. * Default: light */ - theme?: string; + theme?: 'light' | 'dark' /** * Whether to have the wheels 'wrap' (Android only) @@ -76,7 +76,7 @@ export interface WheelSelectorData { * * ... * - * let jsonData = { + * const jsonData = { * numbers: [ * { description: "1" }, * { description: "2" }, @@ -105,7 +105,7 @@ export interface WheelSelectorData { * * ... * - * //basic number selection, index is always returned in the result + * // basic number selection, index is always returned in the result * selectANumber() { * this.selector.show({ * title: "How Many?", @@ -122,7 +122,7 @@ export interface WheelSelectorData { * * ... * - * //basic selection, setting initial displayed default values: '3' 'Banana' + * // basic selection, setting initial displayed default values: '3' 'Banana' * selectFruit() { * this.selector.show({ * title: "How Much?", @@ -145,8 +145,8 @@ export interface WheelSelectorData { * * ... * - * //more complex as overrides which key to display - * //then retrieve properties from original data + * // more complex as overrides which key to display + * // then retrieve properties from original data * selectNamesUsingDisplayKey() { * this.selector.show({ * title: "Who?", From e612c5fcc373e52df3e596552b801f8cd0852119 Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Thu, 15 Mar 2018 17:29:25 +0100 Subject: [PATCH 2/2] fix linter --- src/@ionic-native/plugins/wheel-selector/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/wheel-selector/index.ts b/src/@ionic-native/plugins/wheel-selector/index.ts index ad687c50e..5f5f787fa 100644 --- a/src/@ionic-native/plugins/wheel-selector/index.ts +++ b/src/@ionic-native/plugins/wheel-selector/index.ts @@ -42,7 +42,7 @@ export interface WheelSelectorOptions { * Android only - theme color, 'light' or 'dark'. * Default: light */ - theme?: 'light' | 'dark' + theme?: 'light' | 'dark'; /** * Whether to have the wheels 'wrap' (Android only)