From d3c2859d3865539dffb2d8039da0f216ada007f3 Mon Sep 17 00:00:00 2001 From: Perry Govier Date: Tue, 24 Apr 2018 15:12:21 -0500 Subject: [PATCH] fix(linting): Fixing misc linting errors that typedoc complains about (#2476) * fix(linting): Fixing misc linting errors that typedoc complains about * angularJS safe promises * fix(clibpoard): minor linting error --- src/@ionic-native/plugins/clipboard/index.ts | 2 +- .../plugins/email-composer/index.ts | 1 + src/@ionic-native/plugins/fcm/index.ts | 1 - .../plugins/in-app-browser/index.ts | 24 ++++++++++++++----- src/@ionic-native/plugins/qr-scanner/index.ts | 1 - src/@ionic-native/plugins/web-intent/index.ts | 6 ----- 6 files changed, 20 insertions(+), 15 deletions(-) diff --git a/src/@ionic-native/plugins/clipboard/index.ts b/src/@ionic-native/plugins/clipboard/index.ts index 3e87d787e..80cbdce4f 100644 --- a/src/@ionic-native/plugins/clipboard/index.ts +++ b/src/@ionic-native/plugins/clipboard/index.ts @@ -26,7 +26,7 @@ import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core'; * alert('Error: ' + reject); * } * ); - * + * * this.clipboard.clear(); * ``` */ diff --git a/src/@ionic-native/plugins/email-composer/index.ts b/src/@ionic-native/plugins/email-composer/index.ts index 303917874..7fd29ca23 100644 --- a/src/@ionic-native/plugins/email-composer/index.ts +++ b/src/@ionic-native/plugins/email-composer/index.ts @@ -2,6 +2,7 @@ import { Injectable } from '@angular/core'; import { Cordova, CordovaCheck, + getPromise, IonicNativePlugin, Plugin } from '@ionic-native/core'; diff --git a/src/@ionic-native/plugins/fcm/index.ts b/src/@ionic-native/plugins/fcm/index.ts index e411938b2..b37ced261 100644 --- a/src/@ionic-native/plugins/fcm/index.ts +++ b/src/@ionic-native/plugins/fcm/index.ts @@ -1,6 +1,5 @@ import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core'; import { Injectable } from '@angular/core'; -import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core'; import { Observable } from 'rxjs'; export interface NotificationData { diff --git a/src/@ionic-native/plugins/in-app-browser/index.ts b/src/@ionic-native/plugins/in-app-browser/index.ts index f6af7d57a..6887fd8f9 100644 --- a/src/@ionic-native/plugins/in-app-browser/index.ts +++ b/src/@ionic-native/plugins/in-app-browser/index.ts @@ -1,12 +1,21 @@ -import { Observable } from 'rxjs'; +import { Observable, Observer } from 'rxjs'; +import { Injectable } from '@angular/core'; +import { + CordovaInstance, + InstanceCheck, + IonicNativePlugin, + Plugin +} from '@ionic-native/core'; declare const cordova: Cordova & { InAppBrowser: any }; export interface InAppBrowserOptions { /** Set to yes or no to turn the InAppBrowser's location bar on or off. */ location?: 'yes' | 'no'; - /** Set to yes to create the browser and load the page, but not show it. The loadstop event fires when loading is complete. - * Omit or set to no (default) to have the browser open and load normally. */ + /** + * Set to yes to create the browser and load the page, but not show it. The loadstop event fires when loading is complete. + * Omit or set to no (default) to have the browser open and load normally. + */ hidden?: 'yes' | 'no'; /** Set to yes to have the browser's cookie cache cleared before the new window is opened. */ clearcache?: 'yes'; @@ -14,8 +23,10 @@ export interface InAppBrowserOptions { clearsessioncache?: 'yes'; /** (Android Only) set to yes to show Android browser's zoom controls, set to no to hide them. Default value is yes. */ zoom?: 'yes' | 'no'; - /** Set to yes to use the hardware back button to navigate backwards through the InAppBrowser's history. - * If there is no previous page, the InAppBrowser will close. The default value is yes, so you must set it to no if you want the back button to simply close the InAppBrowser. */ + /** + * Set to yes to use the hardware back button to navigate backwards through the InAppBrowser's history. + * If there is no previous page, the InAppBrowser will close. The default value is yes, so you must set it to no if you want the back button to simply close the InAppBrowser. + */ hardwareback?: 'yes' | 'no'; /** Set to yes to prevent HTML5 audio or video from autoplaying (defaults to no). */ mediaPlaybackRequiresUserAction?: 'yes' | 'no'; @@ -33,7 +44,8 @@ export interface InAppBrowserOptions { toolbar?: 'yes' | 'no'; /** (iOS Only) Set to yes or no to prevent viewport scaling through a meta tag (defaults to no). */ enableViewportScale?: 'yes' | 'no'; - /** (iOS Only) Set to yes or no to allow in-line HTML5 media playback, displaying within the browser window rather than a device-specific playback interface. + /* + * (iOS Only) Set to yes or no to allow in-line HTML5 media playback, displaying within the browser window rather than a device-specific playback interface. * The HTML's video element must also include the webkit-playsinline attribute (defaults to no) */ allowInlineMediaPlayback?: 'yes' | 'no'; /** (iOS Only) Set to yes or no to open the keyboard when form elements receive focus via JavaScript's focus() call (defaults to yes). */ diff --git a/src/@ionic-native/plugins/qr-scanner/index.ts b/src/@ionic-native/plugins/qr-scanner/index.ts index e56873697..cf9b2b9ee 100644 --- a/src/@ionic-native/plugins/qr-scanner/index.ts +++ b/src/@ionic-native/plugins/qr-scanner/index.ts @@ -1,4 +1,3 @@ -import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core'; import { Injectable } from '@angular/core'; import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core'; import { Observable } from 'rxjs'; diff --git a/src/@ionic-native/plugins/web-intent/index.ts b/src/@ionic-native/plugins/web-intent/index.ts index eeffa0d73..0db287afc 100644 --- a/src/@ionic-native/plugins/web-intent/index.ts +++ b/src/@ionic-native/plugins/web-intent/index.ts @@ -210,12 +210,6 @@ export class WebIntent extends IonicNativePlugin { @Cordova({ sync: true }) unregisterBroadcastReceiver(): void {} - /** - * Returns the content of the intent used whenever the application activity is launched - */ - @Cordova({ sync: true }) - onIntent(): void {} - /** * */