github/awesome-cordova-plugins
github/awesome-cordova-plugins
3
0
Fork 1
mirror of https://github.com/danielsogl/awesome-cordova-plugins.git synced 2025-04-21 17:36:27 +08:00
Code Issues Projects Releases Wiki Activity

fix(onesignal): make params optional (#2507)

Browse Source 
Made all properties in OSNotification optional because when you create a push notification the type is OSNotification but it does not have all the same properties required as the OSNotification as a response from a received notification. For example, you don't pass in isAppInFocus when you create a notification but it was causing issues when trying to post a notification because it was showing as required because OSNotification as a response will always have isAppInFocus.
This commit is contained in:
Kheva Mann 2018-05-16 16:14:27 -07:00 committed by Ibby Hadeed
parent 714114d1e0
commit e6db28123d
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/@ionic-native/plugins/onesignal/index.ts
View File

@ -6,11 +6,11 @@ export interface OSNotification {
/** /**
* Was app in focus. * Was app in focus.
*/ */
isAppInFocus: boolean; isAppInFocus?: boolean;
/** /**
* Was notification shown to the user. Will be false for silent notifications. * Was notification shown to the user. Will be false for silent notifications.
*/ */
shown: boolean; shown?: boolean;
/** /**
* **ANDROID** - Android Notification assigned to the notification. Can be used to cancel or replace the notification. * **ANDROID** - Android Notification assigned to the notification. Can be used to cancel or replace the notification.
*/ */
@ -18,17 +18,17 @@ export interface OSNotification {
/** /**
* Payload received from OneSignal. * Payload received from OneSignal.
*/ */
payload: OSNotificationPayload; payload?: OSNotificationPayload;
/** /**
* How the notification was displayed to the user. Can be set to `Notification`, `InAppAlert`, or `None` if it was not displayed. * How the notification was displayed to the user. Can be set to `Notification`, `InAppAlert`, or `None` if it was not displayed.
*/ */
displayType: OSDisplayType; displayType?: OSDisplayType;
/** /**
* **ANDROID** - Notification is a summary notification for a group this will contain all notification payloads it was created from. * **ANDROID** - Notification is a summary notification for a group this will contain all notification payloads it was created from.
*/ */
groupedNotifications?: OSNotificationPayload[]; groupedNotifications?: OSNotificationPayload[];
app_id?: string; app_id?: string;
contents: any; contents?: any;
headings?: any; headings?: any;
isIos?: boolean; isIos?: boolean;
isAndroid?: boolean; isAndroid?: boolean;