From 5505e5f064461084b537e2a0984393298eef9db6 Mon Sep 17 00:00:00 2001 From: Tom Sundstrom Date: Thu, 24 Aug 2017 02:39:04 +0300 Subject: [PATCH 1/5] docs(): adjust log messages in photo library example callbacks (#1851) * Move error message to the error callback * Log a debug message in complete callback --- src/@ionic-native/plugins/photo-library/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/@ionic-native/plugins/photo-library/index.ts b/src/@ionic-native/plugins/photo-library/index.ts index 362ffeefd..f5be78c5b 100644 --- a/src/@ionic-native/plugins/photo-library/index.ts +++ b/src/@ionic-native/plugins/photo-library/index.ts @@ -31,8 +31,8 @@ import { Injectable } from '@angular/core'; * console.log(libraryItem.albumIds); // array of ids of appropriate AlbumItem, only of includeAlbumsData was used * }); * }, - * error: err => {}, - * complete: () => { console.log('could not get photos'); } + * error: err => { console.log('could not get photos'); }, + * complete: () => { console.log('done getting photos'); } * }); * }) * .catch(err => console.log('permissions weren\'t granted')); From 35d317f7f31bddadf620d7deb8ab0e5fb1c1315f Mon Sep 17 00:00:00 2001 From: Chris Date: Wed, 23 Aug 2017 19:39:29 -0400 Subject: [PATCH 2/5] docs(): add missing import (#1853) BackgroundGeolocationResponse was not declared in classes to import from @ionic-native/background-geolocation --- src/@ionic-native/plugins/background-geolocation/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/background-geolocation/index.ts b/src/@ionic-native/plugins/background-geolocation/index.ts index 4532c653c..99461d26e 100644 --- a/src/@ionic-native/plugins/background-geolocation/index.ts +++ b/src/@ionic-native/plugins/background-geolocation/index.ts @@ -264,7 +264,7 @@ export interface BackgroundGeolocationConfig { * BackgroundGeolocation must be called within app.ts and or before Geolocation. Otherwise the platform will not ask you for background tracking permission. * * ```typescript - * import { BackgroundGeolocation, BackgroundGeolocationConfig } from '@ionic-native/background-geolocation'; + * import { BackgroundGeolocation, BackgroundGeolocationConfig, BackgroundGeolocationResponse } from '@ionic-native/background-geolocation'; * * constructor(private backgroundGeolocation: BackgroundGeolocation) { } * From 39ef06687585bfb89de5547211c3b13d8e16981e Mon Sep 17 00:00:00 2001 From: Davor Peic Date: Wed, 23 Aug 2017 18:40:14 -0500 Subject: [PATCH 3/5] docs(cardio): update docs (#1858) Added iOS10 permission message and corrected requireCVV use --- src/@ionic-native/plugins/card-io/index.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/card-io/index.ts b/src/@ionic-native/plugins/card-io/index.ts index b59e498a6..5d96b76e5 100644 --- a/src/@ionic-native/plugins/card-io/index.ts +++ b/src/@ionic-native/plugins/card-io/index.ts @@ -133,6 +133,11 @@ export interface CardIOResponse { * @name Card IO * @description * @usage + * Note: For use with iOS 10 + When building your app with the iOS 10 SDK +, you have to add some info to the info.plist file. This is due to increased security in iOS 10. Go to your app directory and search for the Info.plist file. Add the following lines in the main element. + * ```xml + *NSCameraUsageDescription + *To scan credit cards. + *``` * ```typescript * import { CardIO } from '@ionic-native/card-io'; * @@ -147,7 +152,7 @@ export interface CardIOResponse { * if(res){ * let options = { * requireExpiry: true, - * requireCCV: false, + * requireCVV: false, * requirePostalCode: false * }; * CardIO.scan(options); From 262e18f409d182093b840d0dd3db247e9432e07f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fatih=20K=C4=B1zmaz?= Date: Thu, 24 Aug 2017 02:41:03 +0300 Subject: [PATCH 4/5] fix(native-spinner): update pluginRef (#1859) Wrong pluginRef causes errors: Native: tried calling SpinnerDialog.show, but the SpinnerDialog plugin is not installed. Install the SpinnerDialog plugin: 'ionic cordova plugin add cordova-plugin-native-spinner' Fix pluginRef to work properly. --- src/@ionic-native/plugins/spinner-dialog/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/spinner-dialog/index.ts b/src/@ionic-native/plugins/spinner-dialog/index.ts index 59004f2a2..25905669f 100644 --- a/src/@ionic-native/plugins/spinner-dialog/index.ts +++ b/src/@ionic-native/plugins/spinner-dialog/index.ts @@ -29,7 +29,7 @@ export interface SpinnerDialogIOSOptions { @Plugin({ pluginName: 'SpinnerDialog', plugin: 'cordova-plugin-native-spinner', - pluginRef: 'window.plugins.spinnerDialog', + pluginRef: 'SpinnerDialog', repo: 'https://github.com/greybax/cordova-plugin-native-spinner', platforms: ['Android', 'iOS', 'Windows Phone 8', 'Windows'] }) From cde87e21132fb9087631b066b27d05d9b05630ce Mon Sep 17 00:00:00 2001 From: martinhanke Date: Thu, 24 Aug 2017 01:42:47 +0200 Subject: [PATCH 5/5] feat(paypal): add payeeEmail for third party merchants (#1864) --- src/@ionic-native/plugins/paypal/index.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/@ionic-native/plugins/paypal/index.ts b/src/@ionic-native/plugins/paypal/index.ts index 1f8fecd52..497b980e1 100644 --- a/src/@ionic-native/plugins/paypal/index.ts +++ b/src/@ionic-native/plugins/paypal/index.ts @@ -204,6 +204,12 @@ export class PayPalPayment { */ items: Array; + /** + * Optional payee email, if your app is paying a third-party merchant. + * The payee's email. It must be a valid PayPal email address. + */ + payeeEmail: string; + /** * Optional customer shipping address, if your app wishes to provide this to the SDK. */