github/cordova-android
github/cordova-android
3
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2025-02-22 00:32:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: clean command (#815)

Browse Source 
* fix clean command
* added unit tests for the getArgs clean
* Cleaned up ProjectBuilder.getArgs for readability
This commit is contained in:
Norman Breau 2019-09-07 01:54:33 -03:00 committed by エリス
parent c93e3e9f6f
commit 1b11206174
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bin/templates/cordova/lib/builders/ProjectBuilder.js vendored
View File

@ -45,8 +45,8 @@ class ProjectBuilder {
getArgs (cmd, opts) { getArgs (cmd, opts) {
let args; let args;
let buildCmd = cmd;
if (opts.packageType === PackageType.BUNDLE) { if (opts.packageType === PackageType.BUNDLE) {
let buildCmd;
if (cmd === 'release') { if (cmd === 'release') {
buildCmd = ':app:bundleRelease'; buildCmd = ':app:bundleRelease';
} else if (cmd === 'debug') { } else if (cmd === 'debug') {
@ -55,7 +55,6 @@ class ProjectBuilder {
args = [buildCmd, '-b', path.join(this.root, 'build.gradle')]; args = [buildCmd, '-b', path.join(this.root, 'build.gradle')];
} else { } else {
let buildCmd;
if (cmd === 'release') { if (cmd === 'release') {
buildCmd = 'cdvBuildRelease'; buildCmd = 'cdvBuildRelease';
} else if (cmd === 'debug') { } else if (cmd === 'debug') {

14
spec/unit/builders/ProjectBuilder.spec.js
View File

@ -100,6 +100,20 @@ describe('ProjectBuilder', () => {
expect(args).toContain(`-PcdvBuildArch=${arch}`); expect(args).toContain(`-PcdvBuildArch=${arch}`);
}); });
it('should clean apk', () => {
const args = builder.getArgs('clean', {
packageType: 'apk'
});
expect(args[0]).toBe('clean');
});
it('should clean bundle', () => {
const args = builder.getArgs('clean', {
packageType: 'bundle'
});
expect(args[0]).toBe('clean');
});
}); });
describe('runGradleWrapper', () => { describe('runGradleWrapper', () => {