From 47bb5184a048cefe54af95a6b3436b0c668f17a2 Mon Sep 17 00:00:00 2001 From: Darryl Pogue Date: Wed, 26 Sep 2018 00:30:42 -0700 Subject: [PATCH] Silence some deprecation linter warnings --- framework/src/org/apache/cordova/CoreAndroid.java | 2 +- .../src/org/apache/cordova/engine/SystemCookieManager.java | 6 +++++- .../org/apache/cordova/engine/SystemWebChromeClient.java | 3 +++ .../src/org/apache/cordova/engine/SystemWebViewClient.java | 5 ++++- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/framework/src/org/apache/cordova/CoreAndroid.java b/framework/src/org/apache/cordova/CoreAndroid.java index 46a23edf..3945cdd6 100755 --- a/framework/src/org/apache/cordova/CoreAndroid.java +++ b/framework/src/org/apache/cordova/CoreAndroid.java @@ -144,7 +144,7 @@ public class CoreAndroid extends CordovaPlugin { public void clearCache() { cordova.getActivity().runOnUiThread(new Runnable() { public void run() { - webView.clearCache(true); + webView.clearCache(); } }); } diff --git a/framework/src/org/apache/cordova/engine/SystemCookieManager.java b/framework/src/org/apache/cordova/engine/SystemCookieManager.java index acf795fa..3e5df513 100644 --- a/framework/src/org/apache/cordova/engine/SystemCookieManager.java +++ b/framework/src/org/apache/cordova/engine/SystemCookieManager.java @@ -58,7 +58,11 @@ class SystemCookieManager implements ICordovaCookieManager { } public void clearCookies() { - cookieManager.removeAllCookie(); + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { + cookieManager.removeAllCookies(null); + } else { + cookieManager.removeAllCookie(); + } } public void flush() { diff --git a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java index a27fc6af..72846f0f 100755 --- a/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java +++ b/framework/src/org/apache/cordova/engine/SystemWebChromeClient.java @@ -142,6 +142,7 @@ public class SystemWebChromeClient extends WebChromeClient { * Handle database quota exceeded notification. */ @Override + @SuppressWarnings("deprecation") public void onExceededDatabaseQuota(String url, String databaseIdentifier, long currentQuota, long estimatedSize, long totalUsedQuota, WebStorage.QuotaUpdater quotaUpdater) { @@ -180,11 +181,13 @@ public class SystemWebChromeClient extends WebChromeClient { // API level 7 is required for this, see if we could lower this using something else @Override + @SuppressWarnings("deprecation") public void onShowCustomView(View view, WebChromeClient.CustomViewCallback callback) { parentEngine.getCordovaWebView().showCustomView(view, callback); } @Override + @SuppressWarnings("deprecation") public void onHideCustomView() { parentEngine.getCordovaWebView().hideCustomView(); } diff --git a/framework/src/org/apache/cordova/engine/SystemWebViewClient.java b/framework/src/org/apache/cordova/engine/SystemWebViewClient.java index 0b6a577e..616cef1e 100755 --- a/framework/src/org/apache/cordova/engine/SystemWebViewClient.java +++ b/framework/src/org/apache/cordova/engine/SystemWebViewClient.java @@ -74,7 +74,8 @@ public class SystemWebViewClient extends WebViewClient { * @param url The url to be loaded. * @return true to override, false for default behavior */ - @Override + @Override + @SuppressWarnings("deprecation") public boolean shouldOverrideUrlLoading(WebView view, String url) { return parentEngine.client.onNavigationAttempt(url); } @@ -186,6 +187,7 @@ public class SystemWebViewClient extends WebViewClient { * @param failingUrl The url that failed to load. */ @Override + @SuppressWarnings("deprecation") public void onReceivedError(WebView view, int errorCode, String description, String failingUrl) { // Ignore error due to stopLoading(). if (!isCurrentlyLoading) { @@ -316,6 +318,7 @@ public class SystemWebViewClient extends WebViewClient { } @Override + @SuppressWarnings("deprecation") public WebResourceResponse shouldInterceptRequest(WebView view, String url) { try { // Check the against the whitelist and lock out access to the WebView directory