github/cordova-android
github/cordova-android
3
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2025-02-22 00:32:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Do not clobber console.log to spy on it (#782)

Browse Source
This commit is contained in:
Raphael von der Grün 2019-07-17 00:18:12 +02:00 committed by GitHub
parent a64d459c8e
commit 47c6048d53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spec/unit/android_sdk.spec.js
View File

@ -45,16 +45,14 @@ describe('android_sdk', () => {
describe('print_newest_available_sdk_target', () => {
it('should log the newest version', () => {
const sortedIds = ['android-27', 'android-24', 'android-23', 'android-19'];
const logSpy = jasmine.createSpy('log');
spyOn(android_sdk, 'list_targets').and.returnValue(Promise.resolve(sortedIds));
spyOn(sortedIds, 'sort');
android_sdk.__set__({ console: { log: logSpy } });
spyOn(console, 'log');
return android_sdk.print_newest_available_sdk_target().then(() => {
expect(sortedIds.sort).toHaveBeenCalledWith(android_sdk.__get__('sort_by_largest_numerical_suffix'));
expect(logSpy).toHaveBeenCalledWith(sortedIds[0]);
expect(console.log).toHaveBeenCalledWith(sortedIds[0]);
});
});
});

6
spec/unit/run.spec.js
View File

@ -200,9 +200,7 @@ describe('run', () => {
describe('help', () => {
it('should print out usage and help', () => {
const logSpy = jasmine.createSpy();
const errorSpy = jasmine.createSpy();
run.__set__({ console: { log: logSpy, error: errorSpy } });
spyOn(console, 'log');
// Rewiring the process object in entirety does not work on NodeJS 12.
// Rewiring members of process however does work
@ -213,7 +211,7 @@ describe('run', () => {
run.__set__('process.argv', ['', '']);
run.help();
expect(logSpy).toHaveBeenCalledWith(jasmine.stringMatching(/^Usage:/));
expect(console.log).toHaveBeenCalledWith(jasmine.stringMatching(/^Usage:/));
});
});
});