github/cordova-android
github/cordova-android
3
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2025-02-20 23:56:20 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add a whitelist to PluginManager to be used by App Harness

Browse Source 
App Harness needs a way to restrict which plugins get loaded for
embedded apps. This seemed like the simplest way, although a better
API would be to have PluginManager recieve the list of PluginEntry.
This commit is contained in:
Andrew Grieve 2014-06-20 12:32:53 -04:00
parent 8ac067da89
commit 98246c0e35
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
framework/src/org/apache/cordova/PluginManager.java
View File

@ -23,6 +23,7 @@ import java.util.ArrayList;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Set;
import java.util.concurrent.atomic.AtomicInteger;
import org.apache.cordova.CordovaArgs;
@ -37,7 +38,6 @@ import org.xmlpull.v1.XmlPullParserException;
import android.content.Intent;
import android.content.res.XmlResourceParser;
import android.net.Uri;
import android.os.Debug;
import android.util.Log;
@ -66,6 +66,8 @@ public class PluginManager {
protected HashMap<String, List<String>> urlMap = new HashMap<String, List<String>>();
private AtomicInteger numPendingUiExecs;
private Set<String> pluginIdWhitelist;
/**
* Constructor.
@ -79,6 +81,10 @@ public class PluginManager {
this.firstRun = true;
this.numPendingUiExecs = new AtomicInteger(0);
}
public void setPluginIdWhitelist(Set<String> pluginIdWhitelist) {
this.pluginIdWhitelist = pluginIdWhitelist;
}
/**
* Init when loading a new HTML page into webview.
@ -192,7 +198,9 @@ public class PluginManager {
public void startupPlugins() {
for (PluginEntry entry : this.entries.values()) {
if (entry.onload) {
entry.createPlugin(this.app, this.ctx);
if (pluginIdWhitelist == null || pluginIdWhitelist.contains(entry.service)) {
entry.createPlugin(this.app, this.ctx);
}
}
}
}
@ -278,7 +286,11 @@ public class PluginManager {
}
CordovaPlugin plugin = entry.plugin;
if (plugin == null) {
plugin = entry.createPlugin(this.app, this.ctx);
if (pluginIdWhitelist == null || pluginIdWhitelist.contains(entry.service)) {
plugin = entry.createPlugin(this.app, this.ctx);
} else {
Log.e(TAG, "Attempted to access non-whitelisted plugin: " + entry.service);
}
}
return plugin;
}