github/cordova-android
github/cordova-android
3
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2025-01-31 09:02:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

cleanup!: remove deprecated settings & add todo comments (#1274)

Browse Source 
* chore: add todo task for setSaveFormData
* cleanup!: remove deprecated setSavePassword
* cleanup!: remove deprecated setDatabasePath
* chore: add todo task for setGeolocationDatabasePath
This commit is contained in:
エリス 2021-07-14 15:37:12 +09:00 committed by GitHub
parent 7da531ced5
commit adc380cf9f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
View File

@ -155,9 +155,9 @@ public class SystemWebViewEngine implements CordovaWebViewEngine {
String manufacturer = android.os.Build.MANUFACTURER; String manufacturer = android.os.Build.MANUFACTURER;
LOG.d(TAG, "CordovaWebView is running on device made by: " + manufacturer); LOG.d(TAG, "CordovaWebView is running on device made by: " + manufacturer);
//We don't save any form data in the application // We don't save any form data in the application
// @todo remove when Cordova drop API level 26 support
settings.setSaveFormData(false); settings.setSaveFormData(false);
settings.setSavePassword(false);
if (preferences.getBoolean("AndroidInsecureFileModeEnabled", false)) { if (preferences.getBoolean("AndroidInsecureFileModeEnabled", false)) {
//These settings are deprecated and loading content via file:// URLs is generally discouraged, //These settings are deprecated and loading content via file:// URLs is generally discouraged,
@ -173,8 +173,6 @@ public class SystemWebViewEngine implements CordovaWebViewEngine {
// We keep this disabled because we use or shim to get around DOM_EXCEPTION_ERROR_16 // We keep this disabled because we use or shim to get around DOM_EXCEPTION_ERROR_16
String databasePath = webView.getContext().getApplicationContext().getDir("database", Context.MODE_PRIVATE).getPath(); String databasePath = webView.getContext().getApplicationContext().getDir("database", Context.MODE_PRIVATE).getPath();
settings.setDatabaseEnabled(true); settings.setDatabaseEnabled(true);
settings.setDatabasePath(databasePath);
//Determine whether we're in debug or release mode, and turn on Debugging! //Determine whether we're in debug or release mode, and turn on Debugging!
ApplicationInfo appInfo = webView.getContext().getApplicationContext().getApplicationInfo(); ApplicationInfo appInfo = webView.getContext().getApplicationContext().getApplicationInfo();
@ -182,6 +180,7 @@ public class SystemWebViewEngine implements CordovaWebViewEngine {
enableRemoteDebugging(); enableRemoteDebugging();
} }
// @todo remove when Cordova drop API level 24 support
settings.setGeolocationDatabasePath(databasePath); settings.setGeolocationDatabasePath(databasePath);
// Enable DOM storage // Enable DOM storage