github/cordova-android
github/cordova-android
3
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2025-01-19 15:12:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use /app_webview/ rather than app_webview to filter bad requests

Browse Source
This commit is contained in:
Ian Clelland 2014-10-30 12:17:05 -04:00
parent ac1f9c790a
commit c8f44ab460
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
framework/src/org/apache/cordova/CordovaUriHelper.java
View File

@ -49,12 +49,12 @@ public class CordovaUriHelper {
Boolean pluginManagerAllowsNavigation = this.appView.getPluginManager().shouldAllowNavigation(url); Boolean pluginManagerAllowsNavigation = this.appView.getPluginManager().shouldAllowNavigation(url);
if (pluginManagerAllowsNavigation == null) { if (pluginManagerAllowsNavigation == null) {
// Default policy: // Default policy:
// Internal urls on file:// or data:// that do not contain "app_webview" are allowed for navigation // Internal urls on file:// or data:// that do not contain "/app_webview/" are allowed for navigation
if(url.startsWith("file://") || url.startsWith("data:")) if(url.startsWith("file://") || url.startsWith("data:"))
{ {
//This directory on WebKit/Blink based webviews contains SQLite databases! //This directory on WebKit/Blink based webviews contains SQLite databases!
//DON'T CHANGE THIS UNLESS YOU KNOW WHAT YOU'RE DOING! //DON'T CHANGE THIS UNLESS YOU KNOW WHAT YOU'RE DOING!
return !url.contains("app_webview"); return !url.contains("/app_webview/");
} }
return false; return false;
} }
@ -88,12 +88,12 @@ public class CordovaUriHelper {
Boolean pluginManagerAllowsRequest = this.appView.getPluginManager().shouldAllowRequest(url); Boolean pluginManagerAllowsRequest = this.appView.getPluginManager().shouldAllowRequest(url);
if (pluginManagerAllowsRequest == null) { if (pluginManagerAllowsRequest == null) {
// Default policy: // Default policy:
// Internal urls on file:// or data:// that do not contain "app_webview" are allowed for navigation // Internal urls on file:// or data:// that do not contain "/app_webview/" are allowed for navigation
if(url.startsWith("file://") || url.startsWith("data:")) if(url.startsWith("file://") || url.startsWith("data:"))
{ {
//This directory on WebKit/Blink based webviews contains SQLite databases! //This directory on WebKit/Blink based webviews contains SQLite databases!
//DON'T CHANGE THIS UNLESS YOU KNOW WHAT YOU'RE DOING! //DON'T CHANGE THIS UNLESS YOU KNOW WHAT YOU'RE DOING!
return !url.contains("app_webview"); return !url.contains("/app_webview/");
} }
return false; return false;
} }