Fabian Te
54df4a116c
Add missing log to Java version check ( #624 )
...
* Add missing log to Java version check
* Simplify version check output
Resolves #623
2019-01-27 10:52:22 -05:00
Keith Lord
715ce2f9ac
Update emulator.js to fix issue #608 ( #630 )
...
Fixes "Device still authorizing issue" #608 (https://github.com/apache/cordova-android/issues/608 )
Resolves #608
2019-01-18 15:24:28 -05:00
Chris Brody
d9c08f12a7
Fix requirements error messages for JDK 8 ( #620 )
2019-01-17 10:13:00 -05:00
Chris Brody
e41fbc5708
javac error message fixes in requirements check ( #619 )
...
- fix download link
- put download link on its own line
- no punctuation at the end of the download link
(fixes #618 )
- no extra newline at the end
- extra newline spacing in case JAVA_HOME is invalid
2019-01-16 22:51:45 -05:00
エリス
39bd0d6463
Bumped Dev Dependencies + ESLint Correction
2019-01-15 21:57:08 -08:00
エリス
f228d90ca2
Copy node_modules if the directory exists ( #607 )
2018-12-19 10:33:16 +09:00
Jule-
8a4ae311ce
Rewrite install dir resolution for legacy plugins ( #589 )
...
* Improve target-dir restriction for detecting new android project structure used in plugin.xml. (#575 )
* Clarify old source-file declaration way from the new one and improve ambiguous code.
* Better check `src/main` forms.
* Replace path search with RegExp vars.
* Fix RegExp in order to match `/` or `EOL`.
* Remove template strings for NodeJS 4 support (wanted in case we port these changes to `7.1.x` at some point).
* Add pointer to deprecation plan in GH-580.
2018-11-28 06:46:45 -05:00
Chris Brody
ef2434188e
Resolve issue with plugin target-dir="app*" subdirs ( #572 )
...
(subdirectories) such as "appco", with unit tests to verify
Needed for @katzer plugins that use de/appplant subdirectory,
for example:
* cordova-plugin-local-notifications
* cordova-plugin-badge
* cordova-plugin-background-mode
Also needed for cordova-plugin-inappbrowser
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Julio César <jcesarmobile@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
2018-11-22 08:59:33 -05:00
Jan Piotrowski
a014228f7c
Output current package name if package name can't be validated
...
We have this of the package name. It only outputs that the current one is bad, not what the current one actually is. Added an output of the current one to the error.
2018-11-20 21:54:55 -08:00
Darryl Pogue
f1f1ac3cbd
Updates for latest gradle/build tools
...
Ref GH-504.
2018-11-20 21:12:59 -08:00
Chris Brody
21ae48eada
Merge pull request #550 from brodybits/gh-547-bugfix
...
Fix for old plugins with non-Java sources (GH-547)
2018-11-14 17:44:31 -05:00
Christopher J. Brody
53e1c1b65c
Set version & VERSION to 8.0.0-dev (coho)
2018-11-14 15:37:22 -05:00
Christopher J. Brody
858611f95e
Update JS to version 8.0.0-dev (via coho)
2018-11-14 15:37:22 -05:00
Christopher J. Brody
5c334b6c10
CB-9366 cordova.js log error.stack (cordova-js@4.2.4)
...
(Update cordova.js from cordova-js@4.2.4, using coho copy-js)
2018-11-14 15:30:26 -05:00
Christopher J. Brody
cf5a02ea0f
Update cordova.js from cordova-js@4.2.3
...
using coho copy-js
with the following change from cordova-js-src:
* Remove obsolete check for JellyBean to work properly on Android Pie
(GH-534)
2018-11-14 15:24:48 -05:00
Christopher J. Brody
a67bc75b93
GH-547 Fix for old plugins with non-Java sources
...
(source-file entries)
including aidl, aar, jar, and so files
2018-11-14 13:19:58 -05:00
Christopher J. Brody
895ab0c970
Fix comments in getInstallDestination
...
(in pluginHandlers.js)
2018-11-14 11:40:33 -05:00
Christopher J. Brody
21f84732c8
Cleanup getInstallDestination in pluginHandlers.js
2018-11-14 11:38:39 -05:00
David Boho
7eed65e9b4
GH-552 (android) check for build-extras.gradle in the app-parent directory ( #553 )
...
as documented in https://cordova.apache.org/docs/en/latest/guide/platforms/android/?#extending-buildgradle
and deal with multiple build-extras.gradle locations
Co-authored-by: David Boho <david.boho@tu-ilmenau.de>
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
2018-11-14 08:00:36 -05:00
David Boho
a4caa87d29
add missing cast for cdvMinSdkVersion
2018-11-14 06:18:53 +01:00
Christopher J. Brody
ef493b4c0f
GH-540 fix for source-file with app target-dir
2018-11-11 15:26:04 -05:00
Christopher J. Brody
c2f6631f91
GH-539 fix destination path fallback
...
Fallback to old path mapping if no Android Studio path mapping exists
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Kyle Kirbatski <kkirbatski@gmrmarketing.com>
2018-11-11 15:16:19 -05:00
エリス
98c866704a
Only copy platform node_modules when create by bin
2018-11-06 16:08:34 +09:00
Darryl Pogue
e58453d3e6
Merge pull request #465 from erisu/CB-14201
...
CB-14201: (android) Removes Gradle property in-line command arguments…
2018-10-31 21:25:26 -07:00
Darryl Pogue
8dfddef6f9
Merge pull request #486 from jedrivisser/7.1.x
...
GH-485: (android) Replace deprecated "compile" with "implementation"
2018-09-25 22:30:46 -07:00
Chris Brody
73edf4de7b
Update comments ( #496 )
...
as followup to GH-495
2018-09-12 07:52:11 -04:00
Darshan-Chauhan
905bff3d59
Incorrect default sdk version issue fix
2018-09-12 15:34:00 +05:30
Jedri Visser
e3eb933182
GH-485: (android) Change deprecated "compile" to "implementation"
2018-09-06 22:54:26 +02:00
エリス
dacb0e5c72
CB-14201: (android) Removes Gradle property in-line command arguments for gradle.properties
2018-09-06 14:16:05 +09:00
エリス
23b24491c3
Fixes build & run related bugs from builder refactor PR #461 ( #490 )
...
- General Code Refactor
- Removed builder type argument from getBuilder API
- Removed any reference of conditional statements around builder type
- Remove plugin handler install and uninstall option flag android_studio
- Remove --gradle flag references
- Fixed plugin handler install and uninstall pathing issues
- Added parseBuildOptions export so run can get build related options.
- Use the nobuild flag option to control the run build.
- Updated test spec to reflect the changes.
2018-09-06 11:06:18 +09:00
Gearóid
7ab0cf123d
Unit tests for android_sdk and AndroidProject ( #464 )
...
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This is the last unit test PR for today, I promise! The `AndroidProject` tests were originally in #458 . This PR also contains increased test coverage for `android_sdk.js`. I have also refactored that to remove `Q`, as with the other PRs I submitted today.
### What testing has been done on this change?
Run unit tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html ) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
2018-09-02 04:44:37 +02:00
エリス
8f2a4c7231
CB-13685 android: Adaptive Icon Support
...
- Update default project template's icons to be adaptive.
- Added backwards support for non-adaptive icon supported devices.
2018-08-29 10:13:14 -07:00
Raphael von der Grün
ebbd91f87d
Merge pull request #461 from Menardi/refactor_builders_with_tests
...
Remove old builders code
2018-07-21 16:43:34 +02:00
Gearoid M
4b0725dfc2
Remove no longer needed AndroidStudio.js
2018-07-10 11:53:52 +09:00
Gearoid M
350d35fb24
Refactor ProjectBuilder to use class instead of prototype
2018-07-10 11:53:52 +09:00
Gearoid M
8ee3a73dd1
Remove unused builders and add unit tests
2018-07-10 11:53:52 +09:00
Darryl Pogue
b6e4598e7c
Merge pull request #463 from Menardi/emulator_tests
...
Emulator: Add unit tests and remove Q
2018-07-02 21:21:43 -07:00
Gearoid M
1ea7c1366a
CB-14158: Refactor emulator to remove Q
2018-07-03 11:19:17 +09:00
Gearoid M
bd07907a4c
CB-14158: Refactor device to remove Q
2018-07-03 10:43:30 +09:00
Rizal M. S
46a036ef26
CB-14165 Emulator: handle "device still connecting" error ( #457 )
...
Keep waiting for emulator when connection fails with "device still connecting" error
2018-06-25 08:44:37 +02:00
Gearoid M
1a8154c90e
Fix unsafe property access
2018-06-20 13:24:50 +02:00
Gearoid M
8fb49ec7ec
Fix typo in variable name in retry.js
2018-06-20 13:24:50 +02:00
Raphael von der Grün
393dad6349
Lint JS files w/out extension too ( #453 )
...
Prior to this change, JS files without extension had not been linted.
To match them, we need a combination of positive and negative globbing
that does not mix well with the existing file selection for linting. Thus, we use
npm-run-all to run two ESLint invocations unconditionally in sequence
while still preserving the error code.
* Lint JS w/out extension too
* Fix newly surfaced linting errors
* Make use of npm-run-all for test script too
2018-06-18 23:48:02 +02:00
Raphael von der Grün
2c3db19310
Emit log event instead of logging directly
2018-06-16 20:08:44 +02:00
jcesarmobile
472ab626d6
Merge pull request #449 from jcesarmobile/CB-14125
...
CB-14125:(android) Increase old plugin compatibility
2018-06-13 23:00:55 +02:00
Raphael von der Grün
bf29fe0e10
CB-14101 Fix Java version check for Java >= 9 ( #446 )
...
This also checks that we have exactly 1.8 since nothing else works with
the Android SDK. The user facing error was updated accordingly.
2018-06-12 22:18:55 +02:00
Julio César
38d0e684f1
CB-14127: (android) Move google maven repo ahead of jcenter
2018-06-11 23:12:58 +02:00
Julio César
83e9aefff5
CB-14125:(android) Increase old plugin compatibility
2018-06-11 00:48:24 +02:00
Raphael von der Grün
02ee925103
Remove obsolete jshint comments ( #444 )
2018-05-21 18:02:14 +08:00
Julio César
fe7629e8fc
CB-14038 (android): fix false positive detecting project type
2018-04-18 13:52:04 +02:00
Joe Bowser
5c4f8ca246
CB-14008: Updating Gradle Libraries to work with Android Studio 3.1.0
2018-04-04 13:54:39 -07:00
Joe Bowser
5af6b016c1
CB-13830: Add handlers for plugins that use non-Java source files, such as Camera
2018-03-19 13:20:09 -07:00
Steve Gill
eddad666ff
Update JS snapshot to version 7.2.0-dev (via coho)
2018-02-21 10:52:02 -08:00
Steve Gill
ca9a25e860
Set VERSION to 7.2.0-dev (via coho)
2018-02-21 10:52:01 -08:00
Simon MacDonald
3a339ba37f
⬆️ Bump gradle tools dependency to 3.0.1 for project template
2018-02-15 17:42:10 -05:00
sunday18
8563c8beef
Update android_sdk.js
...
Update `android_sdk.js` to support Android Oreo (API 26) emulator
2018-01-26 06:21:53 +00:00
Joe Bowser
6cc4896690
Merge pull request #426 from infil00p/api_level_bump
...
CB-13724: Bump Target SDK to API 27
2018-01-17 11:48:51 -08:00
Joe Bowser
3a6923988d
CB-13646: End of an era. Using the deprecated NDK by default breaks the build. Crosswalk users need to specify the Gradle parameters to keep it working.
2018-01-08 14:52:46 -08:00
Joe Bowser
0d1692681f
CB-13724: Updated the Android Tooling required for the latest version on both the test project, and the template
2018-01-04 15:35:04 -08:00
Joe Bowser
5c93c214b9
CB-13724: Bump Target SDK to API 27
2018-01-02 14:38:03 -08:00
Chris Alfano
109112ae75
CB-13571: (android) Prevent crash with unrecognized android version
...
Fixes issue where commands that list images will crash when an image with a version not present in `android-versions` is encountered, as is presently the case with API 27:
```
cordova run android --list
Available android devices:
Available android virtual devices:
LEVEL: null
ERROR: TypeError: Cannot read property 'semver' of null
An unexpected error has occured while running list-emulator-images with code 2: Error: /home/chris/Repositories/acp-guidelines/cordova/platforms/android/cordova/lib/list-emulator-images: Command failed with exit code 2
```
Signed-off-by: Chris Alfano <chris@jarv.us>
2017-12-22 15:56:26 -05:00
Joe Bowser
74e9e213d6
Forgot to bump AndroidManifest.xml for play store reasons
2017-12-12 12:49:54 -08:00
Joe Bowser
d8d92cae61
CB-13621: eslint error
2017-11-30 11:08:39 -08:00
Joe Bowser
52fd32c837
CB-13621: Wrote similar warning to CB-12948 on iOS. We no longer support update.
2017-11-30 10:40:07 -08:00
Joe Bowser
061f08bc03
Update JS snapshot to version 7.1.0-dev (via coho)
2017-11-30 10:01:30 -08:00
Joe Bowser
735bc98243
Set VERSION to 7.1.0-dev (via coho)
2017-11-30 10:01:28 -08:00
Darryl Pogue
8484f7b906
CB-13615: Fix paths to signing properties files
2017-11-29 10:56:05 -08:00
Joe Bowser
c6cfeb15f4
Fixed typo in the gradle file
2017-11-28 14:59:50 -08:00
Joe Bowser
adc7dab377
CB-13612: eslint fix
2017-11-28 13:09:07 -08:00
Joe Bowser
a9e01f4309
CB-13612: Fix the remapper so that XML files copy over and the Camera works again.
2017-11-28 12:57:00 -08:00
Joe Bowser
4863320e45
Merge branch 'master' into StudioProjectCompat
2017-11-28 10:35:45 -08:00
Darryl Pogue
9056e5a2dc
CB-13610: Compress the default app assets
2017-11-27 22:46:02 -08:00
Joe Bowser
2b20802dbb
Merge branch 'master' into StudioProjectCompat
...
Merge by hand CB-8976
2017-11-27 14:10:59 -08:00
Joe Bowser
a972d1ef62
Merge pull request #401 from fabulant/CB-8976
...
CB-8976: Added the `cdvVersionCodeForceAbiDigit` property
2017-11-27 14:02:20 -08:00
Joe Bowser
30c3713dca
Merge branch 'master' into StudioProjectCompat
2017-11-27 11:42:25 -08:00
Joe Bowser
6f58d4c474
Merge pull request #352 from Icenium/include-armeabi-dir
...
CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors
2017-11-27 11:35:47 -08:00
Joe Bowser
9d9bac397b
CB-13602: We were setting the path wrong, this is hacky but it works
2017-11-22 13:18:38 -08:00
Joe Bowser
d8f10c33dc
CB-13601: Fixing lint error and mis-spelling of variable
2017-11-22 11:47:05 -08:00
Joe Bowser
5d57eff612
CB-13601: Fixing the standalone run scripts to make sure this works without using the CLI
2017-11-22 11:39:40 -08:00
Joe Bowser
43956c1bc8
Merge branch 'master' into StudioProjectCompat
...
Fixing conflict caused by merging #417 into master
2017-11-20 18:21:49 -08:00
David Strauß
5d99e50c4a
CB-13580: (android) fix lint errors
2017-11-16 01:54:04 +01:00
David Strauß
aaeb630eb1
CB-13580: fix build for multiple apks (different product flavors)
2017-11-16 01:27:20 +01:00
Joe Bowser
3acba59494
CB-13297: This just works once you bump the project structure. Java 1.8 compatibility baked-in
2017-11-15 11:39:32 -08:00
Joe Bowser
b77febc7a7
Merge branch 'master' into StudioProjectCompat
2017-11-07 10:52:37 -08:00
Joe Bowser
83601dca2f
Update JS snapshot to version 6.5.0-dev (via coho)
2017-11-06 11:44:23 -08:00
Joe Bowser
05aeaf1bd2
Set VERSION to 6.5.0-dev (via coho)
2017-11-06 11:44:20 -08:00
Joe Bowser
b83c3b3684
CB-13530: Removing debug console.logs
2017-11-02 14:45:51 -07:00
Joe Bowser
5502ddaf0d
CB-13530: This fixes the basic APK installation
2017-11-02 14:42:39 -07:00
Joe Bowser
f54336eb61
eslint fix
2017-11-01 17:18:41 -07:00
Joe Bowser
18d6884522
CB-11244: Android Studio 3 work, things have changed with how the platform is built
2017-11-01 17:09:00 -07:00
Joe Bowser
8ba0109e55
Completing merge which includes the fix for Android Studio 3.0
2017-11-01 13:46:23 -07:00
Joe Bowser
f50ca85a95
CB-11244: Found bug where the gradle subproject changes weren't actually getting written to the correct gradle file
2017-11-01 13:22:22 -07:00
Joe Bowser
39e6765e64
Merge pull request #413 from infil00p/StudioThreeFix
...
CB-13289: This fixes the Cordova-Android build on cordova-android 6.x
2017-11-01 10:26:53 -07:00
Joe Bowser
a2618dcde5
CB-13289: eslint fix
2017-10-30 13:17:18 -07:00
Joe Bowser
9fdb126715
CB-13289: Fixing build problems with Studio Three, but keeping Windows Gradle fix for now, will be deprecated
2017-10-30 10:39:59 -07:00
Jan Piotrowski
04fa5d3feb
CB-13499: Remove duplicate "setting" in error strings
2017-10-26 22:28:38 +02:00
Joe Bowser
3ba00f91bb
eslint errors
2017-10-19 13:37:43 -07:00
Joe Bowser
cbee8580d0
CB-13470: Fix Clean so that it cleans the Android Studio structure
2017-10-19 13:31:16 -07:00
Joe Bowser
6ccd6b009b
Redoing PR #411 over here because the changes were obliterated from earlier
2017-10-18 11:09:08 -07:00
Joe Bowser
6cf6e20d2e
Merge branch 'master' into StudioProjectCompat, fixing conflicts, need
...
to re-add previous PR fix on the branch
2017-10-18 11:04:44 -07:00