エリス
dacb0e5c72
CB-14201: (android) Removes Gradle property in-line command arguments for gradle.properties
2018-09-06 14:16:05 +09:00
エリス
23b24491c3
Fixes build & run related bugs from builder refactor PR #461 ( #490 )
...
- General Code Refactor
- Removed builder type argument from getBuilder API
- Removed any reference of conditional statements around builder type
- Remove plugin handler install and uninstall option flag android_studio
- Remove --gradle flag references
- Fixed plugin handler install and uninstall pathing issues
- Added parseBuildOptions export so run can get build related options.
- Use the nobuild flag option to control the run build.
- Updated test spec to reflect the changes.
2018-09-06 11:06:18 +09:00
Gearóid
7ab0cf123d
Unit tests for android_sdk and AndroidProject ( #464 )
...
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This is the last unit test PR for today, I promise! The `AndroidProject` tests were originally in #458 . This PR also contains increased test coverage for `android_sdk.js`. I have also refactored that to remove `Q`, as with the other PRs I submitted today.
### What testing has been done on this change?
Run unit tests
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html ) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
2018-09-02 04:44:37 +02:00
エリス
8f2a4c7231
CB-13685 android: Adaptive Icon Support
...
- Update default project template's icons to be adaptive.
- Added backwards support for non-adaptive icon supported devices.
2018-08-29 10:13:14 -07:00
Raphael von der Grün
ebbd91f87d
Merge pull request #461 from Menardi/refactor_builders_with_tests
...
Remove old builders code
2018-07-21 16:43:34 +02:00
Gearoid M
4b0725dfc2
Remove no longer needed AndroidStudio.js
2018-07-10 11:53:52 +09:00
Gearoid M
350d35fb24
Refactor ProjectBuilder to use class instead of prototype
2018-07-10 11:53:52 +09:00
Gearoid M
8ee3a73dd1
Remove unused builders and add unit tests
2018-07-10 11:53:52 +09:00
Darryl Pogue
b6e4598e7c
Merge pull request #463 from Menardi/emulator_tests
...
Emulator: Add unit tests and remove Q
2018-07-02 21:21:43 -07:00
Gearoid M
1ea7c1366a
CB-14158: Refactor emulator to remove Q
2018-07-03 11:19:17 +09:00
Gearoid M
bd07907a4c
CB-14158: Refactor device to remove Q
2018-07-03 10:43:30 +09:00
Rizal M. S
46a036ef26
CB-14165 Emulator: handle "device still connecting" error ( #457 )
...
Keep waiting for emulator when connection fails with "device still connecting" error
2018-06-25 08:44:37 +02:00
Gearoid M
1a8154c90e
Fix unsafe property access
2018-06-20 13:24:50 +02:00
Gearoid M
8fb49ec7ec
Fix typo in variable name in retry.js
2018-06-20 13:24:50 +02:00
Raphael von der Grün
393dad6349
Lint JS files w/out extension too ( #453 )
...
Prior to this change, JS files without extension had not been linted.
To match them, we need a combination of positive and negative globbing
that does not mix well with the existing file selection for linting. Thus, we use
npm-run-all to run two ESLint invocations unconditionally in sequence
while still preserving the error code.
* Lint JS w/out extension too
* Fix newly surfaced linting errors
* Make use of npm-run-all for test script too
2018-06-18 23:48:02 +02:00
Raphael von der Grün
2c3db19310
Emit log event instead of logging directly
2018-06-16 20:08:44 +02:00
jcesarmobile
472ab626d6
Merge pull request #449 from jcesarmobile/CB-14125
...
CB-14125:(android) Increase old plugin compatibility
2018-06-13 23:00:55 +02:00
Raphael von der Grün
bf29fe0e10
CB-14101 Fix Java version check for Java >= 9 ( #446 )
...
This also checks that we have exactly 1.8 since nothing else works with
the Android SDK. The user facing error was updated accordingly.
2018-06-12 22:18:55 +02:00
Julio César
38d0e684f1
CB-14127: (android) Move google maven repo ahead of jcenter
2018-06-11 23:12:58 +02:00
Julio César
83e9aefff5
CB-14125:(android) Increase old plugin compatibility
2018-06-11 00:48:24 +02:00
Raphael von der Grün
02ee925103
Remove obsolete jshint comments ( #444 )
2018-05-21 18:02:14 +08:00
Julio César
fe7629e8fc
CB-14038 (android): fix false positive detecting project type
2018-04-18 13:52:04 +02:00
Joe Bowser
5c4f8ca246
CB-14008: Updating Gradle Libraries to work with Android Studio 3.1.0
2018-04-04 13:54:39 -07:00
Joe Bowser
5af6b016c1
CB-13830: Add handlers for plugins that use non-Java source files, such as Camera
2018-03-19 13:20:09 -07:00
Steve Gill
ca9a25e860
Set VERSION to 7.2.0-dev (via coho)
2018-02-21 10:52:01 -08:00
sunday18
8563c8beef
Update android_sdk.js
...
Update `android_sdk.js` to support Android Oreo (API 26) emulator
2018-01-26 06:21:53 +00:00
Joe Bowser
3a6923988d
CB-13646: End of an era. Using the deprecated NDK by default breaks the build. Crosswalk users need to specify the Gradle parameters to keep it working.
2018-01-08 14:52:46 -08:00
Chris Alfano
109112ae75
CB-13571: (android) Prevent crash with unrecognized android version
...
Fixes issue where commands that list images will crash when an image with a version not present in `android-versions` is encountered, as is presently the case with API 27:
```
cordova run android --list
Available android devices:
Available android virtual devices:
LEVEL: null
ERROR: TypeError: Cannot read property 'semver' of null
An unexpected error has occured while running list-emulator-images with code 2: Error: /home/chris/Repositories/acp-guidelines/cordova/platforms/android/cordova/lib/list-emulator-images: Command failed with exit code 2
```
Signed-off-by: Chris Alfano <chris@jarv.us>
2017-12-22 15:56:26 -05:00
Joe Bowser
735bc98243
Set VERSION to 7.1.0-dev (via coho)
2017-11-30 10:01:28 -08:00
Joe Bowser
adc7dab377
CB-13612: eslint fix
2017-11-28 13:09:07 -08:00
Joe Bowser
a9e01f4309
CB-13612: Fix the remapper so that XML files copy over and the Camera works again.
2017-11-28 12:57:00 -08:00
Joe Bowser
9d9bac397b
CB-13602: We were setting the path wrong, this is hacky but it works
2017-11-22 13:18:38 -08:00
Joe Bowser
d8f10c33dc
CB-13601: Fixing lint error and mis-spelling of variable
2017-11-22 11:47:05 -08:00
Joe Bowser
5d57eff612
CB-13601: Fixing the standalone run scripts to make sure this works without using the CLI
2017-11-22 11:39:40 -08:00
Joe Bowser
43956c1bc8
Merge branch 'master' into StudioProjectCompat
...
Fixing conflict caused by merging #417 into master
2017-11-20 18:21:49 -08:00
David Strauß
5d99e50c4a
CB-13580: (android) fix lint errors
2017-11-16 01:54:04 +01:00
David Strauß
aaeb630eb1
CB-13580: fix build for multiple apks (different product flavors)
2017-11-16 01:27:20 +01:00
Joe Bowser
b77febc7a7
Merge branch 'master' into StudioProjectCompat
2017-11-07 10:52:37 -08:00
Joe Bowser
05aeaf1bd2
Set VERSION to 6.5.0-dev (via coho)
2017-11-06 11:44:20 -08:00
Joe Bowser
b83c3b3684
CB-13530: Removing debug console.logs
2017-11-02 14:45:51 -07:00
Joe Bowser
5502ddaf0d
CB-13530: This fixes the basic APK installation
2017-11-02 14:42:39 -07:00
Joe Bowser
f54336eb61
eslint fix
2017-11-01 17:18:41 -07:00
Joe Bowser
18d6884522
CB-11244: Android Studio 3 work, things have changed with how the platform is built
2017-11-01 17:09:00 -07:00
Joe Bowser
8ba0109e55
Completing merge which includes the fix for Android Studio 3.0
2017-11-01 13:46:23 -07:00
Joe Bowser
f50ca85a95
CB-11244: Found bug where the gradle subproject changes weren't actually getting written to the correct gradle file
2017-11-01 13:22:22 -07:00
Joe Bowser
39e6765e64
Merge pull request #413 from infil00p/StudioThreeFix
...
CB-13289: This fixes the Cordova-Android build on cordova-android 6.x
2017-11-01 10:26:53 -07:00
Joe Bowser
a2618dcde5
CB-13289: eslint fix
2017-10-30 13:17:18 -07:00
Joe Bowser
9fdb126715
CB-13289: Fixing build problems with Studio Three, but keeping Windows Gradle fix for now, will be deprecated
2017-10-30 10:39:59 -07:00
Jan Piotrowski
04fa5d3feb
CB-13499: Remove duplicate "setting" in error strings
2017-10-26 22:28:38 +02:00
Joe Bowser
3ba00f91bb
eslint errors
2017-10-19 13:37:43 -07:00
Joe Bowser
cbee8580d0
CB-13470: Fix Clean so that it cleans the Android Studio structure
2017-10-19 13:31:16 -07:00
Joe Bowser
6cf6e20d2e
Merge branch 'master' into StudioProjectCompat, fixing conflicts, need
...
to re-add previous PR fix on the branch
2017-10-18 11:04:44 -07:00
filmaj
1f12fdbeea
CB-13404: add android-versions to bundledDependencies. Ignore best emulator selection when parsed AVD information does not include API level in the target
2017-10-05 15:17:31 -05:00
Joe Bowser
8743e88550
CB-11244: Fixing eslint errors
2017-10-03 15:06:54 -07:00
Joe Bowser
f3c238db1c
CB-11244: Adding specs for resource files inside an Android Studio Project
2017-10-03 14:16:27 -07:00
Joe Bowser
2534a3c767
CB-11244: Added remapping for drawables
2017-10-02 19:04:40 -07:00
Joe Bowser
b1f527e682
Merge branch 'master' into StudioProjectCompat
2017-09-28 10:21:49 -07:00
Joe Bowser
0e498db735
Set VERSION to 6.4.0-dev (via coho)
2017-09-25 11:37:51 -07:00
Joe Bowser
7d282426c4
Merge branch 'master' into StudioProjectCompat
...
Another merge commit to track master changes
2017-09-14 11:45:57 -07:00
filmaj
1637937664
CB-12981: handle SDK 26.0.2 slightly different AVD list output for Android 8+ AVDs. Would cause "cannot read property replace of undefined" errors when trying to deploy an Android 8 emulator.
2017-09-14 11:26:18 -07:00
filmaj
03144eb160
Add a node and npm package.json script for running java unit tests. Include them in the top-level npm test
script. Run java unit tests in travis. Small refactor in gradlebuilder to support building gradle wrapper more easily. Don't explicitly build gradlew on appveyor CI as now npm test
will do it for you.
2017-09-14 09:57:37 -07:00
Gil Pedersen
cb2f396e33
Update maven repo to include most recent lib versions
2017-08-29 17:27:02 +02:00
Joe Bowser
8fdb16c555
Fixing cordova-cli related bug
2017-08-04 12:00:39 -07:00
Joe Bowser
e91b19d006
Fixing error caused by merge commit
2017-07-31 14:10:14 -07:00
Joe Bowser
46905ebe99
Merge branch 'master' into StudioProjectCompat. Dealing with latest
...
commits merged into master.
2017-07-31 13:43:21 -07:00
Nikita Matrosov
2b53c98cf5
CB-12453: Remove unnecessary double quotes from .bat files which are the causes of crash if project path contains spaces
...
this closes #362
2017-07-28 14:23:53 +03:00
Nikita Matrosov
36d07d7a15
CB-13031: Fix bug with case-sensitivity of android-packageName
...
this closes #397
2017-07-28 14:05:53 +03:00
Joe Bowser
d0dab4bb09
Merge branch 'master' into StudioProjectCompat
...
I fixed the master so it passes eslint.
2017-07-18 14:25:56 -07:00
Joe Bowser
893356abcd
CB-13034: Fixing eslint error
2017-07-18 14:13:53 -07:00
Darryl Pogue
22645d9158
[CB-10916] Support display name for Android
2017-07-14 17:37:15 -02:30
Joe Bowser
245d9a1e46
Merge branch 'master' into StudioProjectCompat
2017-07-12 09:33:37 -07:00
Joe Bowser
a7304b9a19
Finishing the linting
2017-06-27 13:15:04 -07:00
Nikita Matrosov
540929c6a0
CB-9971: Suppressed unwanted java stderr output when running gradle wrapper
...
this closes #388
2017-06-26 21:17:58 +03:00
Joe Bowser
e456175a81
Merge branch 'master' into StudioProjectCompat
...
This will have to be linted
2017-06-26 10:29:31 -07:00
filmaj
3ff32092a3
CB-12954 🔪 remove jshint leftovers
2017-06-26 12:26:53 -05:00
Audrey So
55d7cf3865
CB-12895 : updated .eslintrc file in spec dir and set jasmine true and removed root is true
2017-06-23 08:44:08 -07:00
Audrey So
d83d49d83b
CB-12895 : fixed eslint errors
2017-06-23 08:07:08 -07:00
Joe Bowser
b20028c42b
The prepare step was broken, which breaks the CLI workflow. This was caused by hardcoding the Java directory, which is a very bad idea.
2017-06-22 13:46:18 -07:00
Jesse MacFadyen
5cc14b8031
CB-12605 In Windows get Android studio path from the registry
...
This closes #387
2017-06-22 10:55:39 -07:00
Joe Bowser
1cda7a9de0
CB-11244: Found bug in Api.js where xml/strings.xml is used instead of values/strings.xml
2017-06-19 14:34:03 -07:00
Joe Bowser
49b76f5c71
Fixing mangled commits that crept into this branch
2017-06-14 11:36:43 -07:00
Joe Bowser
fb6cb51e64
Fixing lint errors
2017-06-14 09:57:28 -07:00
Joe Bowser
28ebbb8f02
CB-11244: Setup Api.js to support multiple builders based on project structure
2017-06-14 09:57:28 -07:00
Joe Bowser
bd4ddcdedd
Updated AndroidStudio to only look for the app directory to determine studio status
2017-06-14 09:57:28 -07:00
Joe Bowser
e621edfba7
Fixing the Android Studio detection and making it automatically pick the right builder, good for upgrading Cordova
2017-06-14 09:57:27 -07:00
Joe Bowser
304a899114
Fixed the specification of the builders in the run command by getting build to check what was being passed from run
2017-06-14 09:57:27 -07:00
Joe Bowser
8391af2e8f
JsHint Fixes, deleting unused methods
2017-06-14 09:57:27 -07:00
Joe Bowser
69ab6a0e0d
Changing the project to add the app directory as a dependency
2017-06-14 09:57:27 -07:00
Joe Bowser
69260fb96a
Fix the overwriting of Fil's fix, blargh
2017-06-14 09:57:27 -07:00
Joe Bowser
db87e0ae6a
Made changes so cordova/build builds with the new project. Need to work on plugin installation.
2017-06-14 09:57:26 -07:00
Joe Bowser
23d8d99925
Moving Android Manifest finding to the Gradle and Studio builders.
2017-06-14 09:57:25 -07:00
Joe Bowser
d88df59c32
Adding the Studio Builder to build a project based on Android Studio,
...
and deleting Ant, since Google does not support Ant Builds anymore.
Sorry guys!
2017-06-14 09:57:25 -07:00
Darryl Pogue
7d926822ed
CB-8980: Ensure copied resource-files are cleaned
...
This closes #377
2017-05-25 16:11:20 -07:00
filmaj
9d9abea157
Start of GradleBuilder.js specs - puts it on the code coverage radar.
2017-05-02 15:31:26 -07:00
filmaj
e13e15d3e9
CB-12640: better handling of unrecognized commands on windows. removed error checking in emulator image listing when shelling out, as we already defensively dont shell out if the program is not on the PATH / not recognized. added additional test for windows unrecognized command errors for target listing. fixed up spying in a test.
2017-04-10 12:12:46 -07:00
filmaj
6ef2f67ae8
CB-12640: flipped avd parsing logic so that it always tries to use avdmanager to retrieve avds first, then falls back to android command if avdmanager cannot be found (and errors with ENOENT). updated tests - and added explicit tests to ensure to shell out to singular forms of sub-commands when executing android
2017-04-10 12:12:46 -07:00
filmaj
765c4ee9f6
CB-12640: support for android sdk tools 26.0.1. simplified target parsing by using avdmanager instead of sdkmanager. flipped target parsing logic so that it always tries to use avdmanager to retrieve targets first, then falls back to android command if avdmanager cannot be found (and errors with ENOENT). updated tests.
2017-04-10 12:12:46 -07:00
Steve Gill
13dbd2f5d4
Set VERSION to 6.3.0-dev (via coho)
2017-03-28 15:18:35 -07:00
Darryl Pogue
0df50c3f33
CB-8978 Prepare copy resource-files from config.xml
...
This closes #321
2017-03-27 22:13:13 -07:00
Alexander Sorokin
08c80f77a9
CB-12605 Fix a requirements check failure on Windows
2017-03-27 11:47:32 +03:00