github/cordova-plugin-camera
github/cordova-plugin-camera
3
0
Fork 0
mirror of https://github.com/apache/cordova-plugin-camera.git synced 2025-02-08 02:22:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak of image data in imagePickerControllerReturnImageResult

Browse Source 
A __bridge_retained cast increments the count and requires a CFRelease, this should just be __bridge a cast since it isn’t being held onto by this method.

close #51
This commit is contained in:
Kris Selden 2014-10-09 16:20:52 -07:00 committed by Andrew Grieve
parent 8b8db828f6
commit 0d389857cf
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ios/CDVCamera.m
View File

@ -632,7 +632,7 @@ static NSSet* org_apache_cordova_validArrowDirections;
CDVPluginResult* result = nil; CDVPluginResult* result = nil;
if (self.metadata) { if (self.metadata) {
CGImageSourceRef sourceImage = CGImageSourceCreateWithData((__bridge_retained CFDataRef)self.data, NULL); CGImageSourceRef sourceImage = CGImageSourceCreateWithData((__bridge CFDataRef)self.data, NULL);
CFStringRef sourceType = CGImageSourceGetType(sourceImage); CFStringRef sourceType = CGImageSourceGetType(sourceImage);
CGImageDestinationRef destinationImage = CGImageDestinationCreateWithData((__bridge CFMutableDataRef)self.data, sourceType, 1, NULL); CGImageDestinationRef destinationImage = CGImageDestinationCreateWithData((__bridge CFMutableDataRef)self.data, sourceType, 1, NULL);