github/cordova-plugin-screen-orientation
github/cordova-plugin-screen-orientation
3
0
Fork 0
mirror of https://github.com/apache/cordova-plugin-screen-orientation.git synced 2025-02-23 08:32:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

test: let Jasmine handle promises (#57)

Browse Source 
* test: let Jasmine handle promises

Last in line for apache/cordova#169

* lock in portrait mode to avoid trouble on CI

cordova-paramedic runs the SauceLabs CI tests in portrait mode. For
the Android 7.0 target, it seemed as our locking to landscape interferes
with the Appium driver trying to set the app to portrait orientation.
The result is a failure to connect to the device and finally a timeout.
To avoid that, we are locking the app into portrait mode instead.

* test: verify orientation after locking
This commit is contained in:
Raphael von der Grün 2019-11-21 11:49:39 +01:00 committed by GitHub
parent 8d76ec1b00
commit 464ab8541c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tests/tests.js
View File

@ -117,25 +117,11 @@ exports.defineAutoTests = function() {
// test onchange works // test onchange works
describe('window.screen.orientation', function() { describe('window.screen.orientation', function() {
it('should successfully lock and unlock screen orientation, lock should return a promise', function(done) { it('should successfully lock and unlock screen orientation', function() {
return window.screen.orientation.lock('portrait').then(function() {
try { expect(window.screen.orientation.type).toMatch(/^portrait-/);
var promise = window.screen.orientation.lock('landscape'); expect(window.screen.orientation.unlock).not.toThrow();
expect(promise).toBeDefined(); });
expect(typeof promise.then).toBe('function');
promise.then(function() {
expect(window.screen.orientation.unlock).not.toThrow();
done();
}, function(err) {
expect(err).toBeDefined();
fail(err);
done();
});
} catch (err) {
fail(err);
done();
}
}); });
}); });
}; };