From f5ab4e7baf9fe93a1bb718e07276a9f8c4ff4177 Mon Sep 17 00:00:00 2001
From: EddyVerbruggen <eddyverbruggen@gmail.com>
Date: Sat, 25 Jan 2014 13:52:59 +0100
Subject: [PATCH] further impl Android

---
 src/android/nl/xservices/plugins/Toast.java | 34 ++++++++-------------
 1 file changed, 13 insertions(+), 21 deletions(-)

diff --git a/src/android/nl/xservices/plugins/Toast.java b/src/android/nl/xservices/plugins/Toast.java
index 36c23c8..44fdf8a 100644
--- a/src/android/nl/xservices/plugins/Toast.java
+++ b/src/android/nl/xservices/plugins/Toast.java
@@ -18,27 +18,10 @@ public class Toast extends CordovaPlugin {
       final String duration = args.getString(1);
       final String position = args.getString(2);
 
-      if (!"top".equals(position) && !"center".equals(position) && !"bottom".equals(position)) {
-        callbackContext.error("invalid position. valid options are 'top', 'center' and 'bottom'");
-        return false;
-      }
-
-      int durationInt;
-      if ("short".equals(duration)) {
-        durationInt = android.widget.Toast.LENGTH_SHORT;
-      } else if ("long".equals(duration)) {
-        durationInt = android.widget.Toast.LENGTH_LONG;
-      } else {
-        callbackContext.error("invalid duration. valid options are 'short' and 'long'");
-        return false;
-      }
-
       cordova.getActivity().runOnUiThread(new Runnable() {
         public void run() {
-          android.widget.Toast toast = android.widget.Toast.makeText(
-              webView.getContext(),
-              message,
-              durationInt);
+          android.widget.Toast toast = new android.widget.Toast(webView.getContext());
+          toast.setText(message);
 
           if ("top".equals(position)) {
             // TODO correct position
@@ -46,12 +29,21 @@ public class Toast extends CordovaPlugin {
           } else  if ("bottom".equals(position)) {
             // TODO correct position
             toast.setGravity(Gravity.CENTER_VERTICAL|Gravity.CENTER_HORIZONTAL, 0, 0);
-          } else {
+          } else if ("center".equals(position)) {
             toast.setGravity(Gravity.CENTER_VERTICAL|Gravity.CENTER_HORIZONTAL, 0, 0);
+          } else {
+            callbackContext.error("invalid position. valid options are 'top', 'center' and 'bottom'");
+          }
+
+          if ("short".equals(duration)) {
+            toast.setDuration(android.widget.Toast.LENGTH_SHORT);
+          } else if ("long".equals(duration)) {
+            toast.setDuration(android.widget.Toast.LENGTH_LONG);
+          } else {
+            callbackContext.error("invalid duration. valid options are 'short' and 'long'");
           }
 
           toast.show();
-
           callbackContext.success();
         }
       });