From 5d775978c689afbdac3bc04fd8023c211cb2d50c Mon Sep 17 00:00:00 2001 From: Ferdy Fauzi Date: Fri, 24 Mar 2017 02:16:12 +0800 Subject: [PATCH 1/6] docs(camera): fix typo Fix typing error for line 104 & 107 - change constant to const - change enodingType to encodingType --- src/@ionic-native/plugins/camera/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/@ionic-native/plugins/camera/index.ts b/src/@ionic-native/plugins/camera/index.ts index 4a128465..ce52f720 100644 --- a/src/@ionic-native/plugins/camera/index.ts +++ b/src/@ionic-native/plugins/camera/index.ts @@ -101,10 +101,10 @@ export interface CameraPopoverOptions { * ... * * - * constant options: CameraOptions = { + * const options: CameraOptions = { * quality: 100, * destinationType: this.camera.DestinationType.DATA_URL, - * enodingType: this.camera.EncodingType.JPEG, + * encodingType: this.camera.EncodingType.JPEG, * mediaType: this.camera.MediaType.PICTURE * } * From 5ccc558380ed993f8c2b76475b837cd98825d369 Mon Sep 17 00:00:00 2001 From: JamesLeeTrigg Date: Thu, 23 Mar 2017 18:17:36 +0000 Subject: [PATCH 2/6] docs(secure-storage): fix typo (#1236) SecureStorageObject has a capital B --- src/@ionic-native/plugins/secure-storage/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/secure-storage/index.ts b/src/@ionic-native/plugins/secure-storage/index.ts index 8102f298..5e9d7a9a 100644 --- a/src/@ionic-native/plugins/secure-storage/index.ts +++ b/src/@ionic-native/plugins/secure-storage/index.ts @@ -53,7 +53,7 @@ export class SecureStorageObject { * @usage * * ```typescript - * import { SecureStorage, SecureStorageOBject } from '@ionic-native/secure-storage'; + * import { SecureStorage, SecureStorageObject } from '@ionic-native/secure-storage'; * * constructor(private secureStorage: SecureStorage) { } * From b012bb62d7cf2d4bf7d9efdafa177312b8212dfe Mon Sep 17 00:00:00 2001 From: Daniel Cregg Date: Thu, 23 Mar 2017 18:18:25 +0000 Subject: [PATCH 3/6] docs(camera): fix typo (#1231) From ee40475891e0f0784135581e484f8cc5729f0ca3 Mon Sep 17 00:00:00 2001 From: Swapnil Patwa Date: Thu, 23 Mar 2017 23:48:54 +0530 Subject: [PATCH 4/6] docs(browser-tab): fix method name (#1230) --- src/@ionic-native/plugins/browser-tab/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/browser-tab/index.ts b/src/@ionic-native/plugins/browser-tab/index.ts index f1620451..06a002c6 100644 --- a/src/@ionic-native/plugins/browser-tab/index.ts +++ b/src/@ionic-native/plugins/browser-tab/index.ts @@ -17,7 +17,7 @@ import { Injectable } from '@angular/core'; * * if (isAvailable) { * - * browserTab.open('https://ionic.io'); + * browserTab.openUrl('https://ionic.io'); * * } else { * From 91c879af27cf6d12faf3815cab8a4aae040696e1 Mon Sep 17 00:00:00 2001 From: Ibby Date: Thu, 23 Mar 2017 15:04:21 -0400 Subject: [PATCH 5/6] docs(): add overview and browser usage to menu --- scripts/docs/templates/native_menu.template.html | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/docs/templates/native_menu.template.html b/scripts/docs/templates/native_menu.template.html index abe7a91c..a5c95865 100644 --- a/scripts/docs/templates/native_menu.template.html +++ b/scripts/docs/templates/native_menu.template.html @@ -1,3 +1,9 @@ +
  • + Overview +
  • +
  • + Browser Usage +
  • <@ for doc in docs @><@ if doc.URL and doc.private != true and doc.beta != true @>
  • <$ doc.name $> From bf2ba2e9e7073ab1116ee04178d695110e076a25 Mon Sep 17 00:00:00 2001 From: Ibby Date: Thu, 23 Mar 2017 15:18:35 -0400 Subject: [PATCH 6/6] chore(docs): fix native menu rendering --- scripts/docs/processors/jekyll.js | 4 ++-- scripts/docs/processors/npm-id.js | 2 +- scripts/docs/templates/native_menu.template.html | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/scripts/docs/processors/jekyll.js b/scripts/docs/processors/jekyll.js index 99322498..56a2032c 100644 --- a/scripts/docs/processors/jekyll.js +++ b/scripts/docs/processors/jekyll.js @@ -26,8 +26,8 @@ module.exports = function jekyll(renderDocsProcessor) { }); docs.push({ - docType: 'native_menu-menu', - id: 'native_menu-menu', + docType: 'nativeMenu', + id: 'native_menu', template: 'native_menu.template.html', outputPath: 'content/_includes/v2_fluid/native_menu.html' }); diff --git a/scripts/docs/processors/npm-id.js b/scripts/docs/processors/npm-id.js index 3097e443..4e1a7f4a 100644 --- a/scripts/docs/processors/npm-id.js +++ b/scripts/docs/processors/npm-id.js @@ -2,7 +2,7 @@ module.exports = function npmId(renderDocsProcessor) { return { name: 'npm-id', $runAfter: ['paths-computed'], - $runBefore: ['rendering-docs'], + $runBefore: ['jekyll'], $process: function(docs) { var currentVersion = renderDocsProcessor.extraData.version.current.name; diff --git a/scripts/docs/templates/native_menu.template.html b/scripts/docs/templates/native_menu.template.html index a5c95865..d2deb358 100644 --- a/scripts/docs/templates/native_menu.template.html +++ b/scripts/docs/templates/native_menu.template.html @@ -4,12 +4,11 @@
  • Browser Usage
  • -<@ for doc in docs @><@ if doc.URL and doc.private != true and doc.beta != true @> +<@- for doc in docs @><@ if doc.URL and doc.private != true and doc.beta != true @>
  • <$ doc.name $>
  • <@ endif @><@ endfor @> - -<@ for doc in docs @><@ if doc.URL and doc.private != true and doc.beta == true @> +<@- for doc in docs @><@ if doc.URL and doc.private != true and doc.beta == true @>
  • <$ doc.name $> β
  • <@ endif @><@ endfor @>