From a151295654ae3c07610364c78f99482eed86bb0a Mon Sep 17 00:00:00 2001 From: Ibby Hadeed Date: Fri, 24 Mar 2017 15:07:44 -0400 Subject: [PATCH 1/3] fix(core): make properties enumerable --- src/@ionic-native/core/decorators.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/@ionic-native/core/decorators.ts b/src/@ionic-native/core/decorators.ts index 797b9382..e0983440 100644 --- a/src/@ionic-native/core/decorators.ts +++ b/src/@ionic-native/core/decorators.ts @@ -259,6 +259,7 @@ export function CordovaInstance(opts: any = {}) { */ export function CordovaProperty(target: any, key: string) { Object.defineProperty(target, key, { + enumerable: true, get: () => { if (checkAvailability(target, key) === true) { return getPlugin(target.constructor.getPluginRef())[key]; @@ -282,6 +283,7 @@ export function CordovaProperty(target: any, key: string) { */ export function InstanceProperty(target: any, key: string) { Object.defineProperty(target, key, { + enumerable: true, get: function(){ return this._objectInstance[key]; }, From a5ed62e56a563475b0f1b4e188404888455e5305 Mon Sep 17 00:00:00 2001 From: Ibby Hadeed Date: Fri, 24 Mar 2017 15:16:27 -0400 Subject: [PATCH 2/3] docs(camera-preview): fix package name --- src/@ionic-native/plugins/camera-preview/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/@ionic-native/plugins/camera-preview/index.ts b/src/@ionic-native/plugins/camera-preview/index.ts index 5b4a6fea..48ca6c78 100644 --- a/src/@ionic-native/plugins/camera-preview/index.ts +++ b/src/@ionic-native/plugins/camera-preview/index.ts @@ -57,7 +57,7 @@ export interface CameraPreviewPictureOptions { * * @usage * ```typescript - * import { CameraPreview, PictureOptions, CameraPreviewOptions, CameraPreviewDimensions } from 'ionic-native'; + * import { CameraPreview, PictureOptions, CameraPreviewOptions, CameraPreviewDimensions } from '@ionic-native/camera-preview'; * * constructor(private cameraPreview: CameraPreview) { } * From d4a9abfc611392dfaf6672b613227b1cbad60014 Mon Sep 17 00:00:00 2001 From: Ibby Hadeed Date: Fri, 24 Mar 2017 15:17:35 -0400 Subject: [PATCH 3/3] docs(camera-preview): mark params as optional --- src/@ionic-native/plugins/camera-preview/index.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/@ionic-native/plugins/camera-preview/index.ts b/src/@ionic-native/plugins/camera-preview/index.ts index 48ca6c78..36365ce5 100644 --- a/src/@ionic-native/plugins/camera-preview/index.ts +++ b/src/@ionic-native/plugins/camera-preview/index.ts @@ -211,7 +211,7 @@ export class CameraPreview { /** * Set the zoom (Android) - * @param zoom {number} Zoom value + * @param [zoom] {number} Zoom value * @return {Promise} */ @Cordova({ @@ -223,7 +223,7 @@ export class CameraPreview { /** * Set the preview Size - * @param dimensions {CameraPreviewDimensions} + * @param [dimensions] {CameraPreviewDimensions} * @return {Promise} */ @Cordova({ @@ -235,7 +235,7 @@ export class CameraPreview { /** * Set the flashmode - * @param flashMode {string} 'off' (iOS & Android), 'on' (iOS & Android), 'auto' (iOS & Android), 'torch' (Android) + * @param [flashMode] {string} 'off' (iOS & Android), 'on' (iOS & Android), 'auto' (iOS & Android), 'torch' (Android) * @return {Promise} */ @Cordova({