From ed94d0dd30831810eeb8c28523d08934c521ae00 Mon Sep 17 00:00:00 2001
From: William Quast <will@bohemian.cc>
Date: Tue, 29 May 2012 18:59:31 -0500
Subject: [PATCH 1/4] Make PluginResult return valid JSON so the JS side can
 use JSON.parse

---
 framework/src/org/apache/cordova/api/PluginResult.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/src/org/apache/cordova/api/PluginResult.java b/framework/src/org/apache/cordova/api/PluginResult.java
index c3ef6d6a..73efab9a 100755
--- a/framework/src/org/apache/cordova/api/PluginResult.java
+++ b/framework/src/org/apache/cordova/api/PluginResult.java
@@ -80,7 +80,7 @@ public class PluginResult {
 	}
 	
 	public String getJSONString() {
-		return "{status:" + this.status + ",message:" + this.message + ",keepCallback:" + this.keepCallback + "}";
+		return "{\"status\":" + this.status + ",\"message\":" + this.message + ",\"keepCallback\":" + this.keepCallback + "}";
 	}
 	
 	public String toSuccessCallbackString(String callbackId) {

From c21e8c9c87feea7d81779f6c12d92de0a0f857f7 Mon Sep 17 00:00:00 2001
From: macdonst <simon.macdonald@gmail.com>
Date: Wed, 30 May 2012 21:07:56 -0400
Subject: [PATCH 2/4] CB-849: Cannot search by birthday

---
 .../org/apache/cordova/ContactAccessor.java   | 191 +++++++++---------
 .../apache/cordova/ContactAccessorSdk5.java   |  27 ++-
 2 files changed, 117 insertions(+), 101 deletions(-)

diff --git a/framework/src/org/apache/cordova/ContactAccessor.java b/framework/src/org/apache/cordova/ContactAccessor.java
index 12669ce4..d2bf66c8 100644
--- a/framework/src/org/apache/cordova/ContactAccessor.java
+++ b/framework/src/org/apache/cordova/ContactAccessor.java
@@ -18,7 +18,6 @@ package org.apache.cordova;
 
 import java.util.HashMap;
 
-import android.app.Activity;
 import android.content.Context;
 import android.util.Log;
 import android.webkit.WebView;
@@ -48,21 +47,21 @@ public abstract class ContactAccessor {
      * @return true if the key data is required
      */
     protected boolean isRequired(String key, HashMap<String,Boolean> map) {
-    Boolean retVal = map.get(key);
-    return (retVal == null) ? false : retVal.booleanValue();
-  }
+        Boolean retVal = map.get(key);
+        return (retVal == null) ? false : retVal.booleanValue();
+    }
     
     /**
      * Create a hash map of what data needs to be populated in the Contact object
      * @param fields the list of fields to populate
      * @return the hash map of required data
      */
-  protected HashMap<String,Boolean> buildPopulationSet(JSONArray fields) {
-    HashMap<String,Boolean> map = new HashMap<String,Boolean>();
+    protected HashMap<String,Boolean> buildPopulationSet(JSONArray fields) {
+        HashMap<String,Boolean> map = new HashMap<String,Boolean>();
     
-    String key;
-    try {
-        if (fields.length() == 1 && fields.getString(0).equals("*")) {
+        String key;
+        try {
+            if (fields.length() == 1 && fields.getString(0).equals("*")) {
                 map.put("displayName", true);
                 map.put("name", true);
                 map.put("nickname", true);
@@ -76,90 +75,90 @@ public abstract class ContactAccessor {
                 map.put("urls", true);
                 map.put("photos", true);
                 map.put("categories", true);
-        } 
-        else {
-          for (int i=0; i<fields.length(); i++) {
-            key = fields.getString(i);
-            if (key.startsWith("displayName")) {
-              map.put("displayName", true);
-            }
-            else if (key.startsWith("name")) {
-                map.put("displayName", true);
-                map.put("name", true);
-            }
-            else if (key.startsWith("nickname")) {
-              map.put("nickname", true);
-            }
-            else if (key.startsWith("phoneNumbers")) {
-              map.put("phoneNumbers", true);
-            }
-            else if (key.startsWith("emails")) {
-              map.put("emails", true);
-            }
-            else if (key.startsWith("addresses")) {
-              map.put("addresses", true);
-            }
-            else if (key.startsWith("ims")) {
-              map.put("ims", true);
-            }
-            else if (key.startsWith("organizations")) {
-              map.put("organizations", true);
-            }
-            else if (key.startsWith("birthday")) {
-              map.put("birthday", true);
-            }
-            else if (key.startsWith("note")) {
-              map.put("note", true);
-            }
-            else if (key.startsWith("urls")) {
-              map.put("urls", true);
-            }
+            } 
+            else {
+                for (int i=0; i<fields.length(); i++) {
+                    key = fields.getString(i);
+                    if (key.startsWith("displayName")) {
+                        map.put("displayName", true);
+                    }
+                    else if (key.startsWith("name")) {
+                        map.put("displayName", true);
+                        map.put("name", true);
+                    }
+                    else if (key.startsWith("nickname")) {
+                        map.put("nickname", true);
+                    }
+                    else if (key.startsWith("phoneNumbers")) {
+                        map.put("phoneNumbers", true);
+                    }
+                    else if (key.startsWith("emails")) {
+                        map.put("emails", true);
+                    }
+                    else if (key.startsWith("addresses")) {
+                        map.put("addresses", true);
+                    }
+                    else if (key.startsWith("ims")) {
+                        map.put("ims", true);
+                    }
+                    else if (key.startsWith("organizations")) {
+                        map.put("organizations", true);
+                    }
+                    else if (key.startsWith("birthday")) {
+                        map.put("birthday", true);
+                    }
+                    else if (key.startsWith("note")) {
+                        map.put("note", true);
+                    }
+                    else if (key.startsWith("urls")) {
+                        map.put("urls", true);
+                    }
                     else if (key.startsWith("photos")) {
                         map.put("photos", true);
                     }
                     else if (key.startsWith("categories")) {
                         map.put("categories", true);
                     }
-          }
+                }
+            }
         }
+        catch (JSONException e) {
+            Log.e(LOG_TAG, e.getMessage(), e);
+        }
+        return map;
     }
-    catch (JSONException e) {
-      Log.e(LOG_TAG, e.getMessage(), e);
-    }
-    return map;
-  }
   
-  /**
-   * Convenience method to get a string from a JSON object.  Saves a 
-   * lot of try/catch writing.
-   * If the property is not found in the object null will be returned.
-   * 
-   * @param obj contact object to search
-   * @param property to be looked up
-   * @return The value of the property
-   */
-  protected String getJsonString(JSONObject obj, String property) {
-    String value = null;
-    try {
-        if (obj != null) {
-      value = obj.getString(property);
-          if (value.equals("null")) {
-            Log.d(LOG_TAG, property + " is string called 'null'");
-            value = null;
-          }
+    /**
+     * Convenience method to get a string from a JSON object.  Saves a 
+     * lot of try/catch writing.
+     * If the property is not found in the object null will be returned.
+     * 
+     * @param obj contact object to search
+     * @param property to be looked up
+     * @return The value of the property
+     */
+    protected String getJsonString(JSONObject obj, String property) {
+        String value = null;
+        try {
+            if (obj != null) {
+                value = obj.getString(property);
+                if (value.equals("null")) {
+                    Log.d(LOG_TAG, property + " is string called 'null'");
+                    value = null;
+                }
+            }
         }
+        catch (JSONException e) {
+            Log.d(LOG_TAG, "Could not get = " + e.getMessage());
+        }   
+        return value;
     }
-    catch (JSONException e) {
-      Log.d(LOG_TAG, "Could not get = " + e.getMessage());
-    }   
-    return value;
-  }
 
     /**
      * Handles adding a JSON Contact object into the database.
      * @return TODO
      */
-  public abstract String save(JSONObject contact);
+    public abstract String save(JSONObject contact);
 
     /**
      * Handles searching through SDK-specific contacts API.
@@ -175,25 +174,25 @@ public abstract class ContactAccessor {
     /**
      * Handles removing a contact from the database.
      */
-  public abstract boolean remove(String id);
+    public abstract boolean remove(String id);
   
-  /**
-   * A class that represents the where clause to be used in the database query 
-   */
-  class WhereOptions {
-    private String where;
-    private String[] whereArgs;
-    public void setWhere(String where) {
-      this.where = where;
+    /**
+     * A class that represents the where clause to be used in the database query 
+     */
+    class WhereOptions {
+        private String where;
+        private String[] whereArgs;
+        public void setWhere(String where) {
+            this.where = where;
+        }
+        public String getWhere() {
+            return where;
+        }
+        public void setWhereArgs(String[] whereArgs) {
+            this.whereArgs = whereArgs;
+        }
+        public String[] getWhereArgs() {
+            return whereArgs;
+        }
     }
-    public String getWhere() {
-      return where;
-    }
-    public void setWhereArgs(String[] whereArgs) {
-      this.whereArgs = whereArgs;
-    }
-    public String[] getWhereArgs() {
-      return whereArgs;
-    }
-  }
 }
diff --git a/framework/src/org/apache/cordova/ContactAccessorSdk5.java b/framework/src/org/apache/cordova/ContactAccessorSdk5.java
index 2237e7ee..9e672e93 100644
--- a/framework/src/org/apache/cordova/ContactAccessorSdk5.java
+++ b/framework/src/org/apache/cordova/ContactAccessorSdk5.java
@@ -25,7 +25,10 @@ import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URL;
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
 import java.util.ArrayList;
+import java.util.Date;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
@@ -111,7 +114,7 @@ public class ContactAccessorSdk5 extends ContactAccessor {
       dbMap.put("organizations.name", ContactsContract.CommonDataKinds.Organization.COMPANY);
       dbMap.put("organizations.department", ContactsContract.CommonDataKinds.Organization.DEPARTMENT);
       dbMap.put("organizations.title", ContactsContract.CommonDataKinds.Organization.TITLE);
-      dbMap.put("birthday", ContactsContract.CommonDataKinds.Event.CONTENT_ITEM_TYPE);
+      dbMap.put("birthday", ContactsContract.CommonDataKinds.Event.START_DATE);
       dbMap.put("note", ContactsContract.CommonDataKinds.Note.NOTE);
       dbMap.put("photos.value", ContactsContract.CommonDataKinds.Photo.CONTENT_ITEM_TYPE);
       //dbMap.put("categories.value", null);
@@ -579,10 +582,24 @@ public class ContactAccessorSdk5 extends ContactAccessor {
           whereArgs.add(searchTerm);
           whereArgs.add(ContactsContract.CommonDataKinds.Organization.CONTENT_ITEM_TYPE);
         }
-//        else if (key.startsWith("birthday")) {
-//          where.add("(" + dbMap.get(key) + " LIKE ? AND " 
-//              + ContactsContract.Data.MIMETYPE + " = ? )");                 
-//        }
+        else if (key.startsWith("birthday")) {
+            try {
+                SimpleDateFormat format = new SimpleDateFormat("EEEE, MMMM dd, yyyy");
+                Date searchDate = format.parse(searchTerm.substring(1, searchTerm.length()-1));
+                // Have to subtract one from the month as JavaScript's January is 01
+                // while Java's January is 00.
+                searchDate.setMonth(searchDate.getMonth()-1);
+                SimpleDateFormat newFormat = new SimpleDateFormat("yyyy-MM-dd");
+                
+                where.add("(" + dbMap.get(key) + " = ? AND " 
+                    + ContactsContract.Data.MIMETYPE + " = ? )");                 
+                whereArgs.add(newFormat.format(searchDate));
+                whereArgs.add(ContactsContract.CommonDataKinds.Event.CONTENT_ITEM_TYPE);
+            }
+            catch (ParseException e) {
+                Log.d(LOG_TAG, "Bad romance format");
+            }
+        }
         else if (key.startsWith("note")) {
           where.add("(" + dbMap.get(key) + " LIKE ? AND " 
               + ContactsContract.Data.MIMETYPE + " = ? )");       

From 508cafad1da34b984e8e601abe37f2cf49b1f7d4 Mon Sep 17 00:00:00 2001
From: macdonst <simon.macdonald@gmail.com>
Date: Sat, 2 Jun 2012 11:12:12 -0400
Subject: [PATCH 3/4] Change 'websites' to 'urls'

---
 framework/src/org/apache/cordova/ContactAccessorSdk5.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/src/org/apache/cordova/ContactAccessorSdk5.java b/framework/src/org/apache/cordova/ContactAccessorSdk5.java
index 9e672e93..02047e8c 100644
--- a/framework/src/org/apache/cordova/ContactAccessorSdk5.java
+++ b/framework/src/org/apache/cordova/ContactAccessorSdk5.java
@@ -1166,7 +1166,7 @@ public class ContactAccessorSdk5 extends ContactAccessor {
     // Modify urls  
     JSONArray websites = null;
     try {
-      websites = contact.getJSONArray("websites");
+      websites = contact.getJSONArray("urls");
       if (websites != null) {
         for (int i=0; i<websites.length(); i++) {
           JSONObject website = (JSONObject)websites.get(i);

From 24e5c24dd46f36bb6d2588aa7874b7bd9a9fb1f1 Mon Sep 17 00:00:00 2001
From: macdonst <simon.macdonald@gmail.com>
Date: Mon, 4 Jun 2012 16:21:13 -0400
Subject: [PATCH 4/4] Cb-858: Media record defaults to sdcard which may not be
 mounted

---
 .../src/org/apache/cordova/AudioPlayer.java     | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/framework/src/org/apache/cordova/AudioPlayer.java b/framework/src/org/apache/cordova/AudioPlayer.java
index 35b408a4..9397ec74 100755
--- a/framework/src/org/apache/cordova/AudioPlayer.java
+++ b/framework/src/org/apache/cordova/AudioPlayer.java
@@ -85,7 +85,11 @@ public class AudioPlayer implements OnCompletionListener, OnPreparedListener, On
 	public AudioPlayer(AudioHandler handler, String id) {
 		this.handler = handler;
 		this.id = id;
-        this.tempFile = Environment.getExternalStorageDirectory().getAbsolutePath() + "/tmprecording.mp3";
+        if (Environment.getExternalStorageState().equals(Environment.MEDIA_MOUNTED)) {
+            this.tempFile = Environment.getExternalStorageDirectory().getAbsolutePath() + "/tmprecording.mp3";
+        } else {
+            this.tempFile = "/data/data/" + handler.ctx.getPackageName() + "/cache/tmprecording.mp3";
+        }
 	}	
 
 	/**
@@ -151,11 +155,16 @@ public class AudioPlayer implements OnCompletionListener, OnPreparedListener, On
 	 * 
 	 * @param file
 	 */
-	public void moveFile(String file) {
-		
+	public void moveFile(String file) {	
 		/* this is a hack to save the file as the specified name */
 		File f = new File(this.tempFile);
-		f.renameTo(new File("/sdcard/" + file));
+        if (Environment.getExternalStorageState().equals(Environment.MEDIA_MOUNTED)) {
+            f.renameTo(new File(Environment.getExternalStorageDirectory().getAbsolutePath() 
+                    + File.separator + file));
+        } else {
+            f.renameTo(new File("/data/data/" + handler.ctx.getPackageName() + "/cache/" + file));
+        }
+		
 	}
 	
     /**