public/cordova-android
public/cordova-android
9
0
Fork 0
forked from github/cordova-android
Code Pull Requests Activity

Fix output and exit code for Java tests

Browse Source 
This fixes the following issues:
* run_java_unit_tests.js always has exit code of 0 thus never failing
  the npm tests.
* "Tests completed successfully" is printed after failing to create the
  Gradle wrapper and never running the tests.
* Gradle errors are printed twice
This commit is contained in:
Raphael von der Grün 2018-06-13 16:09:03 +02:00
parent bf29fe0e10
commit 0d4b9f4ba6
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/run_java_unit_tests.js
View File

@ -37,11 +37,15 @@ if (!needs_gradlew_built) {
} }
needs_gradlew_built.then(function () { needs_gradlew_built.then(function () {
console.log('Gradle wrapper is ready. Running tests now.');
return superspawn.spawn(path.join(__dirname, 'gradlew'), ['test'], {stdio: 'inherit'}); return superspawn.spawn(path.join(__dirname, 'gradlew'), ['test'], {stdio: 'inherit'});
}, function (err) {
console.error('There was an error building the gradlew file:', err);
}).then(function () { }).then(function () {
console.log('Tests completed successfully.'); console.log('Tests completed successfully.');
}).fail(function (err) { });
console.error('Tests failed!', err);
process.on('unhandledRejection', err => {
// If err has a stderr property, we have seen the message already
if (!('stderr' in err)) console.error(err.message);
console.error('JAVA UNIT TESTS FAILED!');
process.exitCode = err.code || 1;
}); });