From 7ad3f76d9a96c26c618b03db0bd611fd5f796f39 Mon Sep 17 00:00:00 2001 From: Bryce Curtis Date: Thu, 3 Nov 2011 14:22:29 -0500 Subject: [PATCH] Don't fire resume upon init - only when returning from background. Lifecycle behavior for PhoneGap app: window.onload = loading html page pause = html page entering background (not displayed) resume = html page entering foreground (displayed) window.onunload = leaving html page --- framework/assets/js/phonegap.js.base | 19 ------------------- framework/src/com/phonegap/DroidGap.java | 4 ++-- .../src/com/phonegap/api/PluginManager.java | 1 - 3 files changed, 2 insertions(+), 22 deletions(-) diff --git a/framework/assets/js/phonegap.js.base b/framework/assets/js/phonegap.js.base index 64f0b272..b1ab0a00 100755 --- a/framework/assets/js/phonegap.js.base +++ b/framework/assets/js/phonegap.js.base @@ -273,18 +273,6 @@ PhoneGap.onPhoneGapInfoReady = new PhoneGap.Channel('onPhoneGapInfoReady'); */ PhoneGap.onPhoneGapConnectionReady = new PhoneGap.Channel('onPhoneGapConnectionReady'); -/** - * onResume channel is fired when the PhoneGap native code - * resumes. - */ -PhoneGap.onResume = new PhoneGap.Channel('onResume'); - -/** - * onPause channel is fired when the PhoneGap native code - * pauses. - */ -PhoneGap.onPause = new PhoneGap.Channel('onPause'); - /** * onDestroy channel is fired when the PhoneGap native code * is destroyed. It is used internally. @@ -424,13 +412,6 @@ document.addEventListener = function(evt, handler, capture) { var e = evt.toLowerCase(); if (e === 'deviceready') { PhoneGap.onDeviceReady.subscribeOnce(handler); - } else if (e === 'resume') { - PhoneGap.onResume.subscribe(handler); - if (PhoneGap.onDeviceReady.fired) { - PhoneGap.onResume.fire(); - } - } else if (e === 'pause') { - PhoneGap.onPause.subscribe(handler); } else { // If subscribing to Android backbutton diff --git a/framework/src/com/phonegap/DroidGap.java b/framework/src/com/phonegap/DroidGap.java index 8eddc755..aca0d738 100755 --- a/framework/src/com/phonegap/DroidGap.java +++ b/framework/src/com/phonegap/DroidGap.java @@ -719,7 +719,7 @@ public class DroidGap extends PhonegapActivity { } // Send pause event to JavaScript - this.appView.loadUrl("javascript:try{PhoneGap.onPause.fire();}catch(e){};"); + this.appView.loadUrl("javascript:try{PhoneGap.fireDocumentEvent('pause');}catch(e){};"); // Forward to plugins this.pluginManager.onPause(this.keepRunning); @@ -760,7 +760,7 @@ public class DroidGap extends PhonegapActivity { } // Send resume event to JavaScript - this.appView.loadUrl("javascript:try{PhoneGap.onResume.fire();}catch(e){};"); + this.appView.loadUrl("javascript:try{PhoneGap.fireDocumentEvent('resume');}catch(e){};"); // Forward to plugins this.pluginManager.onResume(this.keepRunning || this.activityResultKeepRunning); diff --git a/framework/src/com/phonegap/api/PluginManager.java b/framework/src/com/phonegap/api/PluginManager.java index 11cabfbc..5c553f08 100755 --- a/framework/src/com/phonegap/api/PluginManager.java +++ b/framework/src/com/phonegap/api/PluginManager.java @@ -228,7 +228,6 @@ public final class PluginManager { this.plugins.put(className, plugin); plugin.setContext(this.ctx); plugin.setView(this.app); - plugin.onResume(true); return plugin; } } catch (Exception e) {