public/cordova-android
public/cordova-android
9
0
Fork 0
forked from github/cordova-android
Code Pull Requests Activity

File APIs should return error code instead of object.

Browse Source
This commit is contained in:
Bryce Curtis 2012-02-28 22:30:27 -06:00
parent d593448182
commit f6503f8476
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
framework/src/org/apache/cordova/FileUtils.java
View File

@ -131,8 +131,7 @@ public class FileUtils extends Plugin {
long size = args.optLong(1); long size = args.optLong(1);
if (size != 0) { if (size != 0) {
if (size > (DirectoryManager.getFreeDiskSpace(true)*1024)) { if (size > (DirectoryManager.getFreeDiskSpace(true)*1024)) {
JSONObject error = new JSONObject().put("code", FileUtils.QUOTA_EXCEEDED_ERR); return new PluginResult(PluginResult.Status.ERROR, FileUtils.QUOTA_EXCEEDED_ERR);
return new PluginResult(PluginResult.Status.ERROR, error);
} }
} }
JSONObject obj = requestFileSystem(args.getInt(0)); JSONObject obj = requestFileSystem(args.getInt(0));
@ -171,8 +170,7 @@ public class FileUtils extends Plugin {
notifyDelete(args.getString(0)); notifyDelete(args.getString(0));
return new PluginResult(status); return new PluginResult(status);
} else { } else {
JSONObject error = new JSONObject().put("code", FileUtils.NO_MODIFICATION_ALLOWED_ERR); return new PluginResult(PluginResult.Status.ERROR, FileUtils.NO_MODIFICATION_ALLOWED_ERR);
return new PluginResult(PluginResult.Status.ERROR, error);
} }
} }
else if (action.equals("removeRecursively")) { else if (action.equals("removeRecursively")) {
@ -180,8 +178,7 @@ public class FileUtils extends Plugin {
if (success) { if (success) {
return new PluginResult(status); return new PluginResult(status);
} else { } else {
JSONObject error = new JSONObject().put("code", FileUtils.NO_MODIFICATION_ALLOWED_ERR); return new PluginResult(PluginResult.Status.ERROR, FileUtils.NO_MODIFICATION_ALLOWED_ERR);
return new PluginResult(PluginResult.Status.ERROR, error);
} }
} }
else if (action.equals("moveTo")) { else if (action.equals("moveTo")) {